Inspection of "- Fixed typo en NCFRango xml views List and Edit" - joenilson/fsRepublicaDominicana - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( daee36...c706da )

by Joe Nilson

created 2022-03-02 19:44 UTC

Status

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -71,10 +71,10 @@
 block discarded – undo
     protected function getSQLFrom(): string
     {
         return static::MAIN_TABLE
-            . ' LEFT JOIN '. static::SECONDARY_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idfacturarect = ' . static::SECONDARY_TABLE_ALIAS . '.idfactura)'
-            . ' LEFT JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado)';
+            . ' LEFT JOIN '.static::SECONDARY_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idfacturarect = '.static::SECONDARY_TABLE_ALIAS.'.idfactura)'
+            . ' LEFT JOIN '.static::ESTADOSDOC_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado)';
     }
 
     /**

Please login to merge, or discard this patch.

Model/Join/FiscalReport606.php 1 patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -69,16 +69,16 @@  discard block
 block discarded – undo
     protected function getGroupFields(): string
     {
         //return parent::getGroupFields(); // TODO: Change the autogenerated stub
-        return  static::MAIN_TABLE.'.idempresa, ' .
-                static::MAIN_TABLE.'.codalmacen, ' .
-                static::MAIN_TABLE.'.cifnif, ' .
-                static::MAIN_TABLE.'.ncftipomovimiento, ' .
-                static::MAIN_TABLE.'.numproveedor, ' .
-                static::SECONDARY_TABLE_ALIAS.'.numproveedor, ' .
-                static::MAIN_TABLE.'.fecha, ' .
-                static::ESTADOSDOC_TABLE.'.nombre, ' .
-                static::MAIN_TABLE.'.neto, ' .
-                static::MAIN_TABLE.'.totaliva' .
+        return  static::MAIN_TABLE.'.idempresa, '.
+                static::MAIN_TABLE.'.codalmacen, '.
+                static::MAIN_TABLE.'.cifnif, '.
+                static::MAIN_TABLE.'.ncftipomovimiento, '.
+                static::MAIN_TABLE.'.numproveedor, '.
+                static::SECONDARY_TABLE_ALIAS.'.numproveedor, '.
+                static::MAIN_TABLE.'.fecha, '.
+                static::ESTADOSDOC_TABLE.'.nombre, '.
+                static::MAIN_TABLE.'.neto, '.
+                static::MAIN_TABLE.'.totaliva'.
             ' ';
     }
 
@@ -89,14 +89,14 @@  discard block
 block discarded – undo
     protected function getSQLFrom(): string
     {
         return static::MAIN_TABLE
-            . ' LEFT JOIN '. static::SECONDARY_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idfacturarect = ' . static::SECONDARY_TABLE_ALIAS . '.idfactura)'
-            . ' LEFT JOIN '. static::LINES_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idfactura = ' . static::LINES_TABLE . '.idfactura)'
-            . ' LEFT JOIN '. static::PRODS_TABLE . ' ON ('
-            . static::LINES_TABLE . '.referencia = ' . static::PRODS_TABLE . '.referencia)'
-            . ' LEFT JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado)';
+            . ' LEFT JOIN '.static::SECONDARY_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idfacturarect = '.static::SECONDARY_TABLE_ALIAS.'.idfactura)'
+            . ' LEFT JOIN '.static::LINES_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idfactura = '.static::LINES_TABLE.'.idfactura)'
+            . ' LEFT JOIN '.static::PRODS_TABLE.' ON ('
+            . static::LINES_TABLE.'.referencia = '.static::PRODS_TABLE.'.referencia)'
+            . ' LEFT JOIN '.static::ESTADOSDOC_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado)';
     }
 
     /**

Please login to merge, or discard this patch.

Model/Join/FiscalReports.php 1 patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -94,22 +94,22 @@
 block discarded – undo
     protected function getSQLFrom(): string
     {
         return static::MAIN_TABLE
-            . ' LEFT JOIN ' . static::LINES_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idfactura = ' . static::LINES_TABLE . '.idfactura)'
-            . ' LEFT JOIN '. static::SECONDARY_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idfacturarect = ' . static::SECONDARY_TABLE_ALIAS . '.idfactura)'
-            . ' LEFT JOIN '. static::ALMACENES_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.codalmacen = ' . static::ALMACENES_TABLE . '.codalmacen)'
-            . ' LEFT JOIN '. static::NCFTIPO_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.tipocomprobante = ' . static::NCFTIPO_TABLE . '.tipocomprobante)'
-            . ' LEFT JOIN ' . static::NCFTIPOPAGO_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.ncftipopago = ' . static::NCFTIPOPAGO_TABLE . '.codigo)'
-            . ' LEFT JOIN ' . static::NCFTIPOMOV_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.ncftipomovimiento = ' . static::NCFTIPOMOV_TABLE . '.codigo)'
-            . ' LEFT JOIN ' . static::NCFTIPOANUL_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.ncftipoanulacion = ' . static::NCFTIPOANUL_TABLE . '.codigo)'
-            . ' LEFT JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
-            . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado)';
+            . ' LEFT JOIN '.static::LINES_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idfactura = '.static::LINES_TABLE.'.idfactura)'
+            . ' LEFT JOIN '.static::SECONDARY_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idfacturarect = '.static::SECONDARY_TABLE_ALIAS.'.idfactura)'
+            . ' LEFT JOIN '.static::ALMACENES_TABLE.' ON ('
+            . static::MAIN_TABLE.'.codalmacen = '.static::ALMACENES_TABLE.'.codalmacen)'
+            . ' LEFT JOIN '.static::NCFTIPO_TABLE.' ON ('
+            . static::MAIN_TABLE.'.tipocomprobante = '.static::NCFTIPO_TABLE.'.tipocomprobante)'
+            . ' LEFT JOIN '.static::NCFTIPOPAGO_TABLE.' ON ('
+            . static::MAIN_TABLE.'.ncftipopago = '.static::NCFTIPOPAGO_TABLE.'.codigo)'
+            . ' LEFT JOIN '.static::NCFTIPOMOV_TABLE.' ON ('
+            . static::MAIN_TABLE.'.ncftipomovimiento = '.static::NCFTIPOMOV_TABLE.'.codigo)'
+            . ' LEFT JOIN '.static::NCFTIPOANUL_TABLE.' ON ('
+            . static::MAIN_TABLE.'.ncftipoanulacion = '.static::NCFTIPOANUL_TABLE.'.codigo)'
+            . ' LEFT JOIN '.static::ESTADOSDOC_TABLE.' ON ('
+            . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado)';
     }
 
     /**

Please login to merge, or discard this patch.

Extension/Model/Producto.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -16,13 +16,13 @@
 block discarded – undo
  * along with fsRepublicaDominicana. If not, see <http://www.gnu.org/licenses/>.
  */
 
- namespace FacturaScripts\Plugins\fsRepublicaDominicana\Extension\Model;
+    namespace FacturaScripts\Plugins\fsRepublicaDominicana\Extension\Model;
 
- class Producto
- {
+    class Producto
+    {
     /**
      * This field is to determinate if the product is a service or a good
      * @var boolean
      */
     public $esservicio;
- }
+    }

Please login to merge, or discard this patch.

Extension/Model/FacturaProveedor.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -47,8 +47,8 @@  discard block
 block discarded – undo
 
     public function saveInsert()
     {
-        return function () {
-            $ArrayTipoNCFCompras = ['11','12','16','17'];
+        return function() {
+            $ArrayTipoNCFCompras = ['11', '12', '16', '17'];
             $ncfrango = new NCFRango();
             $cliente = new Proveedor();
             $appSettings = new AppSettings;
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
             $tipocomprobante = $this->tipocomprobante;
             $ncfRangoToUse = $ncfrango->getByTipoComprobante($actualProveedor->idempresa, $tipocomprobante);
 
-            if(in_array($tipocomprobante, $ArrayTipoNCFCompras, true)) {
+            if (in_array($tipocomprobante, $ArrayTipoNCFCompras, true)) {
                 $ncf = $ncfRangoToUse->generateNCF();
                 $this->numproveedor = $ncf;
                 $this->ncffechavencimiento = $ncfRangoToUse->fechavencimiento;

Please login to merge, or discard this patch.

		@@ -71,10 +71,10 @@
		block discarded – undo
71	71	protected function getSQLFrom(): string
72	72	{
73	73	return static::MAIN_TABLE
74		- . ' LEFT JOIN '. static::SECONDARY_TABLE . ' ON ('
75		- . static::MAIN_TABLE . '.idfacturarect = ' . static::SECONDARY_TABLE_ALIAS . '.idfactura)'
76		- . ' LEFT JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
77		- . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado)';
	74	+ . ' LEFT JOIN '.static::SECONDARY_TABLE.' ON ('
	75	+ . static::MAIN_TABLE.'.idfacturarect = '.static::SECONDARY_TABLE_ALIAS.'.idfactura)'
	76	+ . ' LEFT JOIN '.static::ESTADOSDOC_TABLE.' ON ('
	77	+ . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado)';
78	78	}
79	79
80	80	/**

		@@ -94,22 +94,22 @@
		block discarded – undo
94	94	protected function getSQLFrom(): string
95	95	{
96	96	return static::MAIN_TABLE
97		- . ' LEFT JOIN ' . static::LINES_TABLE . ' ON ('
98		- . static::MAIN_TABLE . '.idfactura = ' . static::LINES_TABLE . '.idfactura)'
99		- . ' LEFT JOIN '. static::SECONDARY_TABLE . ' ON ('
100		- . static::MAIN_TABLE . '.idfacturarect = ' . static::SECONDARY_TABLE_ALIAS . '.idfactura)'
101		- . ' LEFT JOIN '. static::ALMACENES_TABLE . ' ON ('
102		- . static::MAIN_TABLE . '.codalmacen = ' . static::ALMACENES_TABLE . '.codalmacen)'
103		- . ' LEFT JOIN '. static::NCFTIPO_TABLE . ' ON ('
104		- . static::MAIN_TABLE . '.tipocomprobante = ' . static::NCFTIPO_TABLE . '.tipocomprobante)'
105		- . ' LEFT JOIN ' . static::NCFTIPOPAGO_TABLE . ' ON ('
106		- . static::MAIN_TABLE . '.ncftipopago = ' . static::NCFTIPOPAGO_TABLE . '.codigo)'
107		- . ' LEFT JOIN ' . static::NCFTIPOMOV_TABLE . ' ON ('
108		- . static::MAIN_TABLE . '.ncftipomovimiento = ' . static::NCFTIPOMOV_TABLE . '.codigo)'
109		- . ' LEFT JOIN ' . static::NCFTIPOANUL_TABLE . ' ON ('
110		- . static::MAIN_TABLE . '.ncftipoanulacion = ' . static::NCFTIPOANUL_TABLE . '.codigo)'
111		- . ' LEFT JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
112		- . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado)';
	97	+ . ' LEFT JOIN '.static::LINES_TABLE.' ON ('
	98	+ . static::MAIN_TABLE.'.idfactura = '.static::LINES_TABLE.'.idfactura)'
	99	+ . ' LEFT JOIN '.static::SECONDARY_TABLE.' ON ('
	100	+ . static::MAIN_TABLE.'.idfacturarect = '.static::SECONDARY_TABLE_ALIAS.'.idfactura)'
	101	+ . ' LEFT JOIN '.static::ALMACENES_TABLE.' ON ('
	102	+ . static::MAIN_TABLE.'.codalmacen = '.static::ALMACENES_TABLE.'.codalmacen)'
	103	+ . ' LEFT JOIN '.static::NCFTIPO_TABLE.' ON ('
	104	+ . static::MAIN_TABLE.'.tipocomprobante = '.static::NCFTIPO_TABLE.'.tipocomprobante)'
	105	+ . ' LEFT JOIN '.static::NCFTIPOPAGO_TABLE.' ON ('
	106	+ . static::MAIN_TABLE.'.ncftipopago = '.static::NCFTIPOPAGO_TABLE.'.codigo)'
	107	+ . ' LEFT JOIN '.static::NCFTIPOMOV_TABLE.' ON ('
	108	+ . static::MAIN_TABLE.'.ncftipomovimiento = '.static::NCFTIPOMOV_TABLE.'.codigo)'
	109	+ . ' LEFT JOIN '.static::NCFTIPOANUL_TABLE.' ON ('
	110	+ . static::MAIN_TABLE.'.ncftipoanulacion = '.static::NCFTIPOANUL_TABLE.'.codigo)'
	111	+ . ' LEFT JOIN '.static::ESTADOSDOC_TABLE.' ON ('
	112	+ . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado)';
113	113	}
114	114
115	115	/**

		@@ -69,16 +69,16 @@ discard block
		block discarded – undo
69	69	protected function getGroupFields(): string
70	70	{
71	71	//return parent::getGroupFields(); // TODO: Change the autogenerated stub
72		- return static::MAIN_TABLE.'.idempresa, ' .
73		- static::MAIN_TABLE.'.codalmacen, ' .
74		- static::MAIN_TABLE.'.cifnif, ' .
75		- static::MAIN_TABLE.'.ncftipomovimiento, ' .
76		- static::MAIN_TABLE.'.numproveedor, ' .
77		- static::SECONDARY_TABLE_ALIAS.'.numproveedor, ' .
78		- static::MAIN_TABLE.'.fecha, ' .
79		- static::ESTADOSDOC_TABLE.'.nombre, ' .
80		- static::MAIN_TABLE.'.neto, ' .
81		- static::MAIN_TABLE.'.totaliva' .
	72	+ return static::MAIN_TABLE.'.idempresa, '.
	73	+ static::MAIN_TABLE.'.codalmacen, '.
	74	+ static::MAIN_TABLE.'.cifnif, '.
	75	+ static::MAIN_TABLE.'.ncftipomovimiento, '.
	76	+ static::MAIN_TABLE.'.numproveedor, '.
	77	+ static::SECONDARY_TABLE_ALIAS.'.numproveedor, '.
	78	+ static::MAIN_TABLE.'.fecha, '.
	79	+ static::ESTADOSDOC_TABLE.'.nombre, '.
	80	+ static::MAIN_TABLE.'.neto, '.
	81	+ static::MAIN_TABLE.'.totaliva'.
82	82	' ';
83	83	}
84	84
		@@ -89,14 +89,14 @@ discard block
		block discarded – undo
89	89	protected function getSQLFrom(): string
90	90	{
91	91	return static::MAIN_TABLE
92		- . ' LEFT JOIN '. static::SECONDARY_TABLE . ' ON ('
93		- . static::MAIN_TABLE . '.idfacturarect = ' . static::SECONDARY_TABLE_ALIAS . '.idfactura)'
94		- . ' LEFT JOIN '. static::LINES_TABLE . ' ON ('
95		- . static::MAIN_TABLE . '.idfactura = ' . static::LINES_TABLE . '.idfactura)'
96		- . ' LEFT JOIN '. static::PRODS_TABLE . ' ON ('
97		- . static::LINES_TABLE . '.referencia = ' . static::PRODS_TABLE . '.referencia)'
98		- . ' LEFT JOIN ' . static::ESTADOSDOC_TABLE . ' ON ('
99		- . static::MAIN_TABLE . '.idestado = ' . static::ESTADOSDOC_TABLE . '.idestado)';
	92	+ . ' LEFT JOIN '.static::SECONDARY_TABLE.' ON ('
	93	+ . static::MAIN_TABLE.'.idfacturarect = '.static::SECONDARY_TABLE_ALIAS.'.idfactura)'
	94	+ . ' LEFT JOIN '.static::LINES_TABLE.' ON ('
	95	+ . static::MAIN_TABLE.'.idfactura = '.static::LINES_TABLE.'.idfactura)'
	96	+ . ' LEFT JOIN '.static::PRODS_TABLE.' ON ('
	97	+ . static::LINES_TABLE.'.referencia = '.static::PRODS_TABLE.'.referencia)'
	98	+ . ' LEFT JOIN '.static::ESTADOSDOC_TABLE.' ON ('
	99	+ . static::MAIN_TABLE.'.idestado = '.static::ESTADOSDOC_TABLE.'.idestado)';
100	100	}
101	101
102	102	/**

		@@ -16,13 +16,13 @@
		block discarded – undo
16	16	* along with fsRepublicaDominicana. If not, see <http://www.gnu.org/licenses/>.
17	17	*/
18	18
19		- namespace FacturaScripts\Plugins\fsRepublicaDominicana\Extension\Model;
	19	+ namespace FacturaScripts\Plugins\fsRepublicaDominicana\Extension\Model;
20	20
21		- class Producto
22		- {
	21	+ class Producto
	22	+ {
23	23	/**
24	24	* This field is to determinate if the product is a service or a good
25	25	* @var boolean
26	26	*/
27	27	public $esservicio;
28		- }
	28	+ }

		@@ -47,8 +47,8 @@ discard block
		block discarded – undo
47	47
48	48	public function saveInsert()
49	49	{
50		- return function () {
51		- $ArrayTipoNCFCompras = ['11','12','16','17'];
	50	+ return function() {
	51	+ $ArrayTipoNCFCompras = ['11', '12', '16', '17'];
52	52	$ncfrango = new NCFRango();
53	53	$cliente = new Proveedor();
54	54	$appSettings = new AppSettings;
		@@ -57,7 +57,7 @@ discard block
		block discarded – undo
57	57	$tipocomprobante = $this->tipocomprobante;
58	58	$ncfRangoToUse = $ncfrango->getByTipoComprobante($actualProveedor->idempresa, $tipocomprobante);
59	59
60		- if(in_array($tipocomprobante, $ArrayTipoNCFCompras, true)) {
	60	+ if (in_array($tipocomprobante, $ArrayTipoNCFCompras, true)) {
61	61	$ncf = $ncfRangoToUse->generateNCF();
62	62	$this->numproveedor = $ncf;
63	63	$this->ncffechavencimiento = $ncfRangoToUse->fechavencimiento;

joenilson / fsRepublicaDominicana

Push — master ( daee36...c706da )

Status

Category

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch