Jobtech\LaravelChunky\Concerns\ChunksHelpers

Complexity

Total Complexity

13

Size/Duplication

Total Lines	93
Duplicated Lines	0 %

Importance

Changes	2
Bugs	2	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	deleteChunks()	0	21	4
A	hasProgressBar()	0	7	3
A	deleteAllChunks()	0	20	4
A	chunksFolderExists()	0	8	2

<?php

namespace Jobtech\LaravelChunky\Concerns;

use Illuminate\Support\Str;
use Jobtech\LaravelChunky\Events\ChunkDeleted;
use Symfony\Component\Console\Helper\ProgressBar;
use Symfony\Component\Console\Style\OutputStyle;

trait ChunksHelpers
{
    /**
     * This method checks if the application is running in console and, if output style is not null, it creates a new
     * progress bar instance, otherwise returns null.
     *
     * @param \Symfony\Component\Console\Style\OutputStyle|null $output
     * @param int $count
     *
     * @return \Symfony\Component\Console\Helper\ProgressBar|null
     */
    public function hasProgressBar(?OutputStyle $output, int $count): ?ProgressBar
    {
        if ($output !== null && app()->runningInConsole()) {

The method runningInConsole() does not exist on Illuminate\Container\Container. Are you sure you never get this type here, but always one of the subclasses?

            return $output->createProgressBar($count);
        }

        return null;
    }

    /**
     * Check if the given chunks folder exists.
     *
     * @param string $folder
     *
     * @return bool
     */
    public function chunksFolderExists($folder = ''): bool
    {
        if (! Str::startsWith($folder, $this->getChunksFolder())) {

It seems like getChunksFolder() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $folder = $this->getChunksFolder().$folder;
        }

        return $this->chunksFilesystem()

It seems like chunksFilesystem() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            ->exists($folder);
    }

    /**
     * Delete all chunks folders and their content.
     *
     * @param null $output

Are you sure the doc-type for parameter $output is correct as it would always require null to be passed?

     * @return bool
     */
    public function deleteAllChunks($output = null): bool
    {
        $folders = $this->chunksFilesystem()
            ->directories(
                $this->getChunksFolder()
            );

        $progress_bar = $this->hasProgressBar($output, count($folders));

Are you sure the assignment to $progress_bar is correct as $this->hasProgressBar($output, count($folders)) targeting Jobtech\LaravelChunky\Concerns\ChunksHelpers::hasProgressBar() seems to always return null.

        foreach ($folders as $folder) {
            if (! $this->deleteChunks($folder)) {
                return false;
            }

            if ($progress_bar !== null) {
                $progress_bar->advance();
            }
        }

        return true;
    }

    /**
     * Delete all chunks and, once empty, delete the folder.
     *
     * @param string $folder
     *
     * @return bool
     */
    public function deleteChunks(string $folder): bool
    {
        if (! $this->chunksFolderExists($folder)) {
            return false;
        }

        $files = $this->chunks($folder);

The method chunks() does not exist on Jobtech\LaravelChunky\Concerns\ChunksHelpers. Did you maybe mean chunksFolderExists()?

        foreach ($files as $chunk) {
            $deleted = $this->chunksFilesystem()
                ->delete($chunk->getPath());

            if (! $deleted) {
                return false;
            }

            event(new ChunkDeleted($chunk));
        }

        return $this->chunksFilesystem()
            ->deleteDirectory($folder);
    }
}