jobles /
careerjet-php
| Conditions | 42 |
| Paths | 42 |
| Total Lines | 111 |
| Code Lines | 105 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 28 |
| CRAP Score | 744.7129 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 15 | 8 | public static function fromApi(\stdClass $apiJob, \Jobles\Core\Job\Job $job) |
|
| 16 | { |
||
| 17 | 8 | if (!isset($apiJob->locations)) { |
|
| 18 | 1 | throw new CareerjetException('Invalid API job'); |
|
| 19 | } |
||
| 20 | |||
| 21 | 7 | switch ($apiJob->locations) { |
|
| 22 | 7 | case 'Brasil': |
|
| 23 | 1 | break; |
|
| 24 | 6 | case 'Acre': |
|
| 25 | 1 | $job->setState('AC'); |
|
| 26 | 1 | break; |
|
| 27 | 5 | case 'Alagoas': |
|
| 28 | 1 | $job->setState('AL'); |
|
| 29 | 1 | break; |
|
| 30 | 4 | case 'Amapá': |
|
| 31 | 4 | case 'Amapa': |
|
| 32 | 1 | $job->setState('AP'); |
|
| 33 | 1 | break; |
|
| 34 | 3 | case 'Amazonas': |
|
| 35 | 1 | $job->setState('AM'); |
|
| 36 | 1 | break; |
|
| 37 | 2 | case 'Bahia': |
|
| 38 | 1 | $job->setState('BA'); |
|
| 39 | 1 | break; |
|
| 40 | 1 | case 'Ceará': |
|
| 41 | 1 | case 'Ceara': |
|
| 42 | 1 | $job->setState('CE'); |
|
| 43 | 1 | break; |
|
| 44 | case 'Distrito-Federal': |
||
| 45 | case 'Distrito Federal': |
||
| 46 | $job->setState('DF'); |
||
| 47 | break; |
||
| 48 | case 'Espírito Santo': |
||
| 49 | case 'Espirito Santo': |
||
| 50 | $job->setState('ES'); |
||
| 51 | break; |
||
| 52 | case 'Goiás': |
||
| 53 | case 'Goias': |
||
| 54 | $job->setState('GO'); |
||
| 55 | break; |
||
| 56 | case 'Maranhão': |
||
| 57 | case 'Maranhao': |
||
| 58 | $job->setState('MA'); |
||
| 59 | break; |
||
| 60 | case 'Mato Grosso': |
||
| 61 | $job->setState('MT'); |
||
| 62 | break; |
||
| 63 | case 'Mato Grosso do Sul': |
||
| 64 | $job->setState('MS'); |
||
| 65 | break; |
||
| 66 | case 'Minas Gerais': |
||
| 67 | $job->setState('MG'); |
||
| 68 | break; |
||
| 69 | case 'Pará': |
||
| 70 | case 'Para': |
||
| 71 | $job->setState('PA'); |
||
| 72 | break; |
||
| 73 | case 'Paraíba': |
||
| 74 | case 'Paraiba': |
||
| 75 | $job->setState('PB'); |
||
| 76 | break; |
||
| 77 | case 'Paraná': |
||
| 78 | case 'Parana': |
||
| 79 | $job->setState('PR'); |
||
| 80 | break; |
||
| 81 | case 'Pernambuco': |
||
| 82 | $job->setState('PE'); |
||
| 83 | break; |
||
| 84 | case 'Piauí': |
||
| 85 | case 'Piaui': |
||
| 86 | $job->setState('PI'); |
||
| 87 | break; |
||
| 88 | case 'Rio de Janeiro': |
||
| 89 | $job->setState('RJ'); |
||
| 90 | break; |
||
| 91 | case 'Rio Grande do Norte': |
||
| 92 | $job->setState('RN'); |
||
| 93 | break; |
||
| 94 | case 'Rio Grande do Sul': |
||
| 95 | $job->setState('RS'); |
||
| 96 | break; |
||
| 97 | case 'Rondônia': |
||
| 98 | case 'Rondonia': |
||
| 99 | $job->setState('RO'); |
||
| 100 | break; |
||
| 101 | case 'Roraima': |
||
| 102 | $job->setState('RR'); |
||
| 103 | break; |
||
| 104 | case 'Santa Catarina': |
||
| 105 | $job->setState('SC'); |
||
| 106 | break; |
||
| 107 | case 'São Paulo': |
||
| 108 | case 'Sao Paulo': |
||
| 109 | $job->setState('SP'); |
||
| 110 | break; |
||
| 111 | case 'Sergipe': |
||
| 112 | $job->setState('SE'); |
||
| 113 | break; |
||
| 114 | case 'Tocantins': |
||
| 115 | $job->setState('TO'); |
||
| 116 | break; |
||
| 117 | default: |
||
| 118 | list($city, $state) = explode(' - ', $apiJob->locations); |
||
| 119 | $job->setState($state); |
||
| 120 | $job->setCity($city); |
||
| 121 | break; |
||
| 122 | 7 | } |
|
| 123 | |||
| 124 | 7 | return $job; |
|
| 125 | } |
||
| 126 | } |
||
| 127 |
