NotificationsController::single() - Code Metrics - Inspection of "Notification page" - jobapis/jobs-to-mail - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#36)

by Karl

created 2017-04-16 00:04 UTC

NotificationsController::single() A

↳ Parent: NotificationsController

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	2

<?php namespace JobApis\JobsToMail\Http\Controllers;

use Illuminate\Foundation\Bus\DispatchesJobs;
use Illuminate\Http\Request;
use Illuminate\Routing\Controller as BaseController;
use Illuminate\Foundation\Validation\ValidatesRequests;
use JobApis\JobsToMail\Jobs\Notifications\GenerateCsv;
use JobApis\JobsToMail\Jobs\Notifications\GetNotificationById;

class NotificationsController extends BaseController
{
    use DispatchesJobs, ValidatesRequests;

    /**
     * Show the notification
     */
    public function single(Request $request, $id)
    {
        $notification = $this->dispatchNow(new GetNotificationById($id));

        if ($notification) {
            return view('notifications.single', ['notification' => $notification]);
        }

        $request->session()->flash('alert-danger', 'This job alert has expired.');

        return redirect('/');
    }

    /**
     * Download jobs from a collection by ID
     */
    public function download(Request $request, $id)

    {
        $path = $this->dispatchNow(new GenerateCsv($id));

        return response()->download($path, null, ['Content-Type: text/csv']);
    }
}


1			<?php namespace JobApis\JobsToMail\Http\Controllers;
2
3			use Illuminate\Foundation\Bus\DispatchesJobs;
4			use Illuminate\Http\Request;
5			use Illuminate\Routing\Controller as BaseController;
6			use Illuminate\Foundation\Validation\ValidatesRequests;
7			use JobApis\JobsToMail\Jobs\Notifications\GenerateCsv;
8			use JobApis\JobsToMail\Jobs\Notifications\GetNotificationById;
9
10			class NotificationsController extends BaseController
11			{
12			use DispatchesJobs, ValidatesRequests;
13
14			/**
15			* Show the notification
16			*/
17			public function single(Request $request, $id)
18			{
19			$notification = $this->dispatchNow(new GetNotificationById($id));
20
21			if ($notification) {
22			return view('notifications.single', ['notification' => $notification]);
23			}
24
25			$request->session()->flash('alert-danger', 'This job alert has expired.');
26
27			return redirect('/');
28			}
29
30			/**
31			* Download jobs from a collection by ID
32			*/
33			public function download(Request $request, $id)
			0 ignored issues – show Unused Code introduced 2016-11-06 23:02 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
34			{
35			$path = $this->dispatchNow(new GenerateCsv($id));
36
37			return response()->download($path, null, ['Content-Type: text/csv']);
38			}
39			}
40

jobapis / jobs-to-mail

Pull Request — master (#36)

NotificationsController::single() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like