PremiumUserSignup::toMail() - Code Metrics - Inspection of "Premium interest page" - jobapis/jobs-to-mail - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#27)

by Karl

created 2016-12-01 21:53 UTC

PremiumUserSignup::toMail() A

↳ Parent: PremiumUserSignup

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
ccs	0
cts	0
cp	0
cc	2
eloc	7
nc	2
nop	1
crap	6

<?php namespace JobApis\JobsToMail\Notifications;

use Illuminate\Notifications\Notification;
use Illuminate\Notifications\Messages\MailMessage;
use JobApis\JobsToMail\Models\Token;

class PremiumUserSignup extends Notification
{
    /**
     * @var array
     */
    protected $data;

    /**
     * Create a new notification instance.
     *
     * @param Token $token
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return void

     */
    public function __construct($data)
    {
        $this->data = $data;
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function via($notifiable)

    {
        return ['mail'];
    }

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)

    {
        $message = (new MailMessage())
            ->subject('New Premium User Signup')
            ->line('A new user is interested in JobsToMail premium: ');

        foreach ($this->data as $key => $value) {
            $message->line($key . ': ' . $value);
        }

        return $message;
    }
}


1		<?php namespace JobApis\JobsToMail\Notifications;
2
3		use Illuminate\Notifications\Notification;
4		use Illuminate\Notifications\Messages\MailMessage;
5		use JobApis\JobsToMail\Models\Token;
6
7		class PremiumUserSignup extends Notification
8		{
9		/**
10		* @var array
11		*/
12		protected $data;
13
14		/**
15		* Create a new notification instance.
16		*
17		* @param Token $token
		0 ignored issues – show Bug introduced 2016-12-01 21:58 UTC by Report Bug Copy Issue Report There is no parameter named `$token`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
18		*
19		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2016-12-01 21:58 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
20		*/
21	1	public function __construct($data)
22		{
23	1	$this->data = $data;
24	1	}
25
26		/**
27		* Get the notification's delivery channels.
28		*
29		* @param mixed $notifiable
30		* @return array
31		*/
32		public function via($notifiable)
		0 ignored issues – show Unused Code introduced 2016-12-01 21:58 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
33		{
34		return ['mail'];
35		}
36
37		/**
38		* Get the mail representation of the notification.
39		*
40		* @param mixed $notifiable
41		* @return \Illuminate\Notifications\Messages\MailMessage
42		*/
43		public function toMail($notifiable)
		0 ignored issues – show Unused Code introduced 2016-12-01 21:58 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
44		{
45		$message = (new MailMessage())
46		->subject('New Premium User Signup')
47		->line('A new user is interested in JobsToMail premium: ');
48
49		foreach ($this->data as $key => $value) {
50		$message->line($key . ': ' . $value);
51		}
52
53		return $message;
54		}
55		}
56

jobapis / jobs-to-mail

Pull Request — master (#27)

PremiumUserSignup::toMail() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like