MonsterProvider::createJobObject() - Code Metrics - jobapis/jobs-monster - Measure and Improve Code Quality continuously with Scrutinizer

MonsterProvider::createJobObject() A
last analyzed 2017-01-06 20:41 UTC

↳ Parent: MonsterProvider

Complexity

Conditions	3
Paths	2

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	18
ccs	12
cts	12
cp	1
rs	9.4285
cc	3
eloc	10
nc	2
nop	1
crap	3

<?php namespace JobApis\Jobs\Client\Providers;

use JobApis\Jobs\Client\Job;

class MonsterProvider extends AbstractProvider
{
    /**
     * Returns the standardized job object
     *
     * @param array $payload
     *
     * @return \JobApis\Jobs\Client\Job
     */
    public function createJobObject($payload)
    {
        $job = new Job([
            'title' => $payload['title'],
            'name' => $payload['title'],
            'description' => $payload['description'],
            'url' => $payload['link'],
        ]);

        $job->setDatePostedAsString($payload['pubDate']);

        // Set a location if it was set in the query
        if ($this->query && $this->query->get('where')) {
            $job->setLocation($this->query->get('where'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $job;
    }

    /**
     * Job response object default keys that should be set
     *
     * @return  array
     */
    public function getDefaultResponseFields()
    {
        return [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'title',
            'link',
            'description',
            'pubDate',
        ];
    }

    /**
     * Get format
     *
     * @return  string Currently only 'json' and 'xml' supported
     */
    public function getFormat()
    {
        return 'xml';
    }

    /**
     * Get listings path
     *
     * @return  string
     */
    public function getListingsPath()
    {
        return 'channel.item';
    }
}


1		<?php namespace JobApis\Jobs\Client\Providers;
2
3		use JobApis\Jobs\Client\Job;
4
5		class MonsterProvider extends AbstractProvider
6		{
7		/**
8		* Returns the standardized job object
9		*
10		* @param array $payload
11		*
12		* @return \JobApis\Jobs\Client\Job
13		*/
14	6	public function createJobObject($payload)
15		{
16	6	$job = new Job([
17	6	'title' => $payload['title'],
18	6	'name' => $payload['title'],
19	6	'description' => $payload['description'],
20	6	'url' => $payload['link'],
21	6	]);
22
23	6	$job->setDatePostedAsString($payload['pubDate']);
24
25		// Set a location if it was set in the query
26	6	if ($this->query && $this->query->get('where')) {
27	4	$job->setLocation($this->query->get('where'));
		0 ignored issues – show Documentation introduced 2017-01-06 20:41 UTC by Report Bug Copy Issue Report `$this->query->get('where')` is of type `object<JobApis\Jobs\Client\Queries\AbstractQuery>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28	4	}
29
30	6	return $job;
31		}
32
33		/**
34		* Job response object default keys that should be set
35		*
36		* @return array
37		*/
38	4	public function getDefaultResponseFields()
39		{
40		return [
		0 ignored issues – show Bug Best Practice introduced 2017-01-06 20:40 UTC by Report Bug Copy Issue Report The return type of `return array('title', 'l...scription', 'pubDate');` (`string[]`) is incompatible with the return type declared by the abstract method `JobApis\Jobs\Client\Prov...etDefaultResponseFields` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
41	4	'title',
42	4	'link',
43	4	'description',
44	4	'pubDate',
45	4	];
46		}
47
48		/**
49		* Get format
50		*
51		* @return string Currently only 'json' and 'xml' supported
52		*/
53	4	public function getFormat()
54		{
55	4	return 'xml';
56		}
57
58		/**
59		* Get listings path
60		*
61		* @return string
62		*/
63	4	public function getListingsPath()
64		{
65	4	return 'channel.item';
66		}
67		}
68

jobapis / jobs-monster

MonsterProvider::createJobObject() A last analyzed 2017-01-06 20:41 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

MonsterProvider::createJobObject() A
last analyzed 2017-01-06 20:41 UTC