JoaoRobertoPB\PhpGitHookSniffer\Pipelines\LintStage

Complexity

Total Complexity

4

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	27	4

<?php

namespace JoaoRobertoPB\PhpGitHookSniffer\Pipelines;

use JoaoRobertoPB\PhpGitHookSniffer\Contracts\PipelineInterface;

class LintStage implements PipelineInterface
{
    /**
     * Process the payload.
     *
     * @param mixed $payload
     */
    public function __invoke($payload)
    {
        echo "[  ] ----- Check Syntax Error -----\n";

        foreach ($payload as $file) {
            $fileName = trim($file);
            $ext = pathinfo($fileName, PATHINFO_EXTENSION);

            $return = 0;

            if ('php' != $ext) {
                continue;
            }

            $lintOutput = [];
            exec('php -l '.escapeshellarg($fileName), $lintOutput, $return);
        }

        if ($return != 0) {

The variable $return seems to be defined by a foreach iteration on line 18. Are you sure the iterator is never empty, otherwise this variable is not defined?

            echo implode("\n", $lintOutput), "\n";

The variable $lintOutput does not seem to be defined for all execution paths leading up to this point.

            echo "[FAIL] ----- Check Syntax Error -----\n";
            exit(1);

Using exit here is not recommended.

        }

        echo "[OK] ----- Check Syntax Error -----\n";

        return $payload;
    }
}