joaogl /
support
| Conditions | 11 |
| Paths | 1 |
| Total Lines | 36 |
| Code Lines | 18 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 4 | ||
| Bugs | 1 | Features | 2 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php namespace jlourenco\support\Traits; |
||
| 12 | public static function bootCreation() |
||
| 13 | {
|
||
| 14 | |||
| 15 | // create a event to happen on deleting |
||
| 16 | static::deleting(function($table) {
|
||
| 17 | if (class_exists('Cartalyst\Sentinel\Laravel\Facades\Sentinel'))
|
||
| 18 | $table->deleted_by = Sentinel::getUser()->id; |
||
| 19 | else |
||
| 20 | $table->deleted_by = Auth::user()->id; |
||
| 21 | |||
| 22 | $table->update(['deleted_by' => $table->deleted_by]); |
||
| 23 | }); |
||
| 24 | |||
| 25 | // create a event to happen on saving |
||
| 26 | static::saving(function($table) {
|
||
| 27 | |||
| 28 | if (class_exists('Cartalyst\Sentinel\Laravel\Facades\Sentinel'))
|
||
| 29 | {
|
||
| 30 | if (Sentinel::check()) |
||
| 31 | $table->modified_by = Sentinel::getUser()->id; |
||
| 32 | |||
| 33 | if (Sentinel::check() && ($table->created_by == null || !($table->created_by > 0))) |
||
| 34 | $table->created_by = Sentinel::getUser()->id; |
||
| 35 | } |
||
| 36 | else |
||
| 37 | {
|
||
| 38 | if (!Auth::guest()) |
||
| 39 | $table->modified_by = Auth::user()->id; |
||
| 40 | |||
| 41 | if (!Auth::guest() && ($table->created_by == null || !($table->created_by > 0))) |
||
| 42 | $table->created_by = Auth::user()->id; |
||
| 43 | } |
||
| 44 | |||
| 45 | }); |
||
| 46 | |||
| 47 | } |
||
| 48 | |||
| 54 | } |
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: