for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php namespace jlourenco\support\Traits;
use Cartalyst\Sentinel\Laravel\Facades\Sentinel;
trait Creation {
/**
* Boot the creation trait for a model.
*
* @return void
*/
public static function bootCreation()
{
// create a event to happen on deleting
static::deleting(function($table) {
if (class_exists('Cartalyst\Sentinel\Laravel\Facades\Sentinel'))
$table->deleted_by = Sentinel::getUser()->id;
else
$table->deleted_by = Auth::user()->id;
});
// create a event to happen on saving
static::saving(function($table) {
$table->modified_by = Sentinel::getUser()->id;
if ($user = Sentinel::check() && ($table->created_by == null || !($table->created_by > 0)))
$user
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
$user = (\Cartalyst\Sent...able->created_by > 0)))
($user = \Cartalyst\Sent...$table->created_by > 0)
$table->created_by = Sentinel::getUser()->id;
}
$table->modified_by = Auth::user()->id;
if (!Auth::guest() && ($table->created_by == null || !($table->created_by > 0)))
$table->created_by = Auth::user()->id;
joaogl /
support
Loading history...
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.