Settings - Code Metrics - Inspection of "Fixed mistake of composer.json" - joaogl/base - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 15a5bf...eb9630 )

by Joao

created 2016-04-16 08:50 UTC

Settings A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	3
Bugs	0	Features	2

Metric	Value
wmc	3
c	3
b	0
f	2
lcom	0
cbo	2
dl	0
loc	39
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	options()	0	17	3

<?php namespace jlourenco\base\Models;

use Illuminate\Database\Eloquent\Model;
use jlourenco\support\Traits\Creation;

class Settings extends Model
{

    /**
     * To allow user actions identity (Created_by, Updated_by, Deleted_by)
     */
    use Creation;

    /**
     * {@inheritDoc}
     */
    protected $table = 'Settings';

    /**
     * {@inheritDoc}
     */
    protected $fillable = [
        'value'
    ];

    public function options()
    {
        $str = explode("* ", $this->description);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $choices = array();

        foreach($str as $st)
        {
            preg_match('/(?P<digit>\d+) - (?P<name>\w+)/', $st, $matches);
            if (sizeof($matches) > 0) {
                $st = str_replace("*/","",$st);
                $st = str_replace("/*","",$st);
                $choices[$matches[1]] = explode($matches[1] . ' - ', $st)[1];
            }
        }

        return $choices;
    }

}


1			<?php namespace jlourenco\base\Models;
2
3			use Illuminate\Database\Eloquent\Model;
4			use jlourenco\support\Traits\Creation;
5
6			class Settings extends Model
7			{
8
9			/**
10			* To allow user actions identity (Created_by, Updated_by, Deleted_by)
11			*/
12			use Creation;
13
14			/**
15			* {@inheritDoc}
16			*/
17			protected $table = 'Settings';
18
19			/**
20			* {@inheritDoc}
21			*/
22			protected $fillable = [
23			'value'
24			];
25
26			public function options()
27			{
28			$str = explode("* ", $this->description);
			0 ignored issues – show Documentation introduced 2016-04-16 08:58 UTC by Report Bug Copy Issue Report The property `description` does not exist on `object<jlourenco\base\Models\Settings>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
29			$choices = array();
30
31			foreach($str as $st)
32			{
33			preg_match('/(?P<digit>\d+) - (?P<name>\w+)/', $st, $matches);
34			if (sizeof($matches) > 0) {
35			$st = str_replace("*/","",$st);
36			$st = str_replace("/*","",$st);
37			$choices[$matches[1]] = explode($matches[1] . ' - ', $st)[1];
38			}
39			}
40
41			return $choices;
42			}
43
44			}
45

joaogl / base

Push — master ( 15a5bf...eb9630 )

Settings A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like