jmgq / php-a-star

src/Node/Collection/NodeHashTable.php

<?php

namespace JMGQ\AStar\Node\Collection;

use JMGQ\AStar\Node\Node;

/**
 * @template TState
 * @implements \IteratorAggregate<mixed, Node<TState>>
 * @implements NodeCollectionInterface<TState>
 * @internal
 */
class NodeHashTable implements \IteratorAggregate, NodeCollectionInterface
{
    /** @var Node<TState>[] */
    private array $nodes = [];

    /**
     * {@inheritdoc}
     * @return \ArrayIterator<array-key, Node<TState>>
     */
    public function getIterator(): \Traversable
    {
        return new \ArrayIterator($this->nodes);
    }

    /**
     * {@inheritdoc}
     */
    public function extractBest(): ?Node
    {
        $bestNode = null;

        foreach ($this->nodes as $node) {
            if ($bestNode === null || $node->getF() < $bestNode->getF()) {

The method getF() does not exist on null.

                $bestNode = $node;
            }
        }

        if ($bestNode !== null) {
            $this->remove($bestNode);
        }

        return $bestNode;
    }

    public function get(string $nodeId): ?Node
    {
        return $this->nodes[$nodeId] ?? null;
    }

    public function add(Node $node): void
    {
        $this->nodes[$node->getId()] = $node;
    }

    public function remove(Node $node): void
    {
        unset($this->nodes[$node->getId()]);
    }

    public function isEmpty(): bool
    {
        return empty($this->nodes);
    }

    public function contains(Node $node): bool
    {
        return isset($this->nodes[$node->getId()]);
    }

    /**
     * {@inheritdoc}
     */
    public function clear(): void
    {
        $this->nodes = [];

It seems like array() of type array is incompatible with the declared type JMGQ\AStar\Node\Node of property $nodes.

    }
}