JMGQ\AStar\Benchmark\TerrainGenerator::generate()

Complexity

Conditions	3
Paths	3

Size

Total Lines

18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function generate($rows, $columns, $seed = null)

Expected 2 blank lines before function; 0 found

Type hint "int" missing for $rows

Type hint "int" missing for $columns

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of null please use NULL.

    {

Opening brace should be on the same line as the declaration

        $this->validatePositiveInteger($rows);
        $this->validatePositiveInteger($columns);
        $this->validateOptionalInteger($seed);

        mt_srand($seed);

        $terrainCost = array();

Short array syntax must be used to define arrays

        foreach (range(0, $rows - 1) as $row) {

Arithmetic operation must be bracketed

            foreach (range(0, $columns - 1) as $column) {

Arithmetic operation must be bracketed

                $terrainCost[$row][$column] = mt_rand(1, 10);
            }
        }

        return new TerrainCost($terrainCost);
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end generate()