JMGQ\AStar\Benchmark\InputValidator::validate()

Complexity

Conditions	5
Paths	12

Size

Total Lines

27

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function validate(InputInterface $input)

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        $hasValidInput = true;

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

        $sizes = $input->getOption(BenchmarkCommand::SIZE_OPTION);

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

        $iterations = $input->getOption(BenchmarkCommand::ITERATIONS_OPTION);
        $seed = $input->getOption(BenchmarkCommand::SEED_OPTION);

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

        foreach ($sizes as $size) {

The expression $sizes of type string|array<integer,string>|boolean|null is not guaranteed to be traversable. How about adding an additional type check?

            if (!$this->isPositiveInteger($size)) {

There must be a single space after a NOT operator; 0 found

                $this->output->error('The size must be an integer greater than 0');
                $hasValidInput = false;

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of false please use FALSE.

            }
        }

        if (!$this->isPositiveInteger($iterations)) {

There must be a single space after a NOT operator; 0 found

            $this->output->error('The number of iterations must be an integer greater than 0');
            $hasValidInput = false;

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of false please use FALSE.

        }

        if (!$this->isOptionalInteger($seed)) {

There must be a single space after a NOT operator; 0 found

            $this->output->error('The seed must be an integer');
            $hasValidInput = false;

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of false please use FALSE.

        }

        return $hasValidInput;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end validate()