JMGQ\AStar\Benchmark\BenchmarkRunner::run()

Complexity

Conditions	3
Paths	3

Size

Total Lines

35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function run(array $sizes, $iterations, $seed)

Type hint "int" missing for $iterations

    {

Opening brace should be on the same line as the declaration

        $results = array();

Short array syntax must be used to define arrays

        $steps = count($sizes) * $iterations;

Arithmetic operation must be bracketed

        $this->progressBar->start($steps);

        foreach ($sizes as $size) {
            for ($i = 0; $i < $iterations; $i++) {
                $terrain = $this->terrainGenerator->generate($size, $size, $seed);
                $aStar = new MyAStar($terrain);

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

                $start = new MyNode(0, 0);
                $goal = new MyNode($size - 1, $size - 1);

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

Arithmetic operation must be bracketed

                $this->stopwatch->start('benchmark');

                $solution = $aStar->run($start, $goal);

                $event = $this->stopwatch->stop('benchmark');

                $solutionFound = !empty($solution);

The value of a boolean operation must not be assigned to a variable

There must be a single space after a NOT operator; 0 found

                $results[] = new Result($size, $event->getDuration(), $solutionFound);

                $this->stopwatch->reset();

                $this->progressBar->advance();
            }

End comment for long condition not found; expected "//end for"

        }

End comment for long condition not found; expected "//end foreach"

        $this->progressBar->finish();

        return $results;
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

Expected //end run()

}

Expected //end class

As per coding style, files should not end with a newline character.