JMGQ\AStar\Benchmark\Result\Result

Complexity

Total Complexity

9

Size/Duplication

Total Lines	60
Duplicated Lines	33.33 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getSize()	0	4	1
A	getDuration()	0	4	1
A	hasSolution()	0	4	1
A	filterSize()	10	10	2
A	filterDuration()	10	10	2
A	filterHasSolution()	0	4	1

<?php

This file is missing a doc comment.

The PHP open tag does not have a corresponding PHP close tag

Filename "Result.php" doesn't match the expected filename "result.php"

Missing file doc comment

namespace JMGQ\AStar\Benchmark\Result;

class Result

Missing class doc comment

{

Opening brace should be on the same line as the declaration for class Result

    private $size;

Private member variable "size" must contain a leading underscore

Expected 1 blank line before member var; 0 found

Missing member variable doc comment

Private member variable "size" must be prefixed with an underscore

    private $duration;

Private member variable "duration" must contain a leading underscore

Expected 1 blank line before member var; 0 found

Missing member variable doc comment

Private member variable "duration" must be prefixed with an underscore

    private $hasSolution;

Private member variable "hasSolution" must contain a leading underscore

Expected 1 blank line before member var; 0 found

Missing member variable doc comment

Private member variable "hasSolution" must be prefixed with an underscore

    /**

Missing short description in doc comment

     * @param int $size

Missing parameter comment

Expected 2 spaces after parameter type; 1 found

Expected "integer" but found "int" for parameter type

     * @param int $duration

Missing parameter comment

Expected 2 spaces after parameter type; 1 found

Expected "integer" but found "int" for parameter type

     * @param bool $hasSolution

Missing parameter comment

Expected "boolean" but found "bool" for parameter type

     */
    public function __construct($size, $duration, $hasSolution)

Expected 2 blank lines before function; 1 found

Type hint "int" missing for $size

Type hint "int" missing for $duration

Type hint "bool" missing for $hasSolution

    {

Opening brace should be on the same line as the declaration

        $this->size = $this->filterSize($size);

Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space

        $this->duration = $this->filterDuration($duration);

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $this->hasSolution = $this->filterHasSolution($hasSolution);
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end __construct()

    public function getSize()

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        return $this->size;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end getSize()

    public function getDuration()

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        return $this->duration;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end getDuration()

    public function hasSolution()

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        return $this->hasSolution;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end hasSolution()

    private function filterSize($size)

Private method name "Result::filterSize" must be prefixed with an underscore

Missing function doc comment

This method seems to be duplicated in your project.

    {

Opening brace should be on the same line as the declaration

        $naturalNumber = filter_var($size, FILTER_VALIDATE_INT, array('options' => array('min_range' => 1)));

Short array syntax must be used to define arrays

        if ($naturalNumber === false) {

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of false please use FALSE.

            throw new \InvalidArgumentException('Invalid size: ' . print_r($size, true));

Concat operator must not be surrounded by spaces

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

        }

        return $naturalNumber;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end filterSize()

    private function filterDuration($duration)

Private method name "Result::filterDuration" must be prefixed with an underscore

Missing function doc comment

This method seems to be duplicated in your project.

    {

Opening brace should be on the same line as the declaration

        $nonNegativeInteger = filter_var($duration, FILTER_VALIDATE_INT, array('options' => array('min_range' => 0)));

Short array syntax must be used to define arrays

        if ($nonNegativeInteger === false) {

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of false please use FALSE.

            throw new \InvalidArgumentException('Invalid duration: ' . print_r($duration, true));

Concat operator must not be surrounded by spaces

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

        }

        return $nonNegativeInteger;
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end filterDuration()

    private function filterHasSolution($hasSolution)

Private method name "Result::filterHasSolution" must be prefixed with an underscore

Missing function doc comment

    {

Opening brace should be on the same line as the declaration

        return filter_var($hasSolution, FILTER_VALIDATE_BOOLEAN);
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

Expected //end filterHasSolution()

}

Expected //end class

As per coding style, files should not end with a newline character.