NodeHashTable::extractBest() - Code Metrics - Inspection of "Tweak the public API" - jmgq/php-a-star - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — new-implementation ( 0cc7b9 )

by Jose

created 2021-02-07 23:17 UTC

NodeHashTable::extractBest() A

↳ Parent: NodeHashTable

Complexity

Conditions	5
Paths	6

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	7
c	1
b	0
f	0
dl	0
loc	15
ccs	8
cts	8
cp	1
rs	9.6111
cc	5
nc	6
nop	0
crap	5

<?php

namespace JMGQ\AStar;

class NodeHashTable implements \IteratorAggregate, NodeCollectionInterface
{
    /** @var Node[] */
    private array $nodes = [];

    /**
     * {@inheritdoc}
     */
    public function getIterator(): iterable
    {
        return new \ArrayIterator($this->nodes);
    }

    /**
     * {@inheritdoc}
     */
    public function extractBest(): ?Node
    {
        $bestNode = null;

        foreach ($this->nodes as $node) {
            if ($bestNode === null || $node->getF() < $bestNode->getF()) {
            if ($bestNode === null || $node->getF() < $bestNode->/** @scrutinizer ignore-call */ getF()) {
                $bestNode = $node;
            }
        }

        if ($bestNode !== null) {
            $this->remove($bestNode);
        }

        return $bestNode;
    }

    public function get(string $nodeId): ?Node
    {
        return $this->nodes[$nodeId] ?? null;
    }

    public function add(Node $node): void
    {
        $this->nodes[$node->getId()] = $node;
    }

    public function remove(Node $node): void
    {
        unset($this->nodes[$node->getId()]);
    }

    public function isEmpty(): bool
    {
        return empty($this->nodes);
    }

    public function contains(Node $node): bool
    {
        return isset($this->nodes[$node->getId()]);
    }

    /**
     * {@inheritdoc}
     */
    public function clear(): void
    {
        $this->nodes = [];
    }
}


jmgq / php-a-star

Push — new-implementation ( 0cc7b9 )

NodeHashTable::extractBest() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like