InputValidator::validate() - Code Metrics - Inspection of "Benchmark functionality" - jmgq/php-a-star - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#14)

by Jose

created 2021-02-03 21:20 UTC

InputValidator::validate() A

↳ Parent: InputValidator

Complexity

Conditions	5
Paths	12

Size

Total Lines	26
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	15
c	1
b	0
f	0
dl	0
loc	26
ccs	16
cts	16
cp	1
rs	9.4555
cc	5
nc	12
nop	1
crap	5

<?php

namespace JMGQ\AStar\Benchmark;

use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Style\StyleInterface;

class InputValidator
{
    private $output;

    public function __construct(StyleInterface $output)
    {
        $this->output = $output;
    }

    public function validate(InputInterface $input)
    {
        $hasValidInput = true;

        $sizes = $input->getOption(BenchmarkCommand::SIZE_OPTION);
        $iterations = $input->getOption(BenchmarkCommand::ITERATIONS_OPTION);
        $seed = $input->getOption(BenchmarkCommand::SEED_OPTION);

        foreach ($sizes as $size) {
            if (!$this->isPositiveInteger($size)) {
                $this->output->error('The size must be an integer greater than 0');
                $hasValidInput = false;
            }
        }

        if (!$this->isPositiveInteger($iterations)) {
            $this->output->error('The number of iterations must be an integer greater than 0');
            $hasValidInput = false;
        }

        if (!$this->isOptionalInteger($seed)) {
            $this->output->error('The seed must be an integer');
            $hasValidInput = false;
        }

        return $hasValidInput;
    }

    private function isPositiveInteger($value)
    {
        $positiveInteger = filter_var($value, FILTER_VALIDATE_INT, array('options' => array('min_range' => 1)));

        return $positiveInteger !== false;
    }

    private function isOptionalInteger($value)
    {
        $integer = filter_var($value, FILTER_VALIDATE_INT);

        return $integer !== false || $value === null;
    }
}


1		<?php
2
3		namespace JMGQ\AStar\Benchmark;
4
5		use Symfony\Component\Console\Input\InputInterface;
6		use Symfony\Component\Console\Style\StyleInterface;
7
8		class InputValidator
9		{
10		private $output;
11
12	24	public function __construct(StyleInterface $output)
13		{
14	24	$this->output = $output;
15	24	}
16
17	24	public function validate(InputInterface $input)
18		{
19	24	$hasValidInput = true;
20
21	24	$sizes = $input->getOption(BenchmarkCommand::SIZE_OPTION);
22	24	$iterations = $input->getOption(BenchmarkCommand::ITERATIONS_OPTION);
23	24	$seed = $input->getOption(BenchmarkCommand::SEED_OPTION);
24
25	24	foreach ($sizes as $size) {
26	24	if (!$this->isPositiveInteger($size)) {
27	7	$this->output->error('The size must be an integer greater than 0');
28	7	$hasValidInput = false;
29		}
30		}
31
32	24	if (!$this->isPositiveInteger($iterations)) {
33	8	$this->output->error('The number of iterations must be an integer greater than 0');
34	8	$hasValidInput = false;
35		}
36
37	24	if (!$this->isOptionalInteger($seed)) {
38	8	$this->output->error('The seed must be an integer');
39	8	$hasValidInput = false;
40		}
41
42	24	return $hasValidInput;
43		}
44
45	24	private function isPositiveInteger($value)
46		{
47	24	$positiveInteger = filter_var($value, FILTER_VALIDATE_INT, array('options' => array('min_range' => 1)));
48
49	24	return $positiveInteger !== false;
50		}
51
52	24	private function isOptionalInteger($value)
53		{
54	24	$integer = filter_var($value, FILTER_VALIDATE_INT);
55
56	24	return $integer !== false \|\| $value === null;
57		}
58		}
59

jmgq / php-a-star

Pull Request — master (#14)

InputValidator::validate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like