Issues in ExecDriver.php (master) - Issues in master - jkuchar/BigFileTools - Measure and Improve Code Quality continuously with Scrutinizer

Issues (25)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Driver/ExecDriver.php (11 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace BigFileTools\Driver;
use Brick\Math\BigInteger;
use Brick\Math\Exception\ArithmeticException;

class ExecDriver implements ISizeDriver
{
	private $os;
	const OS_WINDOWS = "Windows";
	const OS_LINUX = "Linux";
	const OS_MAC = "Mac";

	public function __construct()
	{
		if (!function_exists("exec")) {
			throw new PrerequisiteException("Exec function is disabled");
		}

		if(strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') {
			$this->os = self::OS_WINDOWS;
		} elseif (strtoupper(PHP_OS) == "DARWIN") {
			$this->os = self::OS_MAC;
		} else {
			$this->os = self::OS_LINUX;
		}
	}

	/**
	 * Returns file size by using system shell/cmd commands
	 * @inheritdoc
	 * @link http://stackoverflow.com/questions/5501451/php-x86-how-to-get-filesize-of-2gb-file-without-external-program/5502328#5502328
	 * @return BigInteger
	 */
	public function getFileSize($path)
	{
		switch($this->os) {
			case self::OS_WINDOWS: return $this->getFileSizeWindows($path); break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case self::OS_LINUX:   return $this->getFileSizeLinux($path); break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			case self::OS_MAC:     return $this->getFileSizeMac($path); break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
			default: throw new Exception("OS not detected");
switch ($expr) {
    default:
        doSomething(); //right
        break;
}


switch ($expr) {
    default:

        doSomething(); //wrong
        break;
}
		}
	}

	/**
	 * Convert string into integer
	 * Must be precise number, otherwise you will see and exception.
	 *
	 * @param $valueAsString
	 * @return BigInteger
	 * @throws Exception
	 */
	private function convertToInteger($valueAsString) {
		if(!is_string($valueAsString)) {
			throw new Exception("Cannot convert to integer. Expected string, but got " . gettype($valueAsString). ".");
		}
		$trimmedInput = trim($valueAsString);

		try {
			return BigInteger::of($trimmedInput);

		} catch (ArithmeticException $e) {
			throw new Exception("Returned value cannot be converted to an integer.",0, $e);
		}

	}

	private function getFileSizeWindows($path)
	{
		$escapedPath = escapeshellarg($path);
		return $this->convertToInteger(
			exec("for %F in ($escapedPath) do @echo %~zF")
		);
	}

	private function getFileSizeLinux($path)
	{
		$escapedPath = escapeshellarg($path);
		return $this->convertToInteger(
			exec("stat -Lc%s $escapedPath")
		);
	}

	private function getFileSizeMac($path)
	{
		$escapedPath = escapeshellarg($path);
		return $this->convertToInteger(
			exec("stat -f%z $escapedPath")
		);
	}
}

1			<?php
2
3			namespace BigFileTools\Driver;
4			use Brick\Math\BigInteger;
5			use Brick\Math\Exception\ArithmeticException;
6
7			class ExecDriver implements ISizeDriver
8			{
9			private $os;
10			const OS_WINDOWS = "Windows";
11			const OS_LINUX = "Linux";
12			const OS_MAC = "Mac";
13
14			public function __construct()
15			{
16			if (!function_exists("exec")) {
17			throw new PrerequisiteException("Exec function is disabled");
18			}
19
20			if(strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') {
21			$this->os = self::OS_WINDOWS;
22			} elseif (strtoupper(PHP_OS) == "DARWIN") {
23			$this->os = self::OS_MAC;
24			} else {
25			$this->os = self::OS_LINUX;
26			}
27			}
28
29			/**
30			* Returns file size by using system shell/cmd commands
31			* @inheritdoc
32			* @link http://stackoverflow.com/questions/5501451/php-x86-how-to-get-filesize-of-2gb-file-without-external-program/5502328#5502328
33			* @return BigInteger
34			*/
35			public function getFileSize($path)
36			{
37			switch($this->os) {
38			case self::OS_WINDOWS: return $this->getFileSizeWindows($path); break;
			0 ignored issues – show Unused Code introduced 2016-02-05 18:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history... Coding Style introduced 2016-03-16 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-03-16 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
39			case self::OS_LINUX: return $this->getFileSizeLinux($path); break;
			0 ignored issues – show Unused Code introduced 2016-02-05 18:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history... Coding Style introduced 2016-03-16 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-03-16 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
40			case self::OS_MAC: return $this->getFileSizeMac($path); break;
			0 ignored issues – show Unused Code introduced 2016-02-05 18:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history... Coding Style introduced 2016-03-16 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-03-16 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
41			default: throw new Exception("OS not detected");
			0 ignored issues – show Coding Style introduced 2016-03-16 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The default body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a default statement must start on the line immediately following the statement. switch ($expr) { default: doSomething(); //right break; } switch ($expr) { default: doSomething(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-03-16 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
42			}
43			}
44
45			/**
46			* Convert string into integer
47			* Must be precise number, otherwise you will see and exception.
48			*
49			* @param $valueAsString
50			* @return BigInteger
51			* @throws Exception
52			*/
53			private function convertToInteger($valueAsString) {
54			if(!is_string($valueAsString)) {
55			throw new Exception("Cannot convert to integer. Expected string, but got " . gettype($valueAsString). ".");
56			}
57			$trimmedInput = trim($valueAsString);
58
59			try {
60			return BigInteger::of($trimmedInput);
61
62			} catch (ArithmeticException $e) {
63			throw new Exception("Returned value cannot be converted to an integer.",0, $e);
64			}
65
66			}
67
68			private function getFileSizeWindows($path)
69			{
70			$escapedPath = escapeshellarg($path);
71			return $this->convertToInteger(
72			exec("for %F in ($escapedPath) do @echo %~zF")
73			);
74			}
75
76			private function getFileSizeLinux($path)
77			{
78			$escapedPath = escapeshellarg($path);
79			return $this->convertToInteger(
80			exec("stat -Lc%s $escapedPath")
81			);
82			}
83
84			private function getFileSizeMac($path)
85			{
86			$escapedPath = escapeshellarg($path);
87			return $this->convertToInteger(
88			exec("stat -f%z $escapedPath")
89			);
90			}
91			}

jkuchar / BigFileTools

Issues (25)

Security Analysis no request data

src/Driver/ExecDriver.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like