Issues in HtmlDocumentFactoryTest.php - Fixed Issues - Inspection of "Improved code climate" - jkphl/rdfa-lite-microdata - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 54b444...8a50e2 )

by Joschi

created 2017-10-15 10:06 UTC

Tests/Infrastructure/HtmlDocumentFactoryTest.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * rdfa-lite
 *
 * @category Jkphl
 * @package Jkphl\Micrometa
 * @subpackage Infrastructure
 * @author Joschi Kuphal <[email protected]> / @jkphl
 * @copyright Copyright © 2017 Joschi Kuphal <[email protected]> / @jkphl
 * @license http://opensource.org/licenses/MIT The MIT License (MIT)
 */

/***********************************************************************************
 *  The MIT License (MIT)
 *
 *  Copyright © 2017 Joschi Kuphal <[email protected]> / @jkphl
 *
 *  Permission is hereby granted, free of charge, to any person obtaining a copy of
 *  this software and associated documentation files (the "Software"), to deal in
 *  the Software without restriction, including without limitation the rights to
 *  use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
 *  the Software, and to permit persons to whom the Software is furnished to do so,
 *  subject to the following conditions:
 *
 *  The above copyright notice and this permission notice shall be included in all
 *  copies or substantial portions of the Software.
 *
 *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 *  FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 *  COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 *  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 *  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 ***********************************************************************************/

namespace Jkphl\RdfaLiteMicrodata\Tests\Infrastructure;

use Jkphl\RdfaLiteMicrodata\Infrastructure\Exceptions\HtmlParsingException;
use Jkphl\RdfaLiteMicrodata\Infrastructure\Factories\HtmlDocumentFactory;

/**
 * DOM document factory tests
 *
 * @package Jkphl\Micrometa
 * @subpackage Jkphl\RdfaLiteMicrodata\Tests
 */
class HtmlDocumentFactoryTest extends \PHPUnit_Framework_TestCase
{
    /**
     * Test the HTML document factory
     */
    public function testHtmlDocument()
    {
        $htmlDocumentFactory = new HtmlDocumentFactory();
        $htmlSource = '<html><head><title>Test</title></head><body><article>Test</article></body></html>';
        $this->assertInstanceOf(\DOMDocument::class, $htmlDocumentFactory->createDocumentFromSource($htmlSource));
    }

    /**
     * Test the HTML document factory parsing error
     */
    public function testHtmlDocumentParsingError()
    {
        try {
            $htmlDocumentFactory = new HtmlDocumentFactory();
            $htmlSource = '<html><head><title>Test</title></head><body><invalid>Test</invalid></body></html>';
            $htmlDocumentFactory->createDocumentFromSource($htmlSource);
        } catch (HtmlParsingException $e) {

            $parsingError = $e->getParsingError();
            $this->assertInstanceOf(\LibXMLError::class, $parsingError);
            $this->assertEquals(2, $parsingError->level);
            $this->assertEquals(801, $parsingError->code);
            $this->assertEquals('Tag invalid invalid', trim($parsingError->message));
        }
    }

    /**
     * Test a custom HTML parsing error handler
     */
    public function testHtmlDocumentCustomErrorHandler()
    {
        $customErrorHandler = function (\LibXMLError $error) {
            return ($error->level == 2) && ($error->code == 801) && (trim($error->message) == 'Tag invalid invalid');
        };
        $htmlDocumentFactory = new HtmlDocumentFactory($customErrorHandler);

        $htmlSource = '<html><head><title>Test</title></head><body><invalid>Test</invalid></body></html>';
        $htmlDocumentFactory->createDocumentFromSource($htmlSource);
    }
}


1			<?php
2
3			/**
4			* rdfa-lite
5			*
6			* @category Jkphl
7			* @package Jkphl\Micrometa
8			* @subpackage Infrastructure
9			* @author Joschi Kuphal <[email protected]> / @jkphl
10			* @copyright Copyright © 2017 Joschi Kuphal <[email protected]> / @jkphl
11			* @license http://opensource.org/licenses/MIT The MIT License (MIT)
12			*/
13
14			/***********************************************************************************
15			* The MIT License (MIT)
16			*
17			* Copyright © 2017 Joschi Kuphal <[email protected]> / @jkphl
18			*
19			* Permission is hereby granted, free of charge, to any person obtaining a copy of
20			* this software and associated documentation files (the "Software"), to deal in
21			* the Software without restriction, including without limitation the rights to
22			* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
23			* the Software, and to permit persons to whom the Software is furnished to do so,
24			* subject to the following conditions:
25			*
26			* The above copyright notice and this permission notice shall be included in all
27			* copies or substantial portions of the Software.
28			*
29			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
30			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
31			* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
32			* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
33			* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
34			* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
35			***********************************************************************************/
36
37			namespace Jkphl\RdfaLiteMicrodata\Tests\Infrastructure;
38
39			use Jkphl\RdfaLiteMicrodata\Infrastructure\Exceptions\HtmlParsingException;
40			use Jkphl\RdfaLiteMicrodata\Infrastructure\Factories\HtmlDocumentFactory;
41
42			/**
43			* DOM document factory tests
44			*
45			* @package Jkphl\Micrometa
46			* @subpackage Jkphl\RdfaLiteMicrodata\Tests
47			*/
48			class HtmlDocumentFactoryTest extends \PHPUnit_Framework_TestCase
49			{
50			/**
51			* Test the HTML document factory
52			*/
53			public function testHtmlDocument()
54			{
55			$htmlDocumentFactory = new HtmlDocumentFactory();
56			$htmlSource = '<html><head><title>Test</title></head><body><article>Test</article></body></html>';
57			$this->assertInstanceOf(\DOMDocument::class, $htmlDocumentFactory->createDocumentFromSource($htmlSource));
58			}
59
60			/**
61			* Test the HTML document factory parsing error
62			*/
63			public function testHtmlDocumentParsingError()
64			{
65			try {
66			$htmlDocumentFactory = new HtmlDocumentFactory();
67			$htmlSource = '<html><head><title>Test</title></head><body><invalid>Test</invalid></body></html>';
68			$htmlDocumentFactory->createDocumentFromSource($htmlSource);
69			} catch (HtmlParsingException $e) {
			0 ignored issues – show Bug introduced 2017-05-24 20:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `Jkphl\RdfaLiteMicrodata\...ns\HtmlParsingException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
70			$parsingError = $e->getParsingError();
71			$this->assertInstanceOf(\LibXMLError::class, $parsingError);
72			$this->assertEquals(2, $parsingError->level);
73			$this->assertEquals(801, $parsingError->code);
74			$this->assertEquals('Tag invalid invalid', trim($parsingError->message));
75			}
76			}
77
78			/**
79			* Test a custom HTML parsing error handler
80			*/
81			public function testHtmlDocumentCustomErrorHandler()
82			{
83			$customErrorHandler = function (\LibXMLError $error) {
84			return ($error->level == 2) && ($error->code == 801) && (trim($error->message) == 'Tag invalid invalid');
85			};
86			$htmlDocumentFactory = new HtmlDocumentFactory($customErrorHandler);
			0 ignored issues – show Unused Code introduced 2017-05-24 20:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `HtmlDocumentFactory::__construct()` has too many arguments starting with `$customErrorHandler`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
87			$htmlSource = '<html><head><title>Test</title></head><body><invalid>Test</invalid></body></html>';
88			$htmlDocumentFactory->createDocumentFromSource($htmlSource);
89			}
90			}
91

jkphl / rdfa-lite-microdata

Push — master ( 54b444...8a50e2 )

Tests/Infrastructure/HtmlDocumentFactoryTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like