PropertyList::getProfiledPropertyCursor() - Code Metrics - Inspection of "Improved test coverage" - jkphl/micrometa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — v2 ( 9de304...bf6a94 )

by Joschi

created 2017-05-27 21:33 UTC

PropertyList::getProfiledPropertyCursor() A

↳ Parent: PropertyList

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0185

Importance

Changes

Metric	Value
cc	2
eloc	5
c	0
b	0
f	0
nc	2
nop	1
dl	0
loc	11
ccs	5
cts	6
cp	0.8333
crap	2.0185
rs	9.4285

<?php

/**
 * micrometa
 *
 * @category Jkphl
 * @package Jkphl\Micrometa
 * @subpackage Jkphl\Micrometa\Domain\Item
 * @author Joschi Kuphal <[email protected]> / @jkphl
 * @copyright Copyright © 2017 Joschi Kuphal <[email protected]> / @jkphl
 * @license http://opensource.org/licenses/MIT The MIT License (MIT)
 */

/***********************************************************************************
 *  The MIT License (MIT)
 *
 *  Copyright © 2017 Joschi Kuphal <[email protected]> / @jkphl
 *
 *  Permission is hereby granted, free of charge, to any person obtaining a copy of
 *  this software and associated documentation files (the "Software"), to deal in
 *  the Software without restriction, including without limitation the rights to
 *  use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
 *  the Software, and to permit persons to whom the Software is furnished to do so,
 *  subject to the following conditions:
 *
 *  The above copyright notice and this permission notice shall be included in all
 *  copies or substantial portions of the Software.
 *
 *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 *  FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 *  COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 *  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 *  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 ***********************************************************************************/

namespace Jkphl\Micrometa\Domain\Item;

use Jkphl\Micrometa\Domain\Exceptions\ErrorException;
use Jkphl\Micrometa\Domain\Exceptions\OutOfBoundsException;
use Jkphl\Micrometa\Domain\Factory\IriFactory;

/**
 * Property list
 *
 * @package Jkphl\Micrometa
 * @subpackage Jkphl\RdfaLiteMicrodata\Domain
 */
class PropertyList implements PropertyListInterface
{
    /**
     * Property values
     *
     * @var array[]
     */
    protected $values = [];
    /**
     * Property names
     *
     * @var \stdClass[]
     */
    protected $names = [];
    /**
     * Name cursor mapping
     *
     * @var int[]
     */
    protected $nameToCursor = [];
    /**
     * Internal cursor
     *
     * @var int
     */
    protected $cursor = 0;

    /**
     * Unset a property
     *
     * @param \stdClass|string $iri IRI
     * @throws ErrorException
     */
    public function offsetUnset($iri)
    {
        throw new ErrorException(
            sprintf(ErrorException::CANNOT_UNSET_PROPERTY_STR, $iri),
            ErrorException::CANNOT_UNSET_PROPERTY,
            E_WARNING
        );
    }

    /**
     * Return the number of properties
     *
     * @return int Number of properties
     */
    public function count()
    {
        return count($this->values);
    }

    /**
     * Return the current property values
     *
     * @return array Property values
     */
    public function current()
    {
        return $this->values[$this->cursor];
    }

    /**
     * Move forward to next element
     */
    public function next()
    {
        ++$this->cursor;
    }

    /**
     * Return the current IRI key
     *
     * @return \stdClass IRI key
     */
    public function key()
    {
        return $this->names[$this->cursor];
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Checks if current position is valid
     *
     * @return boolean The current position is valid
     */
    public function valid()
    {
        return isset($this->values[$this->cursor]);
    }

    /**
     * Rewind the Iterator to the first element
     */
    public function rewind()
    {
        $this->cursor = 0;
    }

    /**
     * Add a property
     *
     * @param \stdClass|Iri $property Property
     */
    public function add($property)
    {
        $iri = IriFactory::create($property);

        $values = (is_object($property) && isset($property->values)) ? (array)$property->values : [];

        // Create the property values list if necessary
        if (!$this->offsetExists($iri)) {
            $this->offsetSet($iri, $values);
            return;
        }

        $propertyValues =& $this->offsetGet($iri);
        $propertyValues = array_merge($propertyValues, $values);
    }

    /**
     * Return whether a property exists
     *
     * @param \stdClass|Iri|string $iri IRI
     * @return boolean Property exists
     */
    public function offsetExists($iri)
    {
        $iri = IriFactory::create($iri);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        try {
            ($iri->profile !== '') ?
                $this->getProfiledPropertyCursor($iri) : $this->getPropertyCursor($iri->name);
            return true;
        } catch (OutOfBoundsException $e) {
            return false;
        }
    }

    /**
     * Get a particular property cursor by its profiled name
     *
     * @param Iri $iri IRI
     * @return int Property cursor
     * @throws OutOfBoundsException If the property name is unknown
     */
    protected function getProfiledPropertyCursor($iri)
    {
        $iriStr = strval($iri);

        // If the property name is unknown
        if (!isset($this->nameToCursor[$iriStr])) {
            $this->handleUnknownName($iriStr);
        }

        return $this->nameToCursor[$iriStr];
    }

    /**
     * Handle an unknown property name
     *
     * @param string $name Property name
     * @throws OutOfBoundsException If the property name is unknown
     */
    protected function handleUnknownName($name)
    {
        throw new OutOfBoundsException(
            sprintf(OutOfBoundsException::UNKNOWN_PROPERTY_NAME_STR, $name),
            OutOfBoundsException::UNKNOWN_PROPERTY_NAME
        );
    }

    /**
     * Get a particular property cursor by its name
     *
     * @param string $name Property name
     * @return int Property cursor
     */
    protected function getPropertyCursor($name)
    {
        // Run through all property names
        foreach ($this->names as $cursor => $iri) {
            if ($name === $iri->name) {
                return $cursor;
            }
        }

        return $this->handleUnknownName($name);
    }

    /**
     * Set a particular property
     *
     * @param \stdClass|Iri|string $iri IRI
     * @param array $value Property values
     */
    public function offsetSet($iri, $value)
    {
        $iri = IriFactory::create($iri);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $iriStr = strval($iri);
        $cursor = array_key_exists($iriStr, $this->nameToCursor) ?
            $this->nameToCursor[$iriStr] : ($this->nameToCursor[$iriStr] = count($this->nameToCursor));
        $this->names[$cursor] = $iri;
        $this->values[$cursor] = $value;
    }

    /**
     * Get a particular property
     *
     * @param \stdClass|Iri|string $iri IRI
     * @return array Property values
     * @throws OutOfBoundsException If the property name is unknown
     */
    public function &offsetGet($iri)
    {
        $iri = IriFactory::create($iri);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $cursor = ($iri->profile !== '') ?
            $this->getProfiledPropertyCursor($iri) : $this->getPropertyCursor($iri->name);
        return $this->values[$cursor];
    }
}


1		<?php
2
3		/**
4		* micrometa
5		*
6		* @category Jkphl
7		* @package Jkphl\Micrometa
8		* @subpackage Jkphl\Micrometa\Domain\Item
9		* @author Joschi Kuphal <[email protected]> / @jkphl
10		* @copyright Copyright © 2017 Joschi Kuphal <[email protected]> / @jkphl
11		* @license http://opensource.org/licenses/MIT The MIT License (MIT)
12		*/
13
14		/***********************************************************************************
15		* The MIT License (MIT)
16		*
17		* Copyright © 2017 Joschi Kuphal <[email protected]> / @jkphl
18		*
19		* Permission is hereby granted, free of charge, to any person obtaining a copy of
20		* this software and associated documentation files (the "Software"), to deal in
21		* the Software without restriction, including without limitation the rights to
22		* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
23		* the Software, and to permit persons to whom the Software is furnished to do so,
24		* subject to the following conditions:
25		*
26		* The above copyright notice and this permission notice shall be included in all
27		* copies or substantial portions of the Software.
28		*
29		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
30		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
31		* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
32		* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
33		* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
34		* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
35		***********************************************************************************/
36
37		namespace Jkphl\Micrometa\Domain\Item;
38
39		use Jkphl\Micrometa\Domain\Exceptions\ErrorException;
40		use Jkphl\Micrometa\Domain\Exceptions\OutOfBoundsException;
41		use Jkphl\Micrometa\Domain\Factory\IriFactory;
42
43		/**
44		* Property list
45		*
46		* @package Jkphl\Micrometa
47		* @subpackage Jkphl\RdfaLiteMicrodata\Domain
48		*/
49		class PropertyList implements PropertyListInterface
50		{
51		/**
52		* Property values
53		*
54		* @var array[]
55		*/
56		protected $values = [];
57		/**
58		* Property names
59		*
60		* @var \stdClass[]
61		*/
62		protected $names = [];
63		/**
64		* Name cursor mapping
65		*
66		* @var int[]
67		*/
68		protected $nameToCursor = [];
69		/**
70		* Internal cursor
71		*
72		* @var int
73		*/
74		protected $cursor = 0;
75
76		/**
77		* Unset a property
78		*
79		* @param \stdClass\|string $iri IRI
80		* @throws ErrorException
81		*/
82	27	public function offsetUnset($iri)
83		{
84	1	throw new ErrorException(
85	1	sprintf(ErrorException::CANNOT_UNSET_PROPERTY_STR, $iri),
86	1	ErrorException::CANNOT_UNSET_PROPERTY,
87		E_WARNING
88	27	);
89		}
90
91		/**
92		* Return the number of properties
93		*
94		* @return int Number of properties
95		*/
96	2	public function count()
97		{
98	2	return count($this->values);
99		}
100
101		/**
102		* Return the current property values
103		*
104		* @return array Property values
105		*/
106	8	public function current()
107		{
108	8	return $this->values[$this->cursor];
109		}
110
111		/**
112		* Move forward to next element
113		*/
114	8	public function next()
115		{
116	8	++$this->cursor;
117	8	}
118
119		/**
120		* Return the current IRI key
121		*
122		* @return \stdClass IRI key
123		*/
124	8	public function key()
125		{
126	8	return $this->names[$this->cursor];
		1 ignored issue – show Bug Best Practice introduced 2017-04-01 15:30 UTC by Report Bug Copy Issue Report The return type of `return $this->names[$this->cursor];` (`stdClass`) is incompatible with the return type declared by the interface `Iterator::key` of type `integer\|double\|string\|boolean`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
127		}
128
129		/**
130		* Checks if current position is valid
131		*
132		* @return boolean The current position is valid
133		*/
134	17	public function valid()
135		{
136	17	return isset($this->values[$this->cursor]);
137		}
138
139		/**
140		* Rewind the Iterator to the first element
141		*/
142	17	public function rewind()
143		{
144	17	$this->cursor = 0;
145	17	}
146
147		/**
148		* Add a property
149		*
150		* @param \stdClass\|Iri $property Property
151		*/
152	35	public function add($property)
153		{
154	35	$iri = IriFactory::create($property);
		0 ignored issues – show Bug introduced 2017-05-27 16:13 UTC by Report Bug Copy Issue Report It seems like `$property` defined by parameter `$property` on line 152 can also be of type `object<Jkphl\Micrometa\Domain\Item\Iri>`; however, `Jkphl\Micrometa\Domain\F...ry\IriFactory::create()` does only seem to accept `string\|object<stdClass>`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
155	35	$values = (is_object($property) && isset($property->values)) ? (array)$property->values : [];
156
157		// Create the property values list if necessary
158	35	if (!$this->offsetExists($iri)) {
159	35	$this->offsetSet($iri, $values);
160	35	return;
161		}
162
163	2	$propertyValues =& $this->offsetGet($iri);
164	2	$propertyValues = array_merge($propertyValues, $values);
165	2	}
166
167		/**
168		* Return whether a property exists
169		*
170		* @param \stdClass\|Iri\|string $iri IRI
171		* @return boolean Property exists
172		*/
173	35	public function offsetExists($iri)
174		{
175	35	$iri = IriFactory::create($iri);
		0 ignored issues – show Bug introduced 2017-05-27 16:13 UTC by Report Bug Copy Issue Report It seems like `$iri` defined by `\Jkphl\Micrometa\Domain\...riFactory::create($iri)` on line `175` can also be of type `object<Jkphl\Micrometa\Domain\Item\Iri>`; however, `Jkphl\Micrometa\Domain\F...ry\IriFactory::create()` does only seem to accept `string\|object<stdClass>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
176		try {
177	35	($iri->profile !== '') ?
178	35	$this->getProfiledPropertyCursor($iri) : $this->getPropertyCursor($iri->name);
179	3	return true;
180	35	} catch (OutOfBoundsException $e) {
181	35	return false;
182		}
183		}
184
185		/**
186		* Get a particular property cursor by its profiled name
187		*
188		* @param Iri $iri IRI
189		* @return int Property cursor
190		* @throws OutOfBoundsException If the property name is unknown
191		*/
192	29	protected function getProfiledPropertyCursor($iri)
193		{
194	29	$iriStr = strval($iri);
195
196		// If the property name is unknown
197	29	if (!isset($this->nameToCursor[$iriStr])) {
198	29	$this->handleUnknownName($iriStr);
199		}
200
201	6	return $this->nameToCursor[$iriStr];
202		}
203
204		/**
205		* Handle an unknown property name
206		*
207		* @param string $name Property name
208		* @throws OutOfBoundsException If the property name is unknown
209		*/
210	38	protected function handleUnknownName($name)
211		{
212	38	throw new OutOfBoundsException(
213	38	sprintf(OutOfBoundsException::UNKNOWN_PROPERTY_NAME_STR, $name),
214		OutOfBoundsException::UNKNOWN_PROPERTY_NAME
215	38	);
216		}
217
218		/**
219		* Get a particular property cursor by its name
220		*
221		* @param string $name Property name
222		* @return int Property cursor
223		*/
224	10	protected function getPropertyCursor($name)
225		{
226		// Run through all property names
227	10	foreach ($this->names as $cursor => $iri) {
228	5	if ($name === $iri->name) {
229	4	return $cursor;
230		}
231	8	}
232
233	8	return $this->handleUnknownName($name);
234		}
235
236		/**
237		* Set a particular property
238		*
239		* @param \stdClass\|Iri\|string $iri IRI
240		* @param array $value Property values
241		*/
242	9	public function offsetSet($iri, $value)
243		{
244	9	$iri = IriFactory::create($iri);
		0 ignored issues – show Bug introduced 2017-05-27 16:13 UTC by Report Bug Copy Issue Report It seems like `$iri` defined by `\Jkphl\Micrometa\Domain\...riFactory::create($iri)` on line `244` can also be of type `object<Jkphl\Micrometa\Domain\Item\Iri>`; however, `Jkphl\Micrometa\Domain\F...ry\IriFactory::create()` does only seem to accept `string\|object<stdClass>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
245	9	$iriStr = strval($iri);
246	9	$cursor = array_key_exists($iriStr, $this->nameToCursor) ?
247	9	$this->nameToCursor[$iriStr] : ($this->nameToCursor[$iriStr] = count($this->nameToCursor));
248	9	$this->names[$cursor] = $iri;
249	9	$this->values[$cursor] = $value;
250	9	}
251
252		/**
253		* Get a particular property
254		*
255		* @param \stdClass\|Iri\|string $iri IRI
256		* @return array Property values
257		* @throws OutOfBoundsException If the property name is unknown
258		*/
259	15	public function &offsetGet($iri)
260		{
261	15	$iri = IriFactory::create($iri);
		0 ignored issues – show Bug introduced 2017-05-27 16:13 UTC by Report Bug Copy Issue Report It seems like `$iri` defined by `\Jkphl\Micrometa\Domain\...riFactory::create($iri)` on line `261` can also be of type `object<Jkphl\Micrometa\Domain\Item\Iri>`; however, `Jkphl\Micrometa\Domain\F...ry\IriFactory::create()` does only seem to accept `string\|object<stdClass>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
262	15	$cursor = ($iri->profile !== '') ?
263	15	$this->getProfiledPropertyCursor($iri) : $this->getPropertyCursor($iri->name);
264	12	return $this->values[$cursor];
265		}
266		}
267

jkphl / micrometa

Push — v2 ( 9de304...bf6a94 )

PropertyList::getProfiledPropertyCursor() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like