| Conditions | 1 |
| Paths | 1 |
| Total Lines | 78 |
| Code Lines | 50 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 59 | protected function getFeedItem() |
||
| 60 | { |
||
| 61 | $authorItem = new ApplicationItem( |
||
| 62 | Microformats::FORMAT, |
||
| 63 | new PropertyListFactory(), |
||
| 64 | (object)['profile' => MicroformatsFactory::MF2_PROFILE_URI, 'name' => 'h-card'], |
||
| 65 | [ |
||
| 66 | (object)[ |
||
| 67 | 'profile' => MicroformatsFactory::MF2_PROFILE_URI, |
||
| 68 | 'name' => 'name', |
||
| 69 | 'values' => [ |
||
| 70 | new StringValue('John Doe') |
||
| 71 | ] |
||
| 72 | ], |
||
| 73 | (object)[ |
||
| 74 | 'profile' => MicroformatsFactory::MF2_PROFILE_URI, |
||
| 75 | 'name' => 'email', |
||
| 76 | 'values' => [ |
||
| 77 | new StringValue('[email protected]') |
||
| 78 | ] |
||
| 79 | ] |
||
| 80 | ] |
||
| 81 | ); |
||
| 82 | |||
| 83 | $entryItem = new ApplicationItem( |
||
| 84 | Microformats::FORMAT, |
||
| 85 | new PropertyListFactory(), |
||
| 86 | (object)['profile' => MicroformatsFactory::MF2_PROFILE_URI, 'name' => 'h-entry'], |
||
| 87 | [ |
||
| 88 | (object)[ |
||
| 89 | 'profile' => MicroformatsFactory::MF2_PROFILE_URI, |
||
| 90 | 'name' => 'name', |
||
| 91 | 'values' => [ |
||
| 92 | new StringValue('Famous blog post') |
||
| 93 | ] |
||
| 94 | ], |
||
| 95 | (object)[ |
||
| 96 | 'profile' => MicroformatsFactory::MF2_PROFILE_URI, |
||
| 97 | 'name' => 'author', |
||
| 98 | 'values' => [ |
||
| 99 | $authorItem |
||
| 100 | ] |
||
| 101 | ] |
||
| 102 | ] |
||
| 103 | ); |
||
| 104 | |||
| 105 | $feedItem = new ApplicationItem( |
||
| 106 | Microformats::FORMAT, |
||
| 107 | new PropertyListFactory(), |
||
| 108 | (object)['profile' => MicroformatsFactory::MF2_PROFILE_URI, 'name' => 'h-feed'], |
||
| 109 | [ |
||
| 110 | (object)[ |
||
| 111 | 'profile' => MicroformatsFactory::MF2_PROFILE_URI, |
||
| 112 | 'name' => 'name', |
||
| 113 | 'values' => [ |
||
| 114 | new StringValue('John Doe\'s Blog') |
||
| 115 | ] |
||
| 116 | ], |
||
| 117 | (object)[ |
||
| 118 | 'profile' => MicroformatsFactory::MF2_PROFILE_URI, |
||
| 119 | 'name' => 'author', |
||
| 120 | 'values' => [ |
||
| 121 | $authorItem |
||
| 122 | ] |
||
| 123 | ], |
||
| 124 | (object)[ |
||
| 125 | 'profile' => MicroformatsFactory::MF2_PROFILE_URI, |
||
| 126 | 'name' => 'custom-property', |
||
| 127 | 'values' => [ |
||
| 128 | new StringValue('Property for alias testing') |
||
| 129 | ] |
||
| 130 | ], |
||
| 131 | ], |
||
| 132 | [$entryItem, $entryItem] |
||
| 133 | ); |
||
| 134 | |||
| 135 | return new Item($feedItem); |
||
| 136 | } |
||
| 137 | } |
||
| 138 |