Antibot::armor() - Code Metrics - Inspection of "Move validation result to public layer (closes #1)" - jkphl/antibot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 35952b...e2447c )

by Joschi

created 2019-01-29 17:43 UTC

Antibot::armor() A

↳ Parent: Antibot

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php

/**
 * antibot
 *
 * @category   Jkphl
 * @package    Jkphl\Antibot
 * @subpackage Jkphl\Antibot\Ports
 * @author     Joschi Kuphal <[email protected]> / @jkphl
 * @copyright  Copyright © 2018 Joschi Kuphal <[email protected]> / @jkphl
 * @license    http://opensource.org/licenses/MIT The MIT License (MIT)
 */

/***********************************************************************************
 *  The MIT License (MIT)
 *
 *  Copyright © 2018 Joschi Kuphal <[email protected]>
 *
 *  Permission is hereby granted, free of charge, to any person obtaining a copy of
 *  this software and associated documentation files (the "Software"), to deal in
 *  the Software without restriction, including without limitation the rights to
 *  use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
 *  the Software, and to permit persons to whom the Software is furnished to do so,
 *  subject to the following conditions:
 *
 *  The above copyright notice and this permission notice shall be included in all
 *  copies or substantial portions of the Software.
 *
 *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 *  FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 *  COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 *  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 *  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 ***********************************************************************************/

namespace Jkphl\Antibot\Ports;

use Jkphl\Antibot\Ports\Exceptions\InvalidArgumentException;
use Psr\Http\Message\ServerRequestInterface;

/**
 * Antibot Facade
 *
 * @package    Jkphl\Antibot
 * @subpackage Jkphl\Antibot\Ports
 */
class Antibot extends \Jkphl\Antibot\Domain\Antibot
{
    /**
     * Set the prefix
     *
     * @param string $prefix Prefix
     *
     * @api
     */
    public function setPrefix(string $prefix): void
    {
        $prefix = trim($prefix);
        if (!strlen($prefix)) {
            throw new InvalidArgumentException(
                sprintf(InvalidArgumentException::INVALID_PREFIX_STR, $prefix),
                InvalidArgumentException::INVALID_PREFIX
            );
        }
        $this->prefix = $prefix;
    }

    /**
     * Return the Antibot armor
     *
     * @param ServerRequestInterface $request Request
     *
     * @return string Antibot armor (HTML)
     * @api
     */
    public function armor(ServerRequestInterface $request)
    {
        return implode('', array_map('strval', $this->armorInputs($request)));
    }

    /**
     * Validate a request
     *
     * @param ServerRequestInterface $request Request
     *
     * @return ValidationResult Validation result
     * @api
     */
    public function validate(ServerRequestInterface $request): ValidationResult
    {
        return parent::validateRequest($request, new ValidationResult());
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1		<?php
2
3		/**
4		* antibot
5		*
6		* @category Jkphl
7		* @package Jkphl\Antibot
8		* @subpackage Jkphl\Antibot\Ports
9		* @author Joschi Kuphal <[email protected]> / @jkphl
10		* @copyright Copyright © 2018 Joschi Kuphal <[email protected]> / @jkphl
11		* @license http://opensource.org/licenses/MIT The MIT License (MIT)
12		*/
13
14		/***********************************************************************************
15		* The MIT License (MIT)
16		*
17		* Copyright © 2018 Joschi Kuphal <[email protected]>
18		*
19		* Permission is hereby granted, free of charge, to any person obtaining a copy of
20		* this software and associated documentation files (the "Software"), to deal in
21		* the Software without restriction, including without limitation the rights to
22		* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
23		* the Software, and to permit persons to whom the Software is furnished to do so,
24		* subject to the following conditions:
25		*
26		* The above copyright notice and this permission notice shall be included in all
27		* copies or substantial portions of the Software.
28		*
29		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
30		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
31		* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
32		* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
33		* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
34		* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
35		***********************************************************************************/
36
37		namespace Jkphl\Antibot\Ports;
38
39		use Jkphl\Antibot\Ports\Exceptions\InvalidArgumentException;
40		use Psr\Http\Message\ServerRequestInterface;
41
42		/**
43		* Antibot Facade
44		*
45		* @package Jkphl\Antibot
46		* @subpackage Jkphl\Antibot\Ports
47		*/
48		class Antibot extends \Jkphl\Antibot\Domain\Antibot
49		{
50		/**
51		* Set the prefix
52		*
53		* @param string $prefix Prefix
54		*
55		* @api
56		*/
57	1	public function setPrefix(string $prefix): void
58		{
59	1	$prefix = trim($prefix);
60	1	if (!strlen($prefix)) {
61	1	throw new InvalidArgumentException(
62	1	sprintf(InvalidArgumentException::INVALID_PREFIX_STR, $prefix),
63	1	InvalidArgumentException::INVALID_PREFIX
64		);
65		}
66	1	$this->prefix = $prefix;
67	1	}
68
69		/**
70		* Return the Antibot armor
71		*
72		* @param ServerRequestInterface $request Request
73		*
74		* @return string Antibot armor (HTML)
75		* @api
76		*/
77		public function armor(ServerRequestInterface $request)
78		{
79		return implode('', array_map('strval', $this->armorInputs($request)));
80		}
81
82		/**
83		* Validate a request
84		*
85		* @param ServerRequestInterface $request Request
86		*
87		* @return ValidationResult Validation result
88		* @api
89		*/
90	5	public function validate(ServerRequestInterface $request): ValidationResult
91		{
92	5	return parent::validateRequest($request, new ValidationResult());
		0 ignored issues – show Comprehensibility Bug introduced 2019-01-29 17:50 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`validateRequest()` instead of `validate()`). Are you sure this is correct? If so, you might want to change this to `$this->validateRequest()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
93		}
94		}
95

jkphl / antibot

Push — master ( 35952b...e2447c )

Antibot::armor() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like