Vox\Webservice\Metadata\TransferMetadata

Complexity

Total Complexity

8

Size/Duplication

Total Lines	71
Duplicated Lines	19.72 %

Test Coverage

Coverage

94.12%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	addPropertyMetadata()	0	20	5
A	serialize()	0	11	1
A	unserialize()	14	14	1
A	getAssociation()	0	3	1

<?php

namespace Vox\Webservice\Metadata;

use Metadata\PropertyMetadata as BasePropertyMetadata;
use ReflectionClass;
use Vox\Data\Mapping\Exclude;
use Vox\Metadata\ClassMetadata;
use Vox\Metadata\PropertyMetadata;
use Vox\Webservice\Mapping\BelongsTo;
use Vox\Webservice\Mapping\Id;

class TransferMetadata extends ClassMetadata
{
    /**
     * @var PropertyMetadata
     */
    public $id;
    
    /**
     * @var PropertyMetadata[]
     */
    public $associations = [];
    
    public function addPropertyMetadata(BasePropertyMetadata $metadata)
    {
        if ($metadata instanceof PropertyMetadata) {
            if ($id = $metadata->getAnnotation(Id::class)) {

The assignment to $id is dead and can be removed.

                $this->id = $metadata;
            }
        }
        
        parent::addPropertyMetadata($metadata);
        
        if ($metadata->hasAnnotation(BelongsTo::class)) {

The method hasAnnotation() does not exist on Metadata\PropertyMetadata. Are you sure you never get this type here, but always one of the subclasses?

            if (!$metadata->hasAnnotation(Exclude::class)) {
                $metadata->annotations[Exclude::class] = new Exclude();
                $metadata->annotations[Exclude::class]->output = false;
            }
            
            $this->associations[$metadata->name] = $metadata;
        }
        
        return $this;
    }
    
    /**
     * @param string $name
     * @return PropertyMetadata
     */
    public function getAssociation(string $name)
    {
        return $this->associations[$name] ?? null;
    }
    
    public function serialize()
    {
        return serialize(array(
            $this->name,
            $this->methodMetadata,
            $this->propertyMetadata,
            $this->fileResources,
            $this->createdAt,
            $this->annotations,
            $this->id,
            $this->associations,
        ));
    }

    public function unserialize($str)

This method seems to be duplicated in your project.

    {
        list(
            $this->name,
            $this->methodMetadata,
            $this->propertyMetadata,
            $this->fileResources,
            $this->createdAt,
            $this->annotations,
            $this->id,
            $this->associations
        ) = unserialize($str);

        $this->reflection = new ReflectionClass($this->name);
    }
}