Vox\Webservice\Metadata\IdMetadata

Complexity

Total Complexity

15

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Test Coverage

Coverage

80%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	hasIds()	0	3	1
A	getName()	0	13	3
A	getType()	0	11	3
A	isMultiId()	0	3	1
A	getIds()	0	3	1
A	append()	0	3	1
B	getValue()	0	23	5

<?php

namespace Vox\Webservice\Metadata;

use Vox\Metadata\PropertyMetadata;

class IdMetadata
{
    /**
     * @var PropertyMetadata[]
     */
    private $ids = [];

    public function append(PropertyMetadata $metadata)
    {
        $this->ids[] = $metadata;
    }

    public function getValue($object)
    {
        if (!$this->hasIds()) {
            throw new \RuntimeException("transfer " . get_class($object) . " has no id mapping");
        }

        if ($this->isMultiId()) {
            $values = [];

            foreach ($this->ids as $idMetadata) {
                $value = $idMetadata->getValue($object);

                if (!$value) {
                    continue;
                }

                $values[] = sprintf('%s=%s', $idMetadata->name, $idMetadata->getValue($object));
            }

            return implode(';', $values);
        }

        return $this->ids[0]->getValue($object);
    }

    public function hasIds(): bool
    {
        return !empty($this->ids);
    }

    public function getName()
    {
        if (!$this->hasIds()) {
            return;
        }

        if ($this->isMultiId()) {
            return implode(array_map(function ($metadata) {

The call to array_map() has too few arguments starting with arr1.

                return $metadata->name;
            }));
        }

        return $this->ids[0]->name;
    }

    public function isMultiId(): bool
    {
        return count($this->ids) > 1;
    }

    public function getType(): string
    {
        if (!$this->hasIds()) {
            return '';
        }

        if ($this->isMultiId()) {
            return 'multi';
        }

        return $this->ids[0]->type;

The expression return $this->ids[0]->type could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    public function getIds()
    {
        return $this->ids;
    }
}