Cart::serializeProducts() - Code Metrics - Inspection of "Refactor na serialização do Pagamento, agora cada..." - jhernandes/ipag-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d2b3f3...05ef8e )

by João Felipe Magro

created 2018-01-05 20:05 UTC

Cart::serializeProducts() A

↳ Parent: Cart

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	10
nc	2
nop	0

<?php

namespace Ipag\Classes;

use Ipag\Classes\Contracts\Emptiable;
use Ipag\Classes\Contracts\Serializable;
use Ipag\Classes\Traits\EmptiableTrait;

final class Cart implements Emptiable, Serializable
{
    use EmptiableTrait;

    /**
     * @var array of Product
     */
    private $products = [];

    /**
     * @return array of Product
     */
    public function getProducts()
    {
        if (empty($this->products)) {
            return [];
        }

        return $this->products;
    }

    /**
     * @param Product $product
     */
    public function addProduct(Product $product)
    {
        $this->products[] = $product;

        return $this;
    }

    /**
     * @param array of Product $products
     */
    public function addProducts(array $products)
    {
        foreach ($products as $product) {
            $this->addProduct($product);
        }

        return $this;
    }

    public function serialize()
    {
        if ($this->isEmpty()) {
            return [];
        }

        return [
            'descricao_pedido' => urlencode(json_encode($this->serializeProducts())),
        ];
    }

    private function serializeProducts()
    {
        $_products = [];
        $productId = 1;

        foreach ($this->getProducts() as $product) {
            $_products[$productId++] = [
                'descr' => $product->getName(),
                'valor' => $product->getUnitPrice(),
                'quant' => $product->getQuantity(),
                'id'    => $product->getSku(),
            ];
        }

        return $_products;
    }
}


1			<?php
2
3			namespace Ipag\Classes;
4
5			use Ipag\Classes\Contracts\Emptiable;
6			use Ipag\Classes\Contracts\Serializable;
7			use Ipag\Classes\Traits\EmptiableTrait;
8
9			final class Cart implements Emptiable, Serializable
10			{
11			use EmptiableTrait;
12
13			/**
14			* @var array of Product
15			*/
16			private $products = [];
17
18			/**
19			* @return array of Product
20			*/
21			public function getProducts()
22			{
23			if (empty($this->products)) {
24			return [];
25			}
26
27			return $this->products;
28			}
29
30			/**
31			* @param Product $product
32			*/
33			public function addProduct(Product $product)
34			{
35			$this->products[] = $product;
36
37			return $this;
38			}
39
40			/**
41			* @param array of Product $products
42			*/
43			public function addProducts(array $products)
44			{
45			foreach ($products as $product) {
46			$this->addProduct($product);
47			}
48
49			return $this;
50			}
51
52			public function serialize()
53			{
54			if ($this->isEmpty()) {
55			return [];
56			}
57
58			return [
59			'descricao_pedido' => urlencode(json_encode($this->serializeProducts())),
60			];
61			}
62
63			private function serializeProducts()
64			{
65			$_products = [];
66			$productId = 1;
67
68			foreach ($this->getProducts() as $product) {
69			$_products[$productId++] = [
70			'descr' => $product->getName(),
71			'valor' => $product->getUnitPrice(),
72			'quant' => $product->getQuantity(),
73			'id' => $product->getSku(),
74			];
75			}
76
77			return $_products;
78			}
79			}
80

jhernandes / ipag-sdk-php

Push — master ( d2b3f3...05ef8e )

Cart::serializeProducts() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like