Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like RawDrupalContext often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use RawDrupalContext, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
25 | class RawDrupalContext extends RawMinkContext implements DrupalAwareInterface { |
||
26 | |||
27 | /** |
||
28 | * Drupal driver manager. |
||
29 | * |
||
30 | * @var \Drupal\DrupalDriverManager |
||
31 | */ |
||
32 | private $drupal; |
||
33 | |||
34 | /** |
||
35 | * Test parameters. |
||
36 | * |
||
37 | * @var array |
||
38 | */ |
||
39 | private $drupalParameters; |
||
40 | |||
41 | /** |
||
42 | * Event dispatcher object. |
||
43 | * |
||
44 | * @var \Behat\Testwork\Hook\HookDispatcher |
||
45 | */ |
||
46 | protected $dispatcher; |
||
47 | |||
48 | /** |
||
49 | * Keep track of nodes so they can be cleaned up. |
||
50 | * |
||
51 | * @var array |
||
52 | */ |
||
53 | protected $nodes = array(); |
||
54 | |||
55 | /** |
||
56 | * Current authenticated user. |
||
57 | * |
||
58 | * A value of FALSE denotes an anonymous user. |
||
59 | * |
||
60 | * @var stdClass|bool |
||
61 | */ |
||
62 | public $user = FALSE; |
||
63 | |||
64 | /** |
||
65 | * Keep track of all users that are created so they can easily be removed. |
||
66 | * |
||
67 | * @var array |
||
68 | */ |
||
69 | protected $users = array(); |
||
70 | |||
71 | /** |
||
72 | * Keep track of all terms that are created so they can easily be removed. |
||
73 | * |
||
74 | * @var array |
||
75 | */ |
||
76 | protected $terms = array(); |
||
77 | |||
78 | /** |
||
79 | * Keep track of any roles that are created so they can easily be removed. |
||
80 | * |
||
81 | * @var array |
||
82 | */ |
||
83 | protected $roles = array(); |
||
84 | |||
85 | /** |
||
86 | * Keep track of any languages that are created so they can easily be removed. |
||
87 | * |
||
88 | * @var array |
||
89 | */ |
||
90 | protected $languages = array(); |
||
91 | |||
92 | /** |
||
93 | * {@inheritDoc} |
||
94 | */ |
||
95 | public function setDrupal(DrupalDriverManager $drupal) { |
||
98 | |||
99 | /** |
||
100 | * {@inheritDoc} |
||
101 | */ |
||
102 | public function getDrupal() { |
||
105 | |||
106 | /** |
||
107 | * {@inheritDoc} |
||
108 | */ |
||
109 | public function setDispatcher(HookDispatcher $dispatcher) { |
||
112 | |||
113 | /** |
||
114 | * Set parameters provided for Drupal. |
||
115 | */ |
||
116 | public function setDrupalParameters(array $parameters) { |
||
119 | |||
120 | /** |
||
121 | * Returns a specific Drupal parameter. |
||
122 | * |
||
123 | * @param string $name |
||
124 | * Parameter name. |
||
125 | * |
||
126 | * @return mixed |
||
127 | */ |
||
128 | public function getDrupalParameter($name) { |
||
131 | |||
132 | /** |
||
133 | * Returns a specific Drupal text value. |
||
134 | * |
||
135 | * @param string $name |
||
136 | * Text value name, such as 'log_out', which corresponds to the default 'Log |
||
137 | * out' link text. |
||
138 | * @throws \Exception |
||
139 | * @return |
||
140 | */ |
||
141 | View Code Duplication | public function getDrupalText($name) { |
|
148 | |||
149 | /** |
||
150 | * Returns a specific css selector. |
||
151 | * |
||
152 | * @param $name |
||
153 | * string CSS selector name |
||
154 | */ |
||
155 | View Code Duplication | public function getDrupalSelector($name) { |
|
162 | |||
163 | /** |
||
164 | * Get active Drupal Driver. |
||
165 | */ |
||
166 | public function getDriver($name = NULL) { |
||
169 | |||
170 | /** |
||
171 | * Get driver's random generator. |
||
172 | */ |
||
173 | public function getRandom() { |
||
176 | |||
177 | /** |
||
178 | * Massage node values to match the expectations on different Drupal versions. |
||
179 | * |
||
180 | * @beforeNodeCreate |
||
181 | */ |
||
182 | public function alterNodeParameters(BeforeNodeCreateScope $scope) { |
||
204 | |||
205 | /** |
||
206 | * Remove any created nodes. |
||
207 | * |
||
208 | * @AfterScenario |
||
209 | */ |
||
210 | public function cleanNodes() { |
||
217 | |||
218 | /** |
||
219 | * Remove any created users. |
||
220 | * |
||
221 | * @AfterScenario |
||
222 | */ |
||
223 | public function cleanUsers() { |
||
233 | |||
234 | /** |
||
235 | * Remove any created terms. |
||
236 | * |
||
237 | * @AfterScenario |
||
238 | */ |
||
239 | public function cleanTerms() { |
||
246 | |||
247 | /** |
||
248 | * Remove any created roles. |
||
249 | * |
||
250 | * @AfterScenario |
||
251 | */ |
||
252 | public function cleanRoles() { |
||
259 | |||
260 | /** |
||
261 | * Remove any created languages. |
||
262 | * |
||
263 | * @AfterScenario |
||
264 | */ |
||
265 | public function cleanLanguages() { |
||
272 | |||
273 | /** |
||
274 | * Clear static caches. |
||
275 | * |
||
276 | * @AfterScenario @api |
||
277 | */ |
||
278 | public function clearStaticCaches() { |
||
281 | |||
282 | /** |
||
283 | * Dispatch scope hooks. |
||
284 | * |
||
285 | * @param string $scope |
||
286 | * The entity scope to dispatch. |
||
287 | * @param stdClass $entity |
||
288 | * The entity. |
||
289 | */ |
||
290 | protected function dispatchHooks($scopeType, \stdClass $entity) { |
||
303 | |||
304 | /** |
||
305 | * Create a node. |
||
306 | * |
||
307 | * @return object |
||
308 | * The created node. |
||
309 | */ |
||
310 | View Code Duplication | public function nodeCreate($node) { |
|
318 | |||
319 | /** |
||
320 | * Parse multi-value fields. Possible formats: |
||
321 | * A, B, C |
||
322 | * A - B, C - D, E - F |
||
323 | * |
||
324 | * @param string $entity_type |
||
325 | * The entity type. |
||
326 | * @param \stdClass $entity |
||
327 | * An object containing the entity properties and fields as properties. |
||
328 | */ |
||
329 | public function parseEntityFields($entity_type, \stdClass $entity) { |
||
396 | |||
397 | /** |
||
398 | * Create a user. |
||
399 | * |
||
400 | * @return object |
||
401 | * The created user. |
||
402 | */ |
||
403 | View Code Duplication | public function userCreate($user) { |
|
411 | |||
412 | /** |
||
413 | * Create a term. |
||
414 | * |
||
415 | * @return object |
||
416 | * The created term. |
||
417 | */ |
||
418 | View Code Duplication | public function termCreate($term) { |
|
426 | |||
427 | /** |
||
428 | * Creates a language. |
||
429 | * |
||
430 | * @param \stdClass $language |
||
431 | * An object with the following properties: |
||
432 | * - langcode: the langcode of the language to create. |
||
433 | * |
||
434 | * @return object|FALSE |
||
435 | * The created language, or FALSE if the language was already created. |
||
436 | */ |
||
437 | public function languageCreate(\stdClass $language) { |
||
446 | |||
447 | /** |
||
448 | * Log-in the current user. |
||
449 | */ |
||
450 | public function login() { |
||
481 | |||
482 | /** |
||
483 | * Logs the current user out. |
||
484 | */ |
||
485 | public function logout() { |
||
488 | |||
489 | /** |
||
490 | * Determine if the a user is already logged in. |
||
491 | * |
||
492 | * @return boolean |
||
493 | * Returns TRUE if a user is logged in for this session. |
||
494 | */ |
||
495 | public function loggedIn() { |
||
523 | |||
524 | /** |
||
525 | * User with a given role is already logged in. |
||
526 | * |
||
527 | * @param string $role |
||
528 | * A single role, or multiple comma-separated roles in a single string. |
||
529 | * |
||
530 | * @return boolean |
||
531 | * Returns TRUE if the current logged in user has this role (or roles). |
||
532 | */ |
||
533 | public function loggedInWithRole($role) { |
||
536 | |||
537 | } |
||
538 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.