| Conditions | 2 |
| Paths | 2 |
| Total Lines | 105 |
| Code Lines | 89 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 49 | public function load(ObjectManager $manager) |
||
| 50 | { |
||
| 51 | $now = new DateTime(); |
||
| 52 | $refDate = new DateTime(); |
||
| 53 | $refDate->setDate(2016, 8, 1)->setTime(0, 0, 1); |
||
| 54 | $dataArray = array( |
||
| 55 | array( |
||
| 56 | 'level' => 1, |
||
| 57 | 'r1' => 10, |
||
| 58 | 'r2' => 0, |
||
| 59 | 'r3' => 0, |
||
| 60 | 'factor' => '100000000', |
||
| 61 | 'lastUpdate' => $refDate, |
||
| 62 | ), |
||
| 63 | array( |
||
| 64 | 'level' => 1, |
||
| 65 | 'r1' => 0, |
||
| 66 | 'r2' => 0, |
||
| 67 | 'r3' => 0, |
||
| 68 | 'factor' => '000100000', |
||
| 69 | 'lastUpdate' => $refDate, |
||
| 70 | ), |
||
| 71 | array( |
||
| 72 | 'level' => 1, |
||
| 73 | 'r1' => 0, |
||
| 74 | 'r2' => 0, |
||
| 75 | 'r3' => 0, |
||
| 76 | 'factor' => '000000100', |
||
| 77 | 'lastUpdate' => $refDate, |
||
| 78 | ), |
||
| 79 | array( |
||
| 80 | 'level' => 1, |
||
| 81 | 'r1' => 0, |
||
| 82 | 'r2' => 0, |
||
| 83 | 'r3' => 0, |
||
| 84 | 'factor' => '050020005', |
||
| 85 | 'lastUpdate' => $refDate, |
||
| 86 | ), |
||
| 87 | array( |
||
| 88 | 'level' => 1, |
||
| 89 | 'r1' => 0, |
||
| 90 | 'r2' => 0, |
||
| 91 | 'r3' => 0, |
||
| 92 | 'factor' => '022022022', |
||
| 93 | 'lastUpdate' => $refDate, |
||
| 94 | ), |
||
| 95 | array( |
||
| 96 | 'level' => 1, |
||
| 97 | 'r1' => 0, |
||
| 98 | 'r2' => 0, |
||
| 99 | 'r3' => 0, |
||
| 100 | 'factor' => '022022022', |
||
| 101 | 'lastUpdate' => $refDate, |
||
| 102 | ), |
||
| 103 | array( |
||
| 104 | 'level' => 1, |
||
| 105 | 'r1' => 0, |
||
| 106 | 'r2' => 0, |
||
| 107 | 'r3' => 0, |
||
| 108 | 'factor' => '022022022', |
||
| 109 | 'lastUpdate' => $refDate, |
||
| 110 | ), |
||
| 111 | array( |
||
| 112 | 'level' => 10, |
||
| 113 | 'r1' => 0, |
||
| 114 | 'r2' => 0, |
||
| 115 | 'r3' => 0, |
||
| 116 | 'factor' => '022022022', |
||
| 117 | 'lastUpdate' => $refDate, |
||
| 118 | ), |
||
| 119 | array( |
||
| 120 | 'level' => 1, |
||
| 121 | 'r1' => 0, |
||
| 122 | 'r2' => 0, |
||
| 123 | 'r3' => 0, |
||
| 124 | 'factor' => '022022022', |
||
| 125 | 'lastUpdate' => $now, |
||
| 126 | ), |
||
| 127 | array( |
||
| 128 | 'level' => 10, |
||
| 129 | 'r1' => 0, |
||
| 130 | 'r2' => 0, |
||
| 131 | 'r3' => 0, |
||
| 132 | 'factor' => '022022022', |
||
| 133 | 'lastUpdate' => $now, |
||
| 134 | ), |
||
| 135 | ); |
||
| 136 | $objectList = array(); |
||
| 137 | |||
| 138 | foreach ($dataArray as $i => $data) { |
||
| 139 | $objectList[$i] = new Mine(); |
||
| 140 | $objectList[$i]->setLevel($data['level']); |
||
| 141 | $objectList[$i]->setR1($data['r1']); |
||
| 142 | $objectList[$i]->setR2($data['r2']); |
||
| 143 | $objectList[$i]->setR3($data['r3']); |
||
| 144 | $objectList[$i]->setFactor($data['factor']); |
||
| 145 | $objectList[$i]->setLastUpdate($data['lastUpdate']); |
||
| 146 | |||
| 147 | $manager->persist($objectList[$i]); |
||
| 148 | $id = $i + 1; |
||
| 149 | $ref = 'mine'.$id.'-mine'; |
||
| 150 | $this->addReference($ref, $objectList[$i]); |
||
| 151 | } |
||
| 152 | $manager->flush(); |
||
| 153 | } |
||
| 154 | |||
| 167 |