jfederico / moodle-mod_bigbluebuttonbn

classes/external.php

Spacing +2 added lines, -2 removed lines

@@ -61,7 +61,7 @@ 
      */
     public static function view_bigbluebuttonbn($bigbluebuttonbnid) {
         global $DB, $CFG;
-        require_once($CFG->dirroot . "/mod/bigbluebuttonbn/lib.php");
+        require_once($CFG->dirroot."/mod/bigbluebuttonbn/lib.php");
 
         $params = self::validate_parameters(self::view_bigbluebuttonbn_parameters(),
                                             array(
@@ -109,7 +109,7 @@ 
      * @since Moodle 3.3
      */
     public static function get_bigbluebuttonbns_by_courses_parameters() {
-        return new external_function_parameters (
+        return new external_function_parameters(
             array(
                 'courseids' => new external_multiple_structure(
                     new external_value(PARAM_INT, 'Course id'), 'Array of course ids', VALUE_DEFAULT, array()

classes/settings/renderer.php

Spacing +24 added lines, -24 removed lines

@@ -27,7 +27,7 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 require_once($CFG->libdir.'/adminlib.php');
 
 /**
@@ -63,12 +63,12 @@ 
      */
     public function render_group_header($name, $itemname = null, $itemdescription = null) {
         if ($itemname === null) {
-            $itemname = get_string('config_' . $name, 'bigbluebuttonbn');
+            $itemname = get_string('config_'.$name, 'bigbluebuttonbn');
         }
         if ($itemdescription === null) {
-            $itemdescription = get_string('config_' .$name . '_description', 'bigbluebuttonbn');
+            $itemdescription = get_string('config_'.$name.'_description', 'bigbluebuttonbn');
         }
-        $item = new \admin_setting_heading('bigbluebuttonbn_config_' . $name, $itemname, $itemdescription);
+        $item = new \admin_setting_heading('bigbluebuttonbn_config_'.$name, $itemname, $itemdescription);
         $this->settings->add($item);
     }
 
@@ -97,9 +97,9 @@ 
      * @return Object
      */
     public function render_group_element_text($name, $default = null, $type = PARAM_RAW) {
-        $item = new \admin_setting_configtext('bigbluebuttonbn_' . $name,
-                get_string('config_' . $name, 'bigbluebuttonbn'),
-                get_string('config_' . $name . '_description', 'bigbluebuttonbn'),
+        $item = new \admin_setting_configtext('bigbluebuttonbn_'.$name,
+                get_string('config_'.$name, 'bigbluebuttonbn'),
+                get_string('config_'.$name.'_description', 'bigbluebuttonbn'),
                 $default, $type);
         return $item;
     }
@@ -113,9 +113,9 @@ 
      * @return Object
      */
     public function render_group_element_checkbox($name, $default = null) {
-        $item = new \admin_setting_configcheckbox('bigbluebuttonbn_' . $name,
-                get_string('config_' . $name, 'bigbluebuttonbn'),
-                get_string('config_' . $name . '_description', 'bigbluebuttonbn'),
+        $item = new \admin_setting_configcheckbox('bigbluebuttonbn_'.$name,
+                get_string('config_'.$name, 'bigbluebuttonbn'),
+                get_string('config_'.$name.'_description', 'bigbluebuttonbn'),
                 $default);
         return $item;
     }
@@ -130,9 +130,9 @@ 
      * @return Object
      */
     public function render_group_element_configmultiselect($name, $defaultsetting, $choices) {
-        $item = new \admin_setting_configmultiselect('bigbluebuttonbn_' . $name,
-                get_string('config_' . $name, 'bigbluebuttonbn'),
-                get_string('config_' . $name . '_description', 'bigbluebuttonbn'),
+        $item = new \admin_setting_configmultiselect('bigbluebuttonbn_'.$name,
+                get_string('config_'.$name, 'bigbluebuttonbn'),
+                get_string('config_'.$name.'_description', 'bigbluebuttonbn'),
                 $defaultsetting, $choices);
         return $item;
     }
@@ -147,9 +147,9 @@ 
      * @return Object
      */
     public function render_group_element_configselect($name, $defaultsetting, $choices) {
-        $item = new \admin_setting_configselect('bigbluebuttonbn_' . $name,
-                get_string('config_' . $name, 'bigbluebuttonbn'),
-                get_string('config_' . $name . '_description', 'bigbluebuttonbn'),
+        $item = new \admin_setting_configselect('bigbluebuttonbn_'.$name,
+                get_string('config_'.$name, 'bigbluebuttonbn'),
+                get_string('config_'.$name.'_description', 'bigbluebuttonbn'),
                 $defaultsetting, $choices);
         return $item;
     }
@@ -166,14 +166,14 @@ 
      */
     public function render_warning_message($name, $message, $type = 'warning', $closable = true) {
         global $OUTPUT;
-        $output = $OUTPUT->box_start('box boxalignleft adminerror alert alert-' . $type . ' alert-block fade in',
-            'bigbluebuttonbn_' . $name)."\n";
+        $output = $OUTPUT->box_start('box boxalignleft adminerror alert alert-'.$type.' alert-block fade in',
+            'bigbluebuttonbn_'.$name)."\n";
         if ($closable) {
-            $output .= '  <button type="button" class="close" data-dismiss="alert">&times;</button>' . "\n";
+            $output .= '  <button type="button" class="close" data-dismiss="alert">&times;</button>'."\n";
         }
-        $output .= '  ' . $message . "\n";
-        $output .= $OUTPUT->box_end() . "\n";
-        $item = new \admin_setting_heading('bigbluebuttonbn_' . $name, '', $output);
+        $output .= '  '.$message."\n";
+        $output .= $OUTPUT->box_end()."\n";
+        $item = new \admin_setting_heading('bigbluebuttonbn_'.$name, '', $output);
         $this->settings->add($item);
         return $item;
     }
@@ -195,8 +195,8 @@ 
         $filemanageroptions['mainfile'] = true;
 
         $filemanager = new \admin_setting_configstoredfile('mod_bigbluebuttonbn/presentationdefault',
-            get_string('config_' . $name, 'bigbluebuttonbn'),
-            get_string('config_' . $name . '_description', 'bigbluebuttonbn'),
+            get_string('config_'.$name, 'bigbluebuttonbn'),
+            get_string('config_'.$name.'_description', 'bigbluebuttonbn'),
             'presentationdefault',
             0,
             $filemanageroptions);

classes/settings/validator.php

Spacing +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 require_once($CFG->libdir.'/adminlib.php');
 
 /**
@@ -62,7 +62,7 @@ 
                 !isset($CFG->bigbluebuttonbn['recording_all_from_start_default']) ||
                 !isset($CFG->bigbluebuttonbn['recording_all_from_start_editable']) ||
                 !isset($CFG->bigbluebuttonbn['recording_hide_button_default']) ||
-                !isset($CFG->bigbluebuttonbn['recording_hide_button_editable']) );
+                !isset($CFG->bigbluebuttonbn['recording_hide_button_editable']));
     }
 
     /**

Indentation +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
                 !isset($CFG->bigbluebuttonbn['recordings_preview_default']) ||
                 !isset($CFG->bigbluebuttonbn['recordings_preview_editable']) ||
                 !isset($CFG->bigbluebuttonbn['recordings_validate_url'])
-              );
+                );
     }
 
     /**

viewlib.php

Spacing +7 added lines, -7 removed lines

@@ -85,7 +85,7 @@ 
         return;
     }
     echo $OUTPUT->box_start('generalbox boxaligncenter');
-    echo '<br><div class="alert alert-' . $type . '">' . $message . '</div>';
+    echo '<br><div class="alert alert-'.$type.'">'.$message.'</div>';
     echo $OUTPUT->box_end();
 }
 
@@ -104,7 +104,7 @@ 
     }
     $typeprofiles = bigbluebuttonbn_get_instance_type_profiles();
     $enabledfeatures = bigbluebuttonbn_get_enabled_features($typeprofiles, $type);
-    $pinginterval = (int)\mod_bigbluebuttonbn\locallib\config::get('waitformoderator_ping_interval') * 1000;
+    $pinginterval = (int) \mod_bigbluebuttonbn\locallib\config::get('waitformoderator_ping_interval') * 1000;
     // JavaScript for locales.
     $PAGE->requires->strings_for_js(array_keys(bigbluebuttonbn_get_strings_for_js()), 'bigbluebuttonbn');
     // JavaScript variables.
@@ -375,10 +375,10 @@ 
         return '';
     }
     return bigbluebuttonbn_render_warning(
-        (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_message'),
-        (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_box_type'),
-        (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_href'),
-        (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_text'),
-        (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_class')
+        (string) \mod_bigbluebuttonbn\locallib\config::get('general_warning_message'),
+        (string) \mod_bigbluebuttonbn\locallib\config::get('general_warning_box_type'),
+        (string) \mod_bigbluebuttonbn\locallib\config::get('general_warning_button_href'),
+        (string) \mod_bigbluebuttonbn\locallib\config::get('general_warning_button_text'),
+        (string) \mod_bigbluebuttonbn\locallib\config::get('general_warning_button_class')
     );
 }

lib.php

Spacing +12 added lines, -12 removed lines

@@ -261,7 +261,7 @@ 
     // Update a record.
     $DB->update_record('bigbluebuttonbn', $bigbluebuttonbn);
     // Get the meetingid column in the bigbluebuttonbn table.
-    $bigbluebuttonbn->meetingid = (string)$DB->get_field('bigbluebuttonbn', 'meetingid', array('id' => $bigbluebuttonbn->id));
+    $bigbluebuttonbn->meetingid = (string) $DB->get_field('bigbluebuttonbn', 'meetingid', array('id' => $bigbluebuttonbn->id));
     // Log update action.
     bigbluebuttonbn_log($bigbluebuttonbn, BIGBLUEBUTTONBN_LOG_EVENT_EDIT);
     // Complete the process.
@@ -315,9 +315,9 @@ 
 function bigbluebuttonbn_delete_instance_log($bigbluebuttonbn) {
     global $DB;
     $sql  = "SELECT * FROM {bigbluebuttonbn_logs} ";
-    $sql .= "WHERE bigbluebuttonbnid = ? AND log = ? AND ". $DB->sql_compare_text('meta') . " = ?";
+    $sql .= "WHERE bigbluebuttonbnid = ? AND log = ? AND ".$DB->sql_compare_text('meta')." = ?";
     $logs = $DB->get_records_sql($sql, array($bigbluebuttonbn->id, BIGBLUEBUTTONBN_LOG_EVENT_CREATE, "{\"record\":true}"));
-    $meta = "{\"has_recordings\":" . empty($logs) ? "true" : "false" . "}";
+    $meta = "{\"has_recordings\":".empty($logs) ? "true" : "false"."}";
     bigbluebuttonbn_log($bigbluebuttonbn, BIGBLUEBUTTONBN_LOG_EVENT_DELETE, [], $meta);
 }
 
@@ -335,8 +335,8 @@ 
  */
 function bigbluebuttonbn_user_outline($course, $user, $mod, $bigbluebuttonbn) {
     if ($completed = bigbluebuttonbn_user_complete($course, $user, $bigbluebuttonbn)) {
-        return fullname($user) . ' ' . get_string('view_message_has_joined', 'bigbluebuttonbn') . ' ' .
-            get_string('view_message_session_for', 'bigbluebuttonbn') . ' ' . (string) $completed . ' ' .
+        return fullname($user).' '.get_string('view_message_has_joined', 'bigbluebuttonbn').' '.
+            get_string('view_message_session_for', 'bigbluebuttonbn').' '.(string) $completed.' '.
             get_string('view_message_times', 'bigbluebuttonbn');
     }
     return '';
@@ -357,12 +357,12 @@ 
     if (is_object($courseorid)) {
         $course = $courseorid;
     } else {
-        $course = (object)array('id' => $courseorid);
+        $course = (object) array('id' => $courseorid);
     }
     if (is_object($userorid)) {
         $user = $userorid;
     } else {
-        $user = (object)array('id' => $userorid);
+        $user = (object) array('id' => $userorid);
     }
     $sql = "SELECT COUNT(*) FROM {bigbluebuttonbn_logs} ";
     $sql .= "WHERE courseid = ? AND bigbluebuttonbnid = ? AND userid = ? AND (log = ? OR log = ?)";
@@ -388,7 +388,7 @@ 
 function bigbluebuttonbn_reset_course_items() {
     $items = array("events" => 0, "tags" => 0, "logs" => 0);
     // Include recordings only if enabled.
-    if ((boolean)\mod_bigbluebuttonbn\locallib\config::recordings_enabled()) {
+    if ((boolean) \mod_bigbluebuttonbn\locallib\config::recordings_enabled()) {
         $items["recordings"] = 0;
     }
     return $items;
@@ -694,7 +694,7 @@ 
 function bigbluebuttonbn_process_pre_save_instance(&$bigbluebuttonbn) {
     require_once(__DIR__.'/locallib.php');
     $bigbluebuttonbn->timemodified = time();
-    if ((integer)$bigbluebuttonbn->instance == 0) {
+    if ((integer) $bigbluebuttonbn->instance == 0) {
         $bigbluebuttonbn->meetingid = 0;
         $bigbluebuttonbn->timecreated = time();
         $bigbluebuttonbn->timemodified = 0;
@@ -1130,7 +1130,7 @@ 
 ) {
     global $CFG, $DB;
 
-    require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+    require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
     // Get mod info.
     $cm = get_fast_modinfo($event->courseid)->instances['bigbluebuttonbn'][$event->instance];
@@ -1208,7 +1208,7 @@ 
 function bigbluebuttonbn_extend_settings_navigation(settings_navigation $settingsnav, navigation_node $nodenav) {
     global $PAGE, $USER;
     // Don't add validate completion if the callback for meetingevents is NOT enabled.
-    if (!(boolean)\mod_bigbluebuttonbn\locallib\config::get('meetingevents_enabled')) {
+    if (!(boolean) \mod_bigbluebuttonbn\locallib\config::get('meetingevents_enabled')) {
         return;
     }
     // Don't add validate completion if user is not allowed to edit the activity.
@@ -1216,7 +1216,7 @@ 
     if (!has_capability('moodle/course:manageactivities', $context, $USER->id)) {
         return;
     }
-    $completionvalidate = '#action=completion_validate&bigbluebuttonbn=' . $PAGE->cm->instance;
+    $completionvalidate = '#action=completion_validate&bigbluebuttonbn='.$PAGE->cm->instance;
     $nodenav->add(get_string('completionvalidatestate', 'bigbluebuttonbn'),
         $completionvalidate, navigation_node::TYPE_CONTAINER);
 }

Doc Comments +4 added lines, -4 removed lines

@@ -103,7 +103,7 @@ 
  * @uses FEATURE_GRADE_OUTCOMES
  * @uses FEATURE_SHOW_DESCRIPTION
  * @param string $feature
- * @return mixed True if yes (some features may use other values)
+ * @return null|boolean True if yes (some features may use other values)
  */
 function bigbluebuttonbn_supports($feature) {
     if (!$feature) {
@@ -310,7 +310,7 @@ 
  *
  * @param object $bigbluebuttonbn Id of the module instance
  *
- * @return bool Success/Failure
+ * @return boolean|null Success/Failure
  */
 function bigbluebuttonbn_delete_instance_log($bigbluebuttonbn) {
     global $DB;
@@ -331,7 +331,7 @@ 
  * @param object $mod
  * @param object $bigbluebuttonbn
  *
- * @return bool
+ * @return string
  */
 function bigbluebuttonbn_user_outline($course, $user, $mod, $bigbluebuttonbn) {
     if ($completed = bigbluebuttonbn_user_complete($course, $user, $bigbluebuttonbn)) {
@@ -917,7 +917,7 @@ 
  * @param stdClass $context       context object
  * @param string   $filearea      file area
  *
- * @return false|null false if file not valid
+ * @return boolean false if file not valid
  */
 function bigbluebuttonbn_pluginfile_valid($context, $filearea) {
 

Indentation +4 added lines, -4 removed lines

@@ -356,7 +356,7 @@ 
     $sql = "SELECT COUNT(*) FROM {bigbluebuttonbn_logs} ";
     $sql .= "WHERE courseid = ? AND bigbluebuttonbnid = ? AND userid = ? AND (log = ? OR log = ?)";
     $result = $DB->count_records_sql($sql, array($course->id, $bigbluebuttonbn->id, $user->id,
-                                              BIGBLUEBUTTONBN_LOG_EVENT_JOIN, BIGBLUEBUTTONBN_LOG_EVENT_PLAYED));
+                                                BIGBLUEBUTTONBN_LOG_EVENT_JOIN, BIGBLUEBUTTONBN_LOG_EVENT_PLAYED));
     return $result;
 }
 
@@ -589,12 +589,12 @@ 
     $str  = '<div class="bigbluebuttonbn overview">'."\n";
     $str .= '  <div class="name">'.get_string('modulename', 'bigbluebuttonbn').':&nbsp;'."\n";
     $str .= '    <a '.$classes.'href="'.$CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bigbluebuttonbn->coursemodule.
-      '">'.$bigbluebuttonbn->name.'</a>'."\n";
+        '">'.$bigbluebuttonbn->name.'</a>'."\n";
     $str .= '  </div>'."\n";
     $str .= '  <div class="info">'.get_string($start, 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->openingtime).
         '</div>'."\n";
     $str .= '  <div class="info">'.get_string('ends_at', 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->closingtime)
-      .'</div>'."\n";
+        .'</div>'."\n";
     $str .= '</div>'."\n";
     return $str;
 }
@@ -836,7 +836,7 @@ 
             'bigbluebuttonbn',
             $bigbluebuttonbn->id,
             $bigbluebuttonbn->completionexpected
-          );
+            );
     }
 }
 

classes/task/send_notification.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * Class containing the scheduled task for lti module.

classes/locallib/notifier.php

Spacing +3 added lines, -3 removed lines

@@ -27,7 +27,7 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * Helper class for sending notifications.
@@ -115,7 +115,7 @@ 
      */
     public static function htmlmsg_recording_ready($bigbluebuttonbn) {
         return '<p>'.get_string('email_body_recording_ready_for', 'bigbluebuttonbn').
-            ' &quot;' . $bigbluebuttonbn->name . '&quot; '.
+            ' &quot;'.$bigbluebuttonbn->name.'&quot; '.
             get_string('email_body_recording_ready_is_ready', 'bigbluebuttonbn').'.</p>';
     }
 
@@ -158,7 +158,7 @@ 
                     // Enqueue it.
                     \core\task\manager::queue_adhoc_task($task);
                 } catch (Exception $e) {
-                    mtrace("Error while enqueuing completion_uopdate_state task. " . (string) $e);
+                    mtrace("Error while enqueuing completion_uopdate_state task. ".(string) $e);
                 }
             }
         }

Doc Comments +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
      *
      * @param object $bigbluebuttonbn
      *
-     * @return void
+     * @return string
      */
     public static function htmlmsg_recording_ready($bigbluebuttonbn) {
         return '<p>'.get_string('email_body_recording_ready_for', 'bigbluebuttonbn').

locallib.php

Doc Comments +14 added lines, -14 removed lines

@@ -317,7 +317,7 @@ 
  * Helper function to retrieve imported recordings from the Moodle database.
  * The references are stored as events in bigbluebuttonbn_logs.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  *
@@ -345,7 +345,7 @@ 
 /**
  * Helper function to retrive the default config.xml file.
  *
- * @return string
+ * @return null|SimpleXMLElement
  */
 function bigbluebuttonbn_get_default_config_xml() {
     $xml = bigbluebuttonbn_wrap_xml_load_file(
@@ -427,7 +427,7 @@ 
  * @param object $a
  * @param object $b
  *
- * @return array
+ * @return integer
  */
 function bigbluebuttonbn_recording_build_sorter($a, $b) {
     global $CFG;
@@ -541,7 +541,7 @@ 
  * @param string $data
  * @param string $contenttype
  *
- * @return object
+ * @return null|SimpleXMLElement
  */
 function bigbluebuttonbn_wrap_xml_load_file($url, $method = 'GET', $data = null, $contenttype = 'text/xml') {
     if (extension_loaded('curl')) {
@@ -582,7 +582,7 @@ 
  * @param string $data
  * @param string $contenttype
  *
- * @return object
+ * @return string
  */
 function bigbluebuttonbn_wrap_xml_load_file_curl_request($url, $method = 'GET', $data = null, $contenttype = 'text/xml') {
     global $CFG;
@@ -977,7 +977,7 @@ 
  * @param integer $instance
  * @param integer $voicebridge
  *
- * @return string
+ * @return boolean
  */
 function bigbluebuttonbn_voicebridge_unique($instance, $voicebridge) {
     global $DB;
@@ -1325,7 +1325,7 @@ 
  * @param string $meetingid
  * @param string $configxml
  *
- * @return object
+ * @return null|SimpleXMLElement
  */
 function bigbluebuttonbn_set_config_xml($meetingid, $configxml) {
     $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url') . 'api/setConfigXML?';
@@ -1379,7 +1379,7 @@ 
  * @param array $recording
  * @param array $tools
  *
- * @return array
+ * @return null|stdClass
  */
 function bigbluebuttonbn_get_recording_data_row($bbbsession, $recording, $tools = ['protect', 'publish', 'delete']) {
     if (!bigbluebuttonbn_include_recording_table_row($bbbsession, $recording)) {
@@ -2016,7 +2016,7 @@ 
  *
  * @param array $bbbsession
  * @param array $recording
- * @param object $rowdata
+ * @param stdClass $rowdata
  *
  * @return object
  */
@@ -2211,7 +2211,7 @@ 
  *
  * @param array $bbbsession
  * @param array $recordings
- * @param array $tools
+ * @param string[] $tools
  *
  * @return array
  */
@@ -2292,7 +2292,7 @@ 
  * Helper function to define the sql used for gattering the bigbluebuttonbnids whose meetingids should be included
  * in the getRecordings request considering only those that belong to deleted activities.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  *
@@ -2316,7 +2316,7 @@ 
  * Helper function to define the sql used for gattering the bigbluebuttonbnids whose meetingids should be included
  * in the getRecordings request considering only those that belong to imported recordings.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  *
@@ -2339,7 +2339,7 @@ 
 /**
  * Helper function to get recordings and imported recordings together.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  * @param bool   $includedeleted
@@ -2357,7 +2357,7 @@ 
  * Helper function to retrieve recordings from the BigBlueButton. The references are stored as events
  * in bigbluebuttonbn_logs.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  * @param bool   $includedeleted

Spacing +81 added lines, -81 removed lines

@@ -32,7 +32,7 @@ 
 
 global $CFG;
 
-require_once(__DIR__ . '/lib.php');
+require_once(__DIR__.'/lib.php');
 
 /** @var BIGBLUEBUTTONBN_UPDATE_CACHE boolean set to true indicates that cache has to be updated */
 const BIGBLUEBUTTONBN_UPDATE_CACHE = true;
@@ -145,8 +145,8 @@ 
     $data = null;
     if (!is_null($pname) && !is_null($purl)) {
         $method = 'POST';
-        $data = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='" .
-            $purl . "' /></module></modules>";
+        $data = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='".
+            $purl."' /></module></modules>";
     }
     $xml = bigbluebuttonbn_wrap_xml_load_file($createmeetingurl, $method, $data);
     if ($xml) {
@@ -242,8 +242,8 @@ 
             || defined('BEHAT_UTIL')) {
         // Just return the fake recording.
         global $CFG;
-        require_once($CFG->libdir . '/testing/generator/lib.php');
-        require_once(__DIR__ . '/tests/generator/lib.php');
+        require_once($CFG->libdir.'/testing/generator/lib.php');
+        require_once(__DIR__.'/tests/generator/lib.php');
         return mod_bigbluebuttonbn_generator::bigbluebuttonbn_get_recordings_array_fetch($meetingidsarray);
     }
     $recordings = array();
@@ -420,7 +420,7 @@ 
         if (is_object($value)) {
             $value = '';
         }
-        $metadataarray['meta_' . $key] = $value;
+        $metadataarray['meta_'.$key] = $value;
     }
     return $metadataarray;
 }
@@ -560,7 +560,7 @@ 
             return $xml;
         } catch (Exception $e) {
             libxml_use_internal_errors($previous);
-            $error = 'Caught exception: ' . $e->getMessage();
+            $error = 'Caught exception: '.$e->getMessage();
             debugging($error, DEBUG_DEVELOPER);
             return null;
         }
@@ -571,7 +571,7 @@ 
         $response = simplexml_load_file($url, 'SimpleXMLElement', LIBXML_NOCDATA | LIBXML_NOBLANKS);
         return $response;
     } catch (Exception $e) {
-        $error = 'Caught exception: ' . $e->getMessage();
+        $error = 'Caught exception: '.$e->getMessage();
         debugging($error, DEBUG_DEVELOPER);
         libxml_use_internal_errors($previous);
         return null;
@@ -590,7 +590,7 @@ 
  */
 function bigbluebuttonbn_wrap_xml_load_file_curl_request($url, $method = 'GET', $data = null, $contenttype = 'text/xml') {
     global $CFG;
-    require_once($CFG->libdir . '/filelib.php');
+    require_once($CFG->libdir.'/filelib.php');
     $c = new curl();
     $c->setopt(array('SSL_VERIFYPEER' => true));
     if ($method == 'POST') {
@@ -599,8 +599,8 @@ 
         }
         $options = array();
         $options['CURLOPT_HTTPHEADER'] = array(
-            'Content-Type: ' . $contenttype,
-            'Content-Length: ' . strlen($data),
+            'Content-Type: '.$contenttype,
+            'Content-Length: '.strlen($data),
             'Content-Language: en-US',
         );
 
@@ -621,7 +621,7 @@ 
  * @return void
  */
 function bigbluebuttonbn_end_meeting_if_running($bigbluebuttonbn) {
-    $meetingid = $bigbluebuttonbn->meetingid . '-' . $bigbluebuttonbn->course . '-' . $bigbluebuttonbn->id;
+    $meetingid = $bigbluebuttonbn->meetingid.'-'.$bigbluebuttonbn->course.'-'.$bigbluebuttonbn->id;
     if (bigbluebuttonbn_is_meeting_running($meetingid)) {
         bigbluebuttonbn_end_meeting($meetingid, $bigbluebuttonbn->moderatorpass);
     }
@@ -641,9 +641,9 @@ 
     if ($userroles) {
         $where = '';
         foreach ($userroles as $userrole) {
-            $where .= (empty($where) ? ' WHERE' : ' OR') . ' id=' . $userrole->roleid;
+            $where .= (empty($where) ? ' WHERE' : ' OR').' id='.$userrole->roleid;
         }
-        $userroles = $DB->get_records_sql('SELECT * FROM {role}' . $where);
+        $userroles = $DB->get_records_sql('SELECT * FROM {role}'.$where);
     }
     return $userroles;
 }
@@ -988,9 +988,9 @@ 
     if ($voicebridge == 0) {
         return true;
     }
-    $select = 'voicebridge = ' . $voicebridge;
+    $select = 'voicebridge = '.$voicebridge;
     if ($instance != 0) {
-        $select .= ' AND id <>' . $instance;
+        $select .= ' AND id <>'.$instance;
     }
     if (!$DB->get_records_select('bigbluebuttonbn', $select)) {
         return true;
@@ -1126,7 +1126,7 @@ 
 function bigbluebuttonbn_generate_nonce() {
     $mt = microtime();
     $rand = mt_rand();
-    return md5($mt . $rand);
+    return md5($mt.$rand);
 }
 
 /**
@@ -1174,7 +1174,7 @@ 
         $params['other'] = $options['other'];
     }
     $event = call_user_func_array(
-        '\mod_bigbluebuttonbn\event\\' . $type . '::create',
+        '\mod_bigbluebuttonbn\event\\'.$type.'::create',
         array($params)
     );
     $event->add_record_snapshot('course_modules', $cm);
@@ -1332,7 +1332,7 @@ 
  * @return object
  */
 function bigbluebuttonbn_set_config_xml($meetingid, $configxml) {
-    $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url') . 'api/setConfigXML?';
+    $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url').'api/setConfigXML?';
     $configxmlparams = bigbluebuttonbn_set_config_xml_params($meetingid, $configxml);
     $xml = bigbluebuttonbn_wrap_xml_load_file(
         $urldefaultconfig,
@@ -1352,9 +1352,9 @@ 
  * @return string
  */
 function bigbluebuttonbn_set_config_xml_params($meetingid, $configxml) {
-    $params = 'configXML=' . urlencode($configxml) . '&meetingID=' . urlencode($meetingid);
+    $params = 'configXML='.urlencode($configxml).'&meetingID='.urlencode($meetingid);
     $sharedsecret = \mod_bigbluebuttonbn\locallib\config::get('shared_secret');
-    $configxmlparams = $params . '&checksum=' . sha1('setConfigXML' . $params . $sharedsecret);
+    $configxmlparams = $params.'&checksum='.sha1('setConfigXML'.$params.$sharedsecret);
     return $configxmlparams;
 }
 
@@ -1460,7 +1460,7 @@ 
     global $USER;
     $starttime = $starttime - ($starttime % 1000);
     // Set formatted date.
-    $dateformat = get_string('strftimerecentfull', 'langconfig') . ' %Z';
+    $dateformat = get_string('strftimerecentfull', 'langconfig').' %Z';
     return userdate($starttime / 1000, $dateformat, usertimezone($USER->timezone));
 }
 
@@ -1508,11 +1508,11 @@ 
         $actionbar .= bigbluebuttonbn_actionbar_render_button($recording, $buttonpayload);
     }
     $head = html_writer::start_tag('div', array(
-        'id' => 'recording-actionbar-' . $recording['recordID'],
+        'id' => 'recording-actionbar-'.$recording['recordID'],
         'data-recordingid' => $recording['recordID'],
         'data-meetingid' => $recording['meetingID']));
     $tail = html_writer::end_tag('div');
-    return $head . $actionbar . $tail;
+    return $head.$actionbar.$tail;
 }
 
 /**
@@ -1576,7 +1576,7 @@ 
  * @return string
  */
 function bigbluebuttonbn_get_recording_data_row_preview($recording) {
-    $options = array('id' => 'preview-' . $recording['recordID']);
+    $options = array('id' => 'preview-'.$recording['recordID']);
     if ($recording['published'] === 'false') {
         $options['hidden'] = 'hidden';
     }
@@ -1609,7 +1609,7 @@ 
         $recordingpreview .= html_writer::start_tag('div', array('class' => ''));
         $recordingpreview .= html_writer::empty_tag(
             'img',
-            array('src' => trim($image['url']) . '?' . time(), 'class' => 'recording-thumbnail pull-left')
+            array('src' => trim($image['url']).'?'.time(), 'class' => 'recording-thumbnail pull-left')
         );
         $recordingpreview .= html_writer::end_tag('div');
     }
@@ -1644,7 +1644,7 @@ 
     if ($recording['published'] === 'false') {
         $visibility = 'hidden ';
     }
-    $id = 'playbacks-' . $recording['recordID'];
+    $id = 'playbacks-'.$recording['recordID'];
     $recordingtypes = html_writer::start_tag('div', array('id' => $id, 'data-imported' => $dataimported,
         'data-meetingid' => $recording['meetingID'], 'data-recordingid' => $recording['recordID'],
         'title' => $title, $visibility => $visibility));
@@ -1670,13 +1670,13 @@ 
         return '';
     }
     $text = bigbluebuttonbn_get_recording_type_text($playback['type']);
-    $href = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=play&bn=' . $bbbsession['bigbluebuttonbn']->id .
-        '&mid=' . $recording['meetingID'] . '&rid=' . $recording['recordID'] . '&rtype=' . $playback['type'];
+    $href = $CFG->wwwroot.'/mod/bigbluebuttonbn/bbb_view.php?action=play&bn='.$bbbsession['bigbluebuttonbn']->id.
+        '&mid='.$recording['meetingID'].'&rid='.$recording['recordID'].'&rtype='.$playback['type'];
     if (!isset($recording['imported']) || !isset($recording['protected']) || $recording['protected'] === 'false') {
-        $href .= '&href=' . urlencode(trim($playback['url']));
+        $href .= '&href='.urlencode(trim($playback['url']));
     }
     $linkattributes = array(
-        'id' => 'recording-play-' . $playback['type'] . '-' . $recording['recordID'],
+        'id' => 'recording-play-'.$playback['type'].'-'.$recording['recordID'],
         'class' => 'btn btn-sm btn-default',
         'onclick' => 'M.mod_bigbluebuttonbn.recordings.recordingPlay(this);',
         'data-action' => 'play',
@@ -1688,7 +1688,7 @@ 
         $linkattributes['title'] = get_string('view_recording_format_errror_unreachable', 'bigbluebuttonbn');
         unset($linkattributes['data-href']);
     }
-    return $OUTPUT->action_link('#', $text, null, $linkattributes) . '&#32;';
+    return $OUTPUT->action_link('#', $text, null, $linkattributes).'&#32;';
 }
 
 /**
@@ -1701,7 +1701,7 @@ 
 function bigbluebuttonbn_get_recording_type_text($playbacktype) {
     // Check first if string exists, and if it does'nt just default to the capitalised version of the string.
     $text = ucwords($playbacktype);
-    $typestringid = 'view_recording_format_' . $playbacktype;
+    $typestringid = 'view_recording_format_'.$playbacktype;
     if (get_string_manager()->string_exists($typestringid, 'bigbluebuttonbn')) {
         $text = get_string($typestringid, 'bigbluebuttonbn');
     }
@@ -1731,7 +1731,7 @@ 
     $validatedurls[$urlhost] = true;
     $curlinfo = bigbluebuttonbn_wrap_xml_load_file_curl_request($url, 'HEAD');
     if (!isset($curlinfo['http_code']) || $curlinfo['http_code'] != 200) {
-        $error = "Resources hosted by " . $urlhost . " are unreachable. Server responded with code " . $curlinfo['http_code'];
+        $error = "Resources hosted by ".$urlhost." are unreachable. Server responded with code ".$curlinfo['http_code'];
         debugging($error, DEBUG_DEVELOPER);
         $validatedurls[$urlhost] = false;
     }
@@ -1822,12 +1822,12 @@ 
  * @return string
  */
 function bigbluebuttonbn_get_recording_data_row_text($recording, $text, $source, $data) {
-    $htmltext = '<span>' . htmlentities($text) . '</span>';
+    $htmltext = '<span>'.htmlentities($text).'</span>';
     if (empty($data)) {
         return $htmltext;
     }
-    $target = $data['action'] . '-' . $data['target'];
-    $id = 'recording-' . $target . '-' . $data['recordingid'];
+    $target = $data['action'].'-'.$data['target'];
+    $id = 'recording-'.$target.'-'.$data['recordingid'];
     $attributes = array('id' => $id, 'class' => 'quickeditlink col-md-20',
         'data-recordingid' => $data['recordingid'], 'data-meetingid' => $data['meetingid'],
         'data-target' => $data['target'], 'data-source' => $source);
@@ -1835,7 +1835,7 @@ 
     $tail = html_writer::end_tag('div');
     $payload = array('action' => $data['action'], 'tag' => $data['tag'], 'target' => $data['target']);
     $htmllink = bigbluebuttonbn_actionbar_render_button($recording, $payload);
-    return $head . $htmltext . $htmllink . $tail;
+    return $head.$htmltext.$htmllink.$tail;
 }
 
 /**
@@ -1853,10 +1853,10 @@ 
     }
     $target = $data['action'];
     if (isset($data['target'])) {
-        $target .= '-' . $data['target'];
+        $target .= '-'.$data['target'];
     }
-    $id = 'recording-' . $target . '-' . $recording['recordID'];
-    $onclick = 'M.mod_bigbluebuttonbn.recordings.recording' . ucfirst($data['action']) . '(this); return false;';
+    $id = 'recording-'.$target.'-'.$recording['recordID'];
+    $onclick = 'M.mod_bigbluebuttonbn.recordings.recording'.ucfirst($data['action']).'(this); return false;';
     if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recording_icons_enabled')) {
         // With icon for $manageaction.
         $iconattributes = array('id' => $id, 'class' => 'iconsmall');
@@ -1871,13 +1871,13 @@ 
             );
         }
         if (isset($data['disabled'])) {
-            $iconattributes['class'] .= ' fa-' . $data['disabled'];
+            $iconattributes['class'] .= ' fa-'.$data['disabled'];
             $linkattributes['class'] = 'disabled';
             unset($linkattributes['onclick']);
         }
         $icon = new pix_icon(
-            'i/' . $data['tag'],
-            get_string('view_recording_list_actionbar_' . $data['action'], 'bigbluebuttonbn'),
+            'i/'.$data['tag'],
+            get_string('view_recording_list_actionbar_'.$data['action'], 'bigbluebuttonbn'),
             'moodle',
             $iconattributes
         );
@@ -1917,7 +1917,7 @@ 
     if ($bbbsession['managerecordings']) {
         $table->head[] = get_string('view_recording_actionbar', 'bigbluebuttonbn');
         $table->align[] = 'left';
-        $table->size[] = (count($tools) * 40) . 'px';
+        $table->size[] = (count($tools) * 40).'px';
     }
     // Get the groups of the user.
     $usergroups = groups_get_all_groups($bbbsession['course']->id, $bbbsession['userID']);
@@ -1972,7 +1972,7 @@ 
  */
 function bigbluebuttonbn_get_recording_table_row($bbbsession, $recording, $rowdata) {
     $row = new html_table_row();
-    $row->id = 'recording-tr-' . $recording['recordID'];
+    $row->id = 'recording-tr-'.$recording['recordID'];
     $row->attributes['data-imported'] = 'false';
     $texthead = '';
     $texttail = '';
@@ -1984,13 +1984,13 @@ 
     }
     $rowdata->date_formatted = str_replace(' ', '&nbsp;', $rowdata->date_formatted);
     $row->cells = array();
-    $row->cells[] = $texthead . $rowdata->playback . $texttail;
-    $row->cells[] = $texthead . $rowdata->recording . $texttail;
-    $row->cells[] = $texthead . $rowdata->description . $texttail;
+    $row->cells[] = $texthead.$rowdata->playback.$texttail;
+    $row->cells[] = $texthead.$rowdata->recording.$texttail;
+    $row->cells[] = $texthead.$rowdata->description.$texttail;
     if (bigbluebuttonbn_get_recording_data_preview_enabled($bbbsession)) {
         $row->cells[] = $rowdata->preview;
     }
-    $row->cells[] = $texthead . $rowdata->date_formatted . $texttail;
+    $row->cells[] = $texthead.$rowdata->date_formatted.$texttail;
     $row->cells[] = $rowdata->duration_formatted;
     if ($bbbsession['managerecordings']) {
         $row->cells[] = $rowdata->actionbar;
@@ -2116,7 +2116,7 @@ 
         // Enqueue it.
         \core\task\manager::queue_adhoc_task($task);
     } catch (Exception $e) {
-        mtrace("Error while enqueuing completion_update_state task. " . (string) $e);
+        mtrace("Error while enqueuing completion_update_state task. ".(string) $e);
     }
 }
 
@@ -2186,7 +2186,7 @@ 
     }
     $coursesforselect = [];
     foreach ($courses as $course) {
-        $coursesforselect[$course->id] = $course->fullname . " (" . $course->shortname . ")";
+        $coursesforselect[$course->id] = $course->fullname." (".$course->shortname.")";
     }
     return $coursesforselect;
 }
@@ -2284,17 +2284,17 @@ 
  * @return string containing the sql used for getting the target bigbluebuttonbn instances
  */
 function bigbluebuttonbn_get_recordings_deleted_sql_select($courseid = 0, $bigbluebuttonbnid = null, $subset = true) {
-    $sql = "log = '" . BIGBLUEBUTTONBN_LOG_EVENT_DELETE . "' AND meta like '%has_recordings%' AND meta like '%true%'";
+    $sql = "log = '".BIGBLUEBUTTONBN_LOG_EVENT_DELETE."' AND meta like '%has_recordings%' AND meta like '%true%'";
     if (empty($courseid)) {
         $courseid = 0;
     }
     if (empty($bigbluebuttonbnid)) {
-        return $sql . " AND courseid = {$courseid}";
+        return $sql." AND courseid = {$courseid}";
     }
     if ($subset) {
-        return $sql . " AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'";
+        return $sql." AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'";
     }
-    return $sql . " AND courseid = {$courseid} AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'";
+    return $sql." AND courseid = {$courseid} AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'";
 }
 
 /**
@@ -2308,17 +2308,17 @@ 
  * @return string containing the sql used for getting the target bigbluebuttonbn instances
  */
 function bigbluebuttonbn_get_recordings_imported_sql_select($courseid = 0, $bigbluebuttonbnid = null, $subset = true) {
-    $sql = "log = '" . BIGBLUEBUTTONBN_LOG_EVENT_IMPORT . "'";
+    $sql = "log = '".BIGBLUEBUTTONBN_LOG_EVENT_IMPORT."'";
     if (empty($courseid)) {
         $courseid = 0;
     }
     if (empty($bigbluebuttonbnid)) {
-        return $sql . " AND courseid = '{$courseid}'";
+        return $sql." AND courseid = '{$courseid}'";
     }
     if ($subset) {
-        return $sql . " AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'";
+        return $sql." AND bigbluebuttonbnid = '{$bigbluebuttonbnid}'";
     }
-    return $sql . " AND courseid = '{$courseid}' AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'";
+    return $sql." AND courseid = '{$courseid}' AND bigbluebuttonbnid <> '{$bigbluebuttonbnid}'";
 }
 
 /**
@@ -2377,7 +2377,7 @@ 
     }
     // Prepare select for loading records based on existent bigbluebuttonbns.
     $sql = 'SELECT DISTINCT meetingid, bigbluebuttonbnid FROM {bigbluebuttonbn_logs} WHERE ';
-    $sql .= '(bigbluebuttonbnid=' . implode(' OR bigbluebuttonbnid=', array_keys($bigbluebuttonbns)) . ')';
+    $sql .= '(bigbluebuttonbnid='.implode(' OR bigbluebuttonbnid=', array_keys($bigbluebuttonbns)).')';
     // Include only Create events and exclude those with record not true.
     $sql .= ' AND log = ? AND meta LIKE ? AND meta LIKE ?';
     // Execute select for loading records based on existent bigbluebuttonbns.
@@ -2562,8 +2562,8 @@ 
     require_once($CFG->dirroot.'/calendar/lib.php');
     $activitytime = '';
     if ($time) {
-        $activitytime = calendar_day_representation($time) . ' ' .
-        get_string('mod_form_field_notification_msg_at', 'bigbluebuttonbn') . ' ' .
+        $activitytime = calendar_day_representation($time).' '.
+        get_string('mod_form_field_notification_msg_at', 'bigbluebuttonbn').' '.
         calendar_time_representation($time);
     }
     return $activitytime;
@@ -3116,16 +3116,16 @@ 
         return $output;
     }
     $output .= $OUTPUT->box_start(
-        'box boxalignleft adminerror alert alert-' . $type . ' alert-block fade in',
+        'box boxalignleft adminerror alert alert-'.$type.' alert-block fade in',
         'bigbluebuttonbn_view_general_warning'
-    ) . "\n";
-    $output .= '    ' . $message . "\n";
-    $output .= '  <div class="singlebutton pull-right">' . "\n";
+    )."\n";
+    $output .= '    '.$message."\n";
+    $output .= '  <div class="singlebutton pull-right">'."\n";
     if (!empty($href)) {
         $output .= bigbluebuttonbn_render_warning_button($href, $text, $class);
     }
-    $output .= '  </div>' . "\n";
-    $output .= $OUTPUT->box_end() . "\n";
+    $output .= '  </div>'."\n";
+    $output .= $OUTPUT->box_end()."\n";
     return $output;
 }
 
@@ -3149,11 +3149,11 @@ 
     if ($class == '') {
         $class = 'btn btn-secondary';
     }
-    $output = '  <form method="post" action="' . $href . '" class="form-inline">' . "\n";
-    $output .= '      <button type="submit" class="' . $class . '"' . "\n";
-    $output .= '          title="' . $title . '"' . "\n";
-    $output .= '          >' . $text . '</button>' . "\n";
-    $output .= '  </form>' . "\n";
+    $output = '  <form method="post" action="'.$href.'" class="form-inline">'."\n";
+    $output .= '      <button type="submit" class="'.$class.'"'."\n";
+    $output .= '          title="'.$title.'"'."\n";
+    $output .= '          >'.$text.'</button>'."\n";
+    $output .= '  </form>'."\n";
     return $output;
 }
 
@@ -3217,7 +3217,7 @@ 
 function bigbluebuttonbn_user_can_join_meeting($bigbluebuttonbn, $mid = null, $userid = null) {
     // By default, use a meetingid without groups.
     if (empty($mid)) {
-        $mid = $bigbluebuttonbn->meetingid . '-' . $bigbluebuttonbn->course . '-' . $bigbluebuttonbn->id;
+        $mid = $bigbluebuttonbn->meetingid.'-'.$bigbluebuttonbn->course.'-'.$bigbluebuttonbn->id;
     }
     // When meeting is running, all authorized users can join right in.
     if (bigbluebuttonbn_is_meeting_running($mid)) {
@@ -3286,7 +3286,7 @@ 
  * @return boolean
  */
 function bigbluebuttonbn_has_html5_client() {
-    $checkurl = \mod_bigbluebuttonbn\locallib\bigbluebutton::root() . "html5client/check";
+    $checkurl = \mod_bigbluebuttonbn\locallib\bigbluebutton::root()."html5client/check";
     $curlinfo = bigbluebuttonbn_wrap_xml_load_file_curl_request($checkurl, 'HEAD');
     return (isset($curlinfo['http_code']) && $curlinfo['http_code'] == 200);
 }
@@ -3314,7 +3314,7 @@ 
     $bbbsession['modPW'] = $bbbsession['bigbluebuttonbn']->moderatorpass;
     $bbbsession['viewerPW'] = $bbbsession['bigbluebuttonbn']->viewerpass;
     // Database info related to the activity.
-    $bbbsession['meetingid'] = $bbbsession['bigbluebuttonbn']->meetingid . '-' . $bbbsession['course']->id . '-' .
+    $bbbsession['meetingid'] = $bbbsession['bigbluebuttonbn']->meetingid.'-'.$bbbsession['course']->id.'-'.
     $bbbsession['bigbluebuttonbn']->id;
     $bbbsession['meetingname'] = $bbbsession['bigbluebuttonbn']->name;
     $bbbsession['meetingdescription'] = $bbbsession['bigbluebuttonbn']->intro;
@@ -3346,12 +3346,12 @@ 
     if ($bbbsession['bigbluebuttonbn']->record) {
         // Check if is enable record all from start.
         if ($bbbsession['recordallfromstart']) {
-            $bbbsession['welcome'] .= '<br><br>' . get_string(
+            $bbbsession['welcome'] .= '<br><br>'.get_string(
                 'bbbrecordallfromstartwarning',
                 'bigbluebuttonbn'
             );
         } else {
-            $bbbsession['welcome'] .= '<br><br>' . get_string('bbbrecordwarning', 'bigbluebuttonbn');
+            $bbbsession['welcome'] .= '<br><br>'.get_string('bbbrecordwarning', 'bigbluebuttonbn');
         }
     }
     $bbbsession['openingtime'] = $bbbsession['bigbluebuttonbn']->openingtime;
@@ -3366,7 +3366,7 @@ 
     $bbbsession['originServerName'] = $parsedurl['host'];
     $bbbsession['originServerUrl'] = $CFG->wwwroot;
     $bbbsession['originServerCommonName'] = '';
-    $bbbsession['originTag'] = 'moodle-mod_bigbluebuttonbn (' . get_config('mod_bigbluebuttonbn', 'version') . ')';
+    $bbbsession['originTag'] = 'moodle-mod_bigbluebuttonbn ('.get_config('mod_bigbluebuttonbn', 'version').')';
     $bbbsession['bnserver'] = bigbluebuttonbn_is_bn_server();
     // Setting for clienttype, assign flash if not enabled, or default if not editable.
     $bbbsession['clienttype'] = BIGBLUEBUTTON_CLIENTTYPE_FLASH;
@@ -3473,7 +3473,7 @@ 
     if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recordingstatus_enabled')) {
         $metadata["bn-recording-status"] = json_encode(
             array(
-                'email' => array('"' . fullname($USER) . '" <' . $USER->email . '>'),
+                'email' => array('"'.fullname($USER).'" <'.$USER->email.'>'),
                 'context' => $bbbsession['bigbluebuttonbnURL'],
             )
         );

Indentation +2 added lines, -2 removed lines

@@ -796,7 +796,7 @@ 
     $data['role'] = array(
         'name' => get_string('mod_form_field_participant_list_type_role', 'bigbluebuttonbn'),
         'children' => bigbluebuttonbn_get_roles_select($context, true)
-      );
+        );
     $data['user'] = array(
         'name' => get_string('mod_form_field_participant_list_type_user', 'bigbluebuttonbn'),
         'children' => bigbluebuttonbn_get_users_select($context, $bbactivity),
@@ -1704,7 +1704,7 @@ 
         'data-action' => 'play',
         'data-target' => $playback['type'],
         'data-href' => $href,
-      );
+        );
     if ($CFG->bigbluebuttonbn_recordings_validate_url && !bigbluebuttonbn_is_bn_server() && !bigbluebuttonbn_is_valid_resource(trim($playback['url']))) {
         $linkattributes['class'] = 'btn btn-sm btn-warning';
         $linkattributes['title'] = get_string('view_recording_format_errror_unreachable', 'bigbluebuttonbn');

classes/locallib/bigbluebutton.php

Spacing +7 added lines, -7 removed lines

@@ -27,7 +27,7 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * Wrapper for executing http requests on a BigBlueButton server.
@@ -46,18 +46,18 @@ 
      * @return string
      */
     public static function action_url($action = '', $data = array(), $metadata = array()) {
-        $baseurl = self::sanitized_url() . $action . '?';
+        $baseurl = self::sanitized_url().$action.'?';
         $metadata = array_combine(
             array_map(
                 function($k) {
-                    return 'meta_' . $k;
+                    return 'meta_'.$k;
                 }
                 , array_keys($metadata)
             ),
             $metadata
         );
         $params = http_build_query($data + $metadata, '', '&');
-        return $baseurl . $params . '&checksum=' . sha1($action . $params . self::sanitized_secret());
+        return $baseurl.$params.'&checksum='.sha1($action.$params.self::sanitized_secret());
     }
 
     /**
@@ -73,7 +73,7 @@ 
         if (substr($serverurl, -4) == '/api') {
             $serverurl = rtrim($serverurl, '/api');
         }
-        return $serverurl . '/api/';
+        return $serverurl.'/api/';
     }
 
     /**
@@ -94,8 +94,8 @@ 
         $pserverurl = parse_url(trim(\mod_bigbluebuttonbn\locallib\config::get('server_url')));
         $pserverurlport = "";
         if (isset($pserverurl['port'])) {
-            $pserverurlport = ":" . $pserverurl['port'];
+            $pserverurlport = ":".$pserverurl['port'];
         }
-        return $pserverurl['scheme'] . "://" . $pserverurl['host'] . $pserverurlport . "/";
+        return $pserverurl['scheme']."://".$pserverurl['host'].$pserverurlport."/";
     }
 }