jfederico / moodle-mod_bigbluebuttonbn

classes/event/events.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * The mod_bigbluebuttonbn class for event name definition.

classes/event/activity_viewed.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
      */
     protected function init($crud = 'r', $edulevel = self::LEVEL_PARTICIPATING) {
         parent::init($crud, $edulevel);
-        $this->description = "The user with id '##userid' viewed the bigbluebuttonbn activity " .
+        $this->description = "The user with id '##userid' viewed the bigbluebuttonbn activity ".
             "with id '##objectid' for the course id '##courseid'.";
     }
 

classes/external.php

Spacing +2 added lines, -2 removed lines

@@ -61,7 +61,7 @@ 
      */
     public static function view_bigbluebuttonbn($bigbluebuttonbnid) {
         global $DB, $CFG;
-        require_once($CFG->dirroot . "/mod/bigbluebuttonbn/lib.php");
+        require_once($CFG->dirroot."/mod/bigbluebuttonbn/lib.php");
 
         $params = self::validate_parameters(self::view_bigbluebuttonbn_parameters(),
                                             array(
@@ -109,7 +109,7 @@ 
      * @since Moodle 3.3
      */
     public static function get_bigbluebuttonbns_by_courses_parameters() {
-        return new external_function_parameters (
+        return new external_function_parameters(
             array(
                 'courseids' => new external_multiple_structure(
                     new external_value(PARAM_INT, 'Course id'), 'Array of course ids', VALUE_DEFAULT, array()

classes/settings/renderer.php

Spacing +24 added lines, -24 removed lines

@@ -27,7 +27,7 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 require_once($CFG->libdir.'/adminlib.php');
 
 /**
@@ -63,12 +63,12 @@ 
      */
     public function render_group_header($name, $itemname = null, $itemdescription = null) {
         if ($itemname === null) {
-            $itemname = get_string('config_' . $name, 'bigbluebuttonbn');
+            $itemname = get_string('config_'.$name, 'bigbluebuttonbn');
         }
         if ($itemdescription === null) {
-            $itemdescription = get_string('config_' .$name . '_description', 'bigbluebuttonbn');
+            $itemdescription = get_string('config_'.$name.'_description', 'bigbluebuttonbn');
         }
-        $item = new \admin_setting_heading('bigbluebuttonbn_config_' . $name, $itemname, $itemdescription);
+        $item = new \admin_setting_heading('bigbluebuttonbn_config_'.$name, $itemname, $itemdescription);
         $this->settings->add($item);
     }
 
@@ -97,9 +97,9 @@ 
      * @return Object
      */
     public function render_group_element_text($name, $default = null, $type = PARAM_RAW) {
-        $item = new \admin_setting_configtext('bigbluebuttonbn_' . $name,
-                get_string('config_' . $name, 'bigbluebuttonbn'),
-                get_string('config_' . $name . '_description', 'bigbluebuttonbn'),
+        $item = new \admin_setting_configtext('bigbluebuttonbn_'.$name,
+                get_string('config_'.$name, 'bigbluebuttonbn'),
+                get_string('config_'.$name.'_description', 'bigbluebuttonbn'),
                 $default, $type);
         return $item;
     }
@@ -113,9 +113,9 @@ 
      * @return Object
      */
     public function render_group_element_checkbox($name, $default = null) {
-        $item = new \admin_setting_configcheckbox('bigbluebuttonbn_' . $name,
-                get_string('config_' . $name, 'bigbluebuttonbn'),
-                get_string('config_' . $name . '_description', 'bigbluebuttonbn'),
+        $item = new \admin_setting_configcheckbox('bigbluebuttonbn_'.$name,
+                get_string('config_'.$name, 'bigbluebuttonbn'),
+                get_string('config_'.$name.'_description', 'bigbluebuttonbn'),
                 $default);
         return $item;
     }
@@ -130,9 +130,9 @@ 
      * @return Object
      */
     public function render_group_element_configmultiselect($name, $defaultsetting, $choices) {
-        $item = new \admin_setting_configmultiselect('bigbluebuttonbn_' . $name,
-                get_string('config_' . $name, 'bigbluebuttonbn'),
-                get_string('config_' . $name . '_description', 'bigbluebuttonbn'),
+        $item = new \admin_setting_configmultiselect('bigbluebuttonbn_'.$name,
+                get_string('config_'.$name, 'bigbluebuttonbn'),
+                get_string('config_'.$name.'_description', 'bigbluebuttonbn'),
                 $defaultsetting, $choices);
         return $item;
     }
@@ -147,9 +147,9 @@ 
      * @return Object
      */
     public function render_group_element_configselect($name, $defaultsetting, $choices) {
-        $item = new \admin_setting_configselect('bigbluebuttonbn_' . $name,
-                get_string('config_' . $name, 'bigbluebuttonbn'),
-                get_string('config_' . $name . '_description', 'bigbluebuttonbn'),
+        $item = new \admin_setting_configselect('bigbluebuttonbn_'.$name,
+                get_string('config_'.$name, 'bigbluebuttonbn'),
+                get_string('config_'.$name.'_description', 'bigbluebuttonbn'),
                 $defaultsetting, $choices);
         return $item;
     }
@@ -166,14 +166,14 @@ 
      */
     public function render_warning_message($name, $message, $type = 'warning', $closable = true) {
         global $OUTPUT;
-        $output = $OUTPUT->box_start('box boxalignleft adminerror alert alert-' . $type . ' alert-block fade in',
-            'bigbluebuttonbn_' . $name)."\n";
+        $output = $OUTPUT->box_start('box boxalignleft adminerror alert alert-'.$type.' alert-block fade in',
+            'bigbluebuttonbn_'.$name)."\n";
         if ($closable) {
-            $output .= '  <button type="button" class="close" data-dismiss="alert">&times;</button>' . "\n";
+            $output .= '  <button type="button" class="close" data-dismiss="alert">&times;</button>'."\n";
         }
-        $output .= '  ' . $message . "\n";
-        $output .= $OUTPUT->box_end() . "\n";
-        $item = new \admin_setting_heading('bigbluebuttonbn_' . $name, '', $output);
+        $output .= '  '.$message."\n";
+        $output .= $OUTPUT->box_end()."\n";
+        $item = new \admin_setting_heading('bigbluebuttonbn_'.$name, '', $output);
         $this->settings->add($item);
         return $item;
     }
@@ -195,8 +195,8 @@ 
         $filemanageroptions['mainfile'] = true;
 
         $filemanager = new \admin_setting_configstoredfile('mod_bigbluebuttonbn/presentationdefault',
-            get_string('config_' . $name, 'bigbluebuttonbn'),
-            get_string('config_' . $name . '_description', 'bigbluebuttonbn'),
+            get_string('config_'.$name, 'bigbluebuttonbn'),
+            get_string('config_'.$name.'_description', 'bigbluebuttonbn'),
             'presentationdefault',
             0,
             $filemanageroptions);

classes/settings/validator.php

Indentation +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
                 !isset($CFG->bigbluebuttonbn['recordings_imported_editable']) ||
                 !isset($CFG->bigbluebuttonbn['recordings_preview_default']) ||
                 !isset($CFG->bigbluebuttonbn['recordings_preview_editable'])
-              );
+                );
     }
 
     /**

Spacing +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 require_once($CFG->libdir.'/adminlib.php');
 
 /**
@@ -62,7 +62,7 @@ 
                 !isset($CFG->bigbluebuttonbn['recording_all_from_start_default']) ||
                 !isset($CFG->bigbluebuttonbn['recording_all_from_start_editable']) ||
                 !isset($CFG->bigbluebuttonbn['recording_hide_button_default']) ||
-                !isset($CFG->bigbluebuttonbn['recording_hide_button_editable']) );
+                !isset($CFG->bigbluebuttonbn['recording_hide_button_editable']));
     }
 
     /**

viewlib.php

Spacing +7 added lines, -7 removed lines

@@ -85,7 +85,7 @@ 
         return;
     }
     echo $OUTPUT->box_start('generalbox boxaligncenter');
-    echo '<br><div class="alert alert-' . $type . '">' . $message . '</div>';
+    echo '<br><div class="alert alert-'.$type.'">'.$message.'</div>';
     echo $OUTPUT->box_end();
 }
 
@@ -104,7 +104,7 @@ 
     }
     $typeprofiles = bigbluebuttonbn_get_instance_type_profiles();
     $enabledfeatures = bigbluebuttonbn_get_enabled_features($typeprofiles, $type);
-    $pinginterval = (int)\mod_bigbluebuttonbn\locallib\config::get('waitformoderator_ping_interval') * 1000;
+    $pinginterval = (int) \mod_bigbluebuttonbn\locallib\config::get('waitformoderator_ping_interval') * 1000;
     // JavaScript for locales.
     $PAGE->requires->strings_for_js(array_keys(bigbluebuttonbn_get_strings_for_js()), 'bigbluebuttonbn');
     // JavaScript variables.
@@ -375,10 +375,10 @@ 
         return '';
     }
     return bigbluebuttonbn_render_warning(
-        (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_message'),
-        (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_box_type'),
-        (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_href'),
-        (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_text'),
-        (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_class')
+        (string) \mod_bigbluebuttonbn\locallib\config::get('general_warning_message'),
+        (string) \mod_bigbluebuttonbn\locallib\config::get('general_warning_box_type'),
+        (string) \mod_bigbluebuttonbn\locallib\config::get('general_warning_button_href'),
+        (string) \mod_bigbluebuttonbn\locallib\config::get('general_warning_button_text'),
+        (string) \mod_bigbluebuttonbn\locallib\config::get('general_warning_button_class')
     );
 }

lib.php

Indentation +5 added lines, -5 removed lines

@@ -64,7 +64,7 @@ 
  * Remove this block when restored
  */
 
- /** @var BIGBLUEBUTTONBN_DEFAULT_SERVER_URL string of default bigbluebutton server url */
+    /** @var BIGBLUEBUTTONBN_DEFAULT_SERVER_URL string of default bigbluebutton server url */
 const BIGBLUEBUTTONBN_DEFAULT_SERVER_URL = 'http://test-install.blindsidenetworks.com/bigbluebutton/';
 /** @var BIGBLUEBUTTONBN_DEFAULT_SHARED_SECRET string of default bigbluebutton server shared secret */
 const BIGBLUEBUTTONBN_DEFAULT_SHARED_SECRET = '8cd8ef52e8e101574e400365b55e11a6';
@@ -367,7 +367,7 @@ 
     $sql = "SELECT COUNT(*) FROM {bigbluebuttonbn_logs} ";
     $sql .= "WHERE courseid = ? AND bigbluebuttonbnid = ? AND userid = ? AND (log = ? OR log = ?)";
     $result = $DB->count_records_sql($sql, array($course->id, $bigbluebuttonbn->id, $user->id,
-                                              BIGBLUEBUTTONBN_LOG_EVENT_JOIN, BIGBLUEBUTTONBN_LOG_EVENT_PLAYED));
+                                                BIGBLUEBUTTONBN_LOG_EVENT_JOIN, BIGBLUEBUTTONBN_LOG_EVENT_PLAYED));
     return $result;
 }
 
@@ -598,12 +598,12 @@ 
     $str  = '<div class="bigbluebuttonbn overview">'."\n";
     $str .= '  <div class="name">'.get_string('modulename', 'bigbluebuttonbn').':&nbsp;'."\n";
     $str .= '    <a '.$classes.'href="'.$CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bigbluebuttonbn->coursemodule.
-      '">'.$bigbluebuttonbn->name.'</a>'."\n";
+        '">'.$bigbluebuttonbn->name.'</a>'."\n";
     $str .= '  </div>'."\n";
     $str .= '  <div class="info">'.get_string($start, 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->openingtime).
         '</div>'."\n";
     $str .= '  <div class="info">'.get_string('ends_at', 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->closingtime)
-      .'</div>'."\n";
+        .'</div>'."\n";
     $str .= '</div>'."\n";
     return $str;
 }
@@ -845,7 +845,7 @@ 
             'bigbluebuttonbn',
             $bigbluebuttonbn->id,
             $bigbluebuttonbn->completionexpected
-          );
+            );
     }
 }
 

Spacing +12 added lines, -12 removed lines

@@ -261,7 +261,7 @@ 
     // Update a record.
     $DB->update_record('bigbluebuttonbn', $bigbluebuttonbn);
     // Get the meetingid column in the bigbluebuttonbn table.
-    $bigbluebuttonbn->meetingid = (string)$DB->get_field('bigbluebuttonbn', 'meetingid', array('id' => $bigbluebuttonbn->id));
+    $bigbluebuttonbn->meetingid = (string) $DB->get_field('bigbluebuttonbn', 'meetingid', array('id' => $bigbluebuttonbn->id));
     // Log update action.
     bigbluebuttonbn_log($bigbluebuttonbn, BIGBLUEBUTTONBN_LOG_EVENT_EDIT);
     // Complete the process.
@@ -315,9 +315,9 @@ 
 function bigbluebuttonbn_delete_instance_log($bigbluebuttonbn) {
     global $DB;
     $sql  = "SELECT * FROM {bigbluebuttonbn_logs} ";
-    $sql .= "WHERE bigbluebuttonbnid = ? AND log = ? AND ". $DB->sql_compare_text('meta') . " = ?";
+    $sql .= "WHERE bigbluebuttonbnid = ? AND log = ? AND ".$DB->sql_compare_text('meta')." = ?";
     $logs = $DB->get_records_sql($sql, array($bigbluebuttonbn->id, BIGBLUEBUTTONBN_LOG_EVENT_CREATE, "{\"record\":true}"));
-    $meta = "{\"has_recordings\":" . empty($logs) ? "true" : "false" . "}";
+    $meta = "{\"has_recordings\":".empty($logs) ? "true" : "false"."}";
     bigbluebuttonbn_log($bigbluebuttonbn, BIGBLUEBUTTONBN_LOG_EVENT_DELETE, [], $meta);
 }
 
@@ -335,8 +335,8 @@ 
  */
 function bigbluebuttonbn_user_outline($course, $user, $mod, $bigbluebuttonbn) {
     if ($completed = bigbluebuttonbn_user_complete($course, $user, $bigbluebuttonbn)) {
-        return fullname($user) . ' ' . get_string('view_message_has_joined', 'bigbluebuttonbn') . ' ' .
-            get_string('view_message_session_for', 'bigbluebuttonbn') . ' ' . (string) $completed . ' ' .
+        return fullname($user).' '.get_string('view_message_has_joined', 'bigbluebuttonbn').' '.
+            get_string('view_message_session_for', 'bigbluebuttonbn').' '.(string) $completed.' '.
             get_string('view_message_times', 'bigbluebuttonbn');
     }
     return '';
@@ -357,12 +357,12 @@ 
     if (is_object($courseorid)) {
         $course = $courseorid;
     } else {
-        $course = (object)array('id' => $courseorid);
+        $course = (object) array('id' => $courseorid);
     }
     if (is_object($userorid)) {
         $user = $userorid;
     } else {
-        $user = (object)array('id' => $userorid);
+        $user = (object) array('id' => $userorid);
     }
     $sql = "SELECT COUNT(*) FROM {bigbluebuttonbn_logs} ";
     $sql .= "WHERE courseid = ? AND bigbluebuttonbnid = ? AND userid = ? AND (log = ? OR log = ?)";
@@ -388,7 +388,7 @@ 
 function bigbluebuttonbn_reset_course_items() {
     $items = array("events" => 0, "tags" => 0, "logs" => 0);
     // Include recordings only if enabled.
-    if ((boolean)\mod_bigbluebuttonbn\locallib\config::recordings_enabled()) {
+    if ((boolean) \mod_bigbluebuttonbn\locallib\config::recordings_enabled()) {
         $items["recordings"] = 0;
     }
     return $items;
@@ -694,7 +694,7 @@ 
 function bigbluebuttonbn_process_pre_save_instance(&$bigbluebuttonbn) {
     require_once(__DIR__.'/locallib.php');
     $bigbluebuttonbn->timemodified = time();
-    if ((integer)$bigbluebuttonbn->instance == 0) {
+    if ((integer) $bigbluebuttonbn->instance == 0) {
         $bigbluebuttonbn->meetingid = 0;
         $bigbluebuttonbn->timecreated = time();
         $bigbluebuttonbn->timemodified = 0;
@@ -1130,7 +1130,7 @@ 
 ) {
     global $CFG, $DB;
 
-    require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+    require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
     // Get mod info.
     $cm = get_fast_modinfo($event->courseid)->instances['bigbluebuttonbn'][$event->instance];
@@ -1208,7 +1208,7 @@ 
 function bigbluebuttonbn_extend_settings_navigation(settings_navigation $settingsnav, navigation_node $nodenav) {
     global $PAGE, $USER;
     // Don't add validate completion if the callback for meetingevents is NOT enabled.
-    if (!(boolean)\mod_bigbluebuttonbn\locallib\config::get('meetingevents_enabled')) {
+    if (!(boolean) \mod_bigbluebuttonbn\locallib\config::get('meetingevents_enabled')) {
         return;
     }
     // Don't add validate completion if user is not allowed to edit the activity.
@@ -1216,7 +1216,7 @@ 
     if (!has_capability('moodle/course:manageactivities', $context, $USER->id)) {
         return;
     }
-    $completionvalidate = '#action=completion_validate&bigbluebuttonbn=' . $PAGE->cm->instance;
+    $completionvalidate = '#action=completion_validate&bigbluebuttonbn='.$PAGE->cm->instance;
     $nodenav->add(get_string('completionvalidatestate', 'bigbluebuttonbn'),
         $completionvalidate, navigation_node::TYPE_CONTAINER);
 }

Doc Comments +4 added lines, -4 removed lines

@@ -103,7 +103,7 @@ 
  * @uses FEATURE_GRADE_OUTCOMES
  * @uses FEATURE_SHOW_DESCRIPTION
  * @param string $feature
- * @return mixed True if yes (some features may use other values)
+ * @return null|boolean True if yes (some features may use other values)
  */
 function bigbluebuttonbn_supports($feature) {
     if (!$feature) {
@@ -310,7 +310,7 @@ 
  *
  * @param object $bigbluebuttonbn Id of the module instance
  *
- * @return bool Success/Failure
+ * @return boolean|null Success/Failure
  */
 function bigbluebuttonbn_delete_instance_log($bigbluebuttonbn) {
     global $DB;
@@ -331,7 +331,7 @@ 
  * @param object $mod
  * @param object $bigbluebuttonbn
  *
- * @return bool
+ * @return string
  */
 function bigbluebuttonbn_user_outline($course, $user, $mod, $bigbluebuttonbn) {
     if ($completed = bigbluebuttonbn_user_complete($course, $user, $bigbluebuttonbn)) {
@@ -917,7 +917,7 @@ 
  * @param stdClass $context       context object
  * @param string   $filearea      file area
  *
- * @return false|null false if file not valid
+ * @return boolean false if file not valid
  */
 function bigbluebuttonbn_pluginfile_valid($context, $filearea) {
 

classes/task/send_notification.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * Class containing the scheduled task for lti module.

classes/locallib/notifier.php

Spacing +3 added lines, -3 removed lines

@@ -27,7 +27,7 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * Helper class for sending notifications.
@@ -115,7 +115,7 @@ 
      */
     public static function htmlmsg_recording_ready($bigbluebuttonbn) {
         return '<p>'.get_string('email_body_recording_ready_for', 'bigbluebuttonbn').
-            ' &quot;' . $bigbluebuttonbn->name . '&quot; '.
+            ' &quot;'.$bigbluebuttonbn->name.'&quot; '.
             get_string('email_body_recording_ready_is_ready', 'bigbluebuttonbn').'.</p>';
     }
 
@@ -158,7 +158,7 @@ 
                     // Enqueue it.
                     \core\task\manager::queue_adhoc_task($task);
                 } catch (Exception $e) {
-                    mtrace("Error while enqueuing completion_uopdate_state task. " . (string) $e);
+                    mtrace("Error while enqueuing completion_uopdate_state task. ".(string) $e);
                 }
             }
         }

Doc Comments +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
      *
      * @param object $bigbluebuttonbn
      *
-     * @return void
+     * @return string
      */
     public static function htmlmsg_recording_ready($bigbluebuttonbn) {
         return '<p>'.get_string('email_body_recording_ready_for', 'bigbluebuttonbn').