jfederico / moodle-mod_bigbluebuttonbn

classes/privacy/provider.php

Indentation +6 added lines, -6 removed lines

@@ -59,11 +59,11 @@ 
      */
     public static function _get_metadata(collection $collection) {
 
-         // The table bigbluebuttonbn stores only the room properties.
-         // However, there is a chance that some personal information is stored as metadata.
-         // This would be done in the column 'participants' where rules can be set to define BBB roles.
-         // It is fair to say that only the userid is stored, which is useless if user is removed.
-         // But if this is a concern a refactoring on the way the rules are stored will be required.
+            // The table bigbluebuttonbn stores only the room properties.
+            // However, there is a chance that some personal information is stored as metadata.
+            // This would be done in the column 'participants' where rules can be set to define BBB roles.
+            // It is fair to say that only the userid is stored, which is useless if user is removed.
+            // But if this is a concern a refactoring on the way the rules are stored will be required.
         $collection->add_database_table('bigbluebuttonbn', [
             'participants' => 'privacy:metadata:bigbluebuttonbn:participants',
         ], 'privacy:metadata:bigbluebuttonbn');
@@ -207,7 +207,7 @@ 
                     'meetingid' => $record->meetingid,
                     'log' => $record->log,
                     'meta' => $record->meta,
-                  ];
+                    ];
                 return $carry;
             },
             function($instanceid, $data) use ($user, $instanceidstocmids) {

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * Privacy class for requesting user data.

classes/output/import_view.php

Spacing +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
             }
             $recordings = bigbluebuttonbn_get_allrecordings(
                 $selected, $bigbluebuttonbnid, false,
-                (boolean)\mod_bigbluebuttonbn\locallib\config::get('importrecordings_from_deleted_enabled')
+                (boolean) \mod_bigbluebuttonbn\locallib\config::get('importrecordings_from_deleted_enabled')
             );
             // Exclude the ones that are already imported.
             if (!empty($recordings)) {

classes/output/index.php

Spacing +4 added lines, -4 removed lines

@@ -221,10 +221,10 @@
             if ($groupobj != null) {
                 $actions .= '  <INPUT type="hidden" name="g" value="'.$groupobj->id.'">'."\n";
             }
-            $actions .= '  <INPUT type="submit" name="submit" value="' .
-                get_string('view_conference_action_end', 'bigbluebuttonbn') .
-                '" class="btn btn-primary btn-sm" onclick="return confirm(\'' .
-                get_string('index_confirm_end', 'bigbluebuttonbn') . '\')">' . "\n";
+            $actions .= '  <INPUT type="submit" name="submit" value="'.
+                get_string('view_conference_action_end', 'bigbluebuttonbn').
+                '" class="btn btn-primary btn-sm" onclick="return confirm(\''.
+                get_string('index_confirm_end', 'bigbluebuttonbn').'\')">'."\n";
             $actions .= '</form>'."\n";
         }
         return $actions;

classes/output/mobile.php

Spacing +13 added lines, -13 removed lines

@@ -29,8 +29,8 @@ 
 
 use context_module;
 use mod_bigbluebuttonbn_external;
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
-require_once($CFG->dirroot . '/lib/grouplib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/lib/grouplib.php');
 
 /**
  * Mobile output class for bigbluebuttonbn
@@ -67,7 +67,7 @@ 
         $bigbluebuttonbn = $viewinstance['bigbluebuttonbn'];
         $context = context_module::instance($cm->id);
 
-        require_login($course->id, false , $cm, true, true);
+        require_login($course->id, false, $cm, true, true);
         require_capability('mod/bigbluebuttonbn:join', $context);
 
         // Add view event.
@@ -138,15 +138,15 @@ 
         }
 
         // Operation URLs.
-        $bbbsession['bigbluebuttonbnURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/view.php?id=' . $bbbsession['cm']->id;
-        $bbbsession['logoutURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=logout&id='.$args->cmid .
-            '&bn=' . $bbbsession['bigbluebuttonbn']->id;
-        $bbbsession['recordingReadyURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_broker.php?action=recording_' .
-            'ready&bigbluebuttonbn=' . $bbbsession['bigbluebuttonbn']->id;
-        $bbbsession['meetingEventsURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_broker.php?action=meeting' .
-            '_events&bigbluebuttonbn=' . $bbbsession['bigbluebuttonbn']->id;
-        $bbbsession['joinURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=join&id=' . $args->cmid .
-            '&bn=' . $bbbsession['bigbluebuttonbn']->id;
+        $bbbsession['bigbluebuttonbnURL'] = $CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bbbsession['cm']->id;
+        $bbbsession['logoutURL'] = $CFG->wwwroot.'/mod/bigbluebuttonbn/bbb_view.php?action=logout&id='.$args->cmid.
+            '&bn='.$bbbsession['bigbluebuttonbn']->id;
+        $bbbsession['recordingReadyURL'] = $CFG->wwwroot.'/mod/bigbluebuttonbn/bbb_broker.php?action=recording_'.
+            'ready&bigbluebuttonbn='.$bbbsession['bigbluebuttonbn']->id;
+        $bbbsession['meetingEventsURL'] = $CFG->wwwroot.'/mod/bigbluebuttonbn/bbb_broker.php?action=meeting'.
+            '_events&bigbluebuttonbn='.$bbbsession['bigbluebuttonbn']->id;
+        $bbbsession['joinURL'] = $CFG->wwwroot.'/mod/bigbluebuttonbn/bbb_view.php?action=join&id='.$args->cmid.
+            '&bn='.$bbbsession['bigbluebuttonbn']->id;
 
         // Initialize session variable used across views.
         $SESSION->bigbluebuttonbn_bbbsession = $bbbsession;
@@ -182,7 +182,7 @@ 
             }
             if ($response['returncode'] == 'FAILED') {
                 // The meeting could not be created.
-                $errorkey = bigbluebuttonbn_get_error_key($response['messageKey'],  'view_error_create');
+                $errorkey = bigbluebuttonbn_get_error_key($response['messageKey'], 'view_error_create');
                 $e = get_string($errorkey, 'bigbluebuttonbn');
                 return(self::mobile_print_error($e));
             }

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 defined('MOODLE_INTERNAL') || die();
 
 use context_module;
-use mod_bigbluebuttonbn_external;
 require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
 require_once($CFG->dirroot . '/lib/grouplib.php');
 

classes/search/tags.php

Spacing +4 added lines, -4 removed lines

@@ -65,8 +65,8 @@ 
             return null;
         }
 
-        $result = $DB->get_recordset_sql('SELECT modtable.* FROM {' . $this->get_module_name() .
-            '} modtable ' . $contextjoin, array_merge($contextparams));
+        $result = $DB->get_recordset_sql('SELECT modtable.* FROM {'.$this->get_module_name().
+            '} modtable '.$contextjoin, array_merge($contextparams));
 
         return($result);
     }
@@ -96,12 +96,12 @@ 
 
         } catch (\dml_missing_record_exception $ex) {
             // Notify it as we run here as admin, we should see everything.
-            debugging('Error retrieving ' . $this->areaid . ' ' . $record->id . ' document, not all required data is available: ' .
+            debugging('Error retrieving '.$this->areaid.' '.$record->id.' document, not all required data is available: '.
                 $ex->getMessage(), DEBUG_DEVELOPER);
             return false;
         } catch (\dml_exception $ex) {
             // Notify it as we run here as admin, we should see everything.
-            debugging('Error retrieving ' . $this->areaid . ' ' . $record->id . ' document: ' . $ex->getMessage(), DEBUG_DEVELOPER);
+            debugging('Error retrieving '.$this->areaid.' '.$record->id.' document: '.$ex->getMessage(), DEBUG_DEVELOPER);
             return false;
         }
 

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
  */
 
 namespace mod_bigbluebuttonbn\search;
-use core_tag\output\tag;
 
 defined('MOODLE_INTERNAL') || die();
 

classes/event/base.php

Indentation +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
             'objectid' => $this->objectid,
             'contextinstanceid' => $this->contextinstanceid,
             'other' => $this->other
-          );
+            );
         $string = $this->description;
         foreach ($vars as $key => $value) {
             $string = str_replace("##" . $key, $value, $string);

Spacing +3 added lines, -3 removed lines

@@ -86,7 +86,7 @@ 
           );
         $string = $this->description;
         foreach ($vars as $key => $value) {
-            $string = str_replace("##" . $key, $value, $string);
+            $string = str_replace("##".$key, $value, $string);
         }
         return $string;
     }
@@ -108,9 +108,9 @@ 
      * @param string $url The url to the assign module instance.
      */
     public function set_legacy_logdata($action = '', $info = '', $url = '') {
-        $fullurl = 'view.php?id=' . $this->contextinstanceid;
+        $fullurl = 'view.php?id='.$this->contextinstanceid;
         if ($url != '') {
-            $fullurl .= '&' . $url;
+            $fullurl .= '&'.$url;
         }
 
         $this->legacylogdata = array($this->courseid, 'bigbluebuttonbn', $action, $fullurl, $info, $this->contextinstanceid);

classes/event/events.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * The mod_bigbluebuttonbn class for event name definition.

classes/event/activity_viewed.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
      */
     protected function init($crud = 'r', $edulevel = self::LEVEL_PARTICIPATING) {
         parent::init($crud, $edulevel);
-        $this->description = "The user with id '##userid' viewed the bigbluebuttonbn activity " .
+        $this->description = "The user with id '##userid' viewed the bigbluebuttonbn activity ".
             "with id '##objectid' for the course id '##courseid'.";
     }
 

classes/external.php

Spacing +2 added lines, -2 removed lines

@@ -61,7 +61,7 @@ 
      */
     public static function view_bigbluebuttonbn($bigbluebuttonbnid) {
         global $DB, $CFG;
-        require_once($CFG->dirroot . "/mod/bigbluebuttonbn/lib.php");
+        require_once($CFG->dirroot."/mod/bigbluebuttonbn/lib.php");
 
         $params = self::validate_parameters(self::view_bigbluebuttonbn_parameters(),
                                             array(
@@ -109,7 +109,7 @@ 
      * @since Moodle 3.3
      */
     public static function get_bigbluebuttonbns_by_courses_parameters() {
-        return new external_function_parameters (
+        return new external_function_parameters(
             array(
                 'courseids' => new external_multiple_structure(
                     new external_value(PARAM_INT, 'Course id'), 'Array of course ids', VALUE_DEFAULT, array()