AddCustomRoles.up() - Code Metrics - Inspection of "GRN2-176: Create a role editor that allows admins..." - jfederico/greenlight - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 02b342...4fc171 )

by Jesus

created 2019-07-31 15:57 UTC

AddCustomRoles.up() B

↳ Parent: AddCustomRoles

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
dl	0
loc	70
rs	7.9818

How to fix Long Method

# frozen_string_literal: true

class AddCustomRoles < ActiveRecord::Migration[5.2]
  def up
    super_admin_id = -1
    user_id = -1
    admin_id = -1
    denied_id = -1
    pending_id = -1

    old_roles = ActiveRecord::Base.connection.execute("select * from roles")

    # Determine what ids corresponded to what roles in the old table
    old_roles.each do |role|
      if role["name"] == "super_admin"
        super_admin_id = role["id"]
      elsif role["name"] == "user"
        user_id = role["id"]
      elsif role["name"] == "admin"
        admin_id = role["id"]
      elsif role["name"] == "denied"
        denied_id = role["id"]
      elsif role["name"] == "pending"
        pending_id = role["id"]
      end
    end

    # Replace Rolify's table with our own
    drop_table :roles

    create_table(:roles) do |t|
      t.string :name
      t.integer :priority, default: 9999
      t.boolean :can_create_rooms, default: false
      t.boolean :send_promoted_email, default: false
      t.boolean :send_demoted_email, default: false
      t.boolean :can_edit_site_settings, default: false
      t.boolean :can_edit_roles, default: false
      t.boolean :can_manage_users, default: false
      t.string  :colour
      t.string :provider

      t.timestamps
    end

    add_index(:roles, :name)
    add_index(:roles, [:name, :provider], unique: true)

    # Look at all the old role assignments and and for each role create a new role
    # that is scoped to the provider
    old_assignments = ActiveRecord::Base.connection.execute("select * from users_roles")
    new_assignments = []

    old_assignments.each do |assignment|
      user = User.find(assignment["user_id"])
      new_assignment = { "user_id" => assignment["user_id"] }
      if assignment["role_id"] == super_admin_id
        new_assignment["new_role_id"] = generate_scoped_role(user, "super_admin")
      elsif assignment["role_id"] == user_id
        new_assignment["new_role_id"] = generate_scoped_role(user, "user")
      elsif assignment["role_id"] == admin_id
        new_assignment["new_role_id"] = generate_scoped_role(user, "admin")
      elsif assignment["role_id"] == denied_id
        new_assignment["new_role_id"] = generate_scoped_role(user, "denied")
      elsif assignment["role_id"] == pending_id
        new_assignment["new_role_id"] = generate_scoped_role(user, "pending")
      end

      new_assignments << new_assignment
    end

    assign_new_users(new_assignments)
  end

  def generate_scoped_role(user, role_name)
    provider = Rails.configuration.loadbalanced_configuration ? user.provider : 'greenlight'
    new_role = Role.find_by(name: role_name, provider: provider)

    if new_role.nil?
      Role.create_default_roles(provider)

      new_role = Role.find_by(name: role_name, provider: provider)
    end

    new_role.id
  end

  def assign_new_users(new_assignments)
    # Delete the old assignments
    ActiveRecord::Base.connection.execute("DELETE FROM users_roles")
    # Add the role assignments to the new roles
    new_assignments.each do |assignment|
      if assignment['new_role_id']
        ActiveRecord::Base.connection.execute("INSERT INTO users_roles (user_id, role_id)" \
          " VALUES (#{assignment['user_id']}, #{assignment['new_role_id']})")
      end
    end
  end

  def down
    drop_table :roles

    create_table(:roles) do |t|
      t.string :name
      t.references :resource, polymorphic: true

      t.timestamps
    end
  end
end


1			# frozen_string_literal: true
2
3			class AddCustomRoles < ActiveRecord::Migration[5.2]
4			def up
5			super_admin_id = -1
6			user_id = -1
7			admin_id = -1
8			denied_id = -1
9			pending_id = -1
10
11			old_roles = ActiveRecord::Base.connection.execute("select * from roles")
12
13			# Determine what ids corresponded to what roles in the old table
14			old_roles.each do \|role\|
15			if role["name"] == "super_admin"
16			super_admin_id = role["id"]
17			elsif role["name"] == "user"
18			user_id = role["id"]
19			elsif role["name"] == "admin"
20			admin_id = role["id"]
21			elsif role["name"] == "denied"
22			denied_id = role["id"]
23			elsif role["name"] == "pending"
24			pending_id = role["id"]
25			end
26			end
27
28			# Replace Rolify's table with our own
29			drop_table :roles
30
31			create_table(:roles) do \|t\|
32			t.string :name
33			t.integer :priority, default: 9999
34			t.boolean :can_create_rooms, default: false
35			t.boolean :send_promoted_email, default: false
36			t.boolean :send_demoted_email, default: false
37			t.boolean :can_edit_site_settings, default: false
38			t.boolean :can_edit_roles, default: false
39			t.boolean :can_manage_users, default: false
40			t.string :colour
41			t.string :provider
42
43			t.timestamps
44			end
45
46			add_index(:roles, :name)
47			add_index(:roles, [:name, :provider], unique: true)
48
49			# Look at all the old role assignments and and for each role create a new role
50			# that is scoped to the provider
51			old_assignments = ActiveRecord::Base.connection.execute("select * from users_roles")
52			new_assignments = []
53
54			old_assignments.each do \|assignment\|
55			user = User.find(assignment["user_id"])
56			new_assignment = { "user_id" => assignment["user_id"] }
57			if assignment["role_id"] == super_admin_id
58			new_assignment["new_role_id"] = generate_scoped_role(user, "super_admin")
59			elsif assignment["role_id"] == user_id
60			new_assignment["new_role_id"] = generate_scoped_role(user, "user")
61			elsif assignment["role_id"] == admin_id
62			new_assignment["new_role_id"] = generate_scoped_role(user, "admin")
63			elsif assignment["role_id"] == denied_id
64			new_assignment["new_role_id"] = generate_scoped_role(user, "denied")
65			elsif assignment["role_id"] == pending_id
66			new_assignment["new_role_id"] = generate_scoped_role(user, "pending")
67			end
68
69			new_assignments << new_assignment
70			end
71
72			assign_new_users(new_assignments)
73			end
74
75			def generate_scoped_role(user, role_name)
76			provider = Rails.configuration.loadbalanced_configuration ? user.provider : 'greenlight'
77			new_role = Role.find_by(name: role_name, provider: provider)
78
79			if new_role.nil?
80			Role.create_default_roles(provider)
81
82			new_role = Role.find_by(name: role_name, provider: provider)
83			end
84
85			new_role.id
86			end
87
88			def assign_new_users(new_assignments)
89			# Delete the old assignments
90			ActiveRecord::Base.connection.execute("DELETE FROM users_roles")
91			# Add the role assignments to the new roles
92			new_assignments.each do \|assignment\|
93			if assignment['new_role_id']
94			ActiveRecord::Base.connection.execute("INSERT INTO users_roles (user_id, role_id)" \
95			" VALUES (#{assignment['user_id']}, #{assignment['new_role_id']})")
96			end
97			end
98			end
99
100			def down
101			drop_table :roles
102
103			create_table(:roles) do \|t\|
104			t.string :name
105			t.references :resource, polymorphic: true
106
107			t.timestamps
108			end
109			end
110			end
111

jfederico / greenlight

Push — master ( 02b342...4fc171 )

AddCustomRoles.up() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like