app\controllers\ContentTypeController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	76
Duplicated Lines	35.53 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	actionIndex()	10	10	1
A	actionToggle()	9	9	1
A	findModel()	8	8	2
A	behaviors()	0	18	1

<?php

namespace app\controllers;

use Yii;
use app\models\ContentType;
use yii\data\ActiveDataProvider;
use yii\web\NotFoundHttpException;
use yii\filters\AccessControl;
use yii\filters\VerbFilter;

/**
 * ContentController implements the CRUD actions for ContentType model.
 */
class ContentTypeController extends BaseController
{
    /**
     * {@inheritdoc}
     */
    public function behaviors()
    {
        return [
            'verbs' => [
                'class' => VerbFilter::class,
                'actions' => [
                    'delete' => ['POST'],
                ],
            ],
            'access' => [
                'class' => AccessControl::class,
                'only' => ['index'],
                'rules' => [
                    ['allow' => true, 'actions' => ['index'], 'roles' => ['setContentTypes']],
                ],
            ],
        ];
    }

    /**
     * Lists all ContentType models.
     *
     * @return string
     */
    public function actionIndex()

This method seems to be duplicated in your project.

    {
        $dataProvider = new ActiveDataProvider([
            'query' => ContentType::find(),
        ]);

        return $this->render('index', [
            'dataProvider' => $dataProvider,
        ]);
    }

    /**
     * Enables or disables a Device.
     *
     * @param int $id screen id
     *
     * @return \yii\web\Response
     */
    public function actionToggle($id)

This method seems to be duplicated in your project.

    {
        $model = $this->findModel($id);

        $model->enabled = !$model->enabled;
        $model->save();

        return $this->smartGoBack();
    }

    /**
     * Finds the ContentType model based on its primary key value.
     * If the model is not found, a 404 HTTP exception will be thrown.
     *
     * @param int $id
     *
     * @return ContentType the loaded model
     *
     * @throws NotFoundHttpException if the model cannot be found
     */
    protected function findModel($id)
    {
        if (($model = ContentType::findOne($id)) !== null) {

The expression \app\models\ContentType::findOne($id); of type yii\db\ActiveRecordInterface|array|null adds the type array to the return on line 85 which is incompatible with the return type documented by app\controllers\ContentTypeController::findModel of type app\models\ContentType.

            return $model;
        } else {
            throw new NotFoundHttpException(Yii::t('app', 'The requested content does not exist.'));
        }
    }
}