Passed
Push — master ( bdb393...1fedf8 )
by Sinnarasa
01:46
created
src/Routing/Response.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -166,8 +166,9 @@
 block discarded – undo
166 166
      */
167 167
     public function sendHeaders()
168 168
     {
169
-        foreach($this->headers as $key => $content)
170
-            header($key.' : '.$content);
169
+        foreach($this->headers as $key => $content) {
170
+                    header($key.' : '.$content);
171
+        }
171 172
         http_response_code($this->getStatusCode());
172 173
         return $this;
173 174
     }
Please login to merge, or discard this patch.
src/Routing/Route.php 1 patch
Braces   +18 added lines, -8 removed lines patch added patch discarded remove patch
@@ -52,10 +52,18 @@  discard block
 block discarded – undo
52 52
      */
53 53
     public function set($args = [])
54 54
     {
55
-        if (isset($args['name'])) $this->name = $args['name'];
56
-        if (isset($args['callback'])) $this->callback = $args['callback'];
57
-        if (isset($args['target'])) $this->target = $args['target'];
58
-        if (isset($args['detail'])) $this->detail = $args['detail'];
55
+        if (isset($args['name'])) {
56
+            $this->name = $args['name'];
57
+        }
58
+        if (isset($args['callback'])) {
59
+            $this->callback = $args['callback'];
60
+        }
61
+        if (isset($args['target'])) {
62
+            $this->target = $args['target'];
63
+        }
64
+        if (isset($args['detail'])) {
65
+            $this->detail = $args['detail'];
66
+        }
59 67
     }
60 68
 
61 69
     /**
@@ -145,8 +153,9 @@  discard block
 block discarded – undo
145 153
      */
146 154
     public function getTarget($key = null)
147 155
     {
148
-        if (!is_null($key))
149
-            return isset($this->target[$key]) ? $this->target[$key] : '';
156
+        if (!is_null($key)) {
157
+                    return isset($this->target[$key]) ? $this->target[$key] : '';
158
+        }
150 159
         return empty($this->target) ? '' : $this->target;
151 160
     }
152 161
 
@@ -165,8 +174,9 @@  discard block
 block discarded – undo
165 174
      */
166 175
     public function hasTarget($key = null)
167 176
     {
168
-        if (!is_null($key))
169
-            return isset($this->target[$key]) ? true : false;
177
+        if (!is_null($key)) {
178
+                    return isset($this->target[$key]) ? true : false;
179
+        }
170 180
         return empty($this->target) ? false : true;
171 181
     }
172 182
 
Please login to merge, or discard this patch.
src/Routing/Dispatcher/ControllerDispatcher.php 1 patch
Braces   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -49,10 +49,11 @@
 block discarded – undo
49 49
 
50 50
         foreach ($reflectionMethod->getParameters() as $arg) {
51 51
             if (!is_null($arg->getClass())) {
52
-                if (isset($classInstance[$arg->getClass()->name]))
53
-                $dependencies[] = $classInstance[$arg->getClass()->name];
54
-            else
55
-                $dependencies[] = call_user_func_array($this->router->route->getTarget('di'), [$arg->getClass()->name]);
52
+                if (isset($classInstance[$arg->getClass()->name])) {
53
+                                $dependencies[] = $classInstance[$arg->getClass()->name];
54
+                } else {
55
+                            $dependencies[] = call_user_func_array($this->router->route->getTarget('di'), [$arg->getClass()->name]);
56
+            }
56 57
             } else {
57 58
                 $count++;
58 59
             }
Please login to merge, or discard this patch.
src/Routing/Dispatcher/TemplateDispatcher.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,8 +44,12 @@
 block discarded – undo
44 44
             $this->router->response->setContent(call_user_func_array($this->router->route->getTarget('callback')[$this->router->route->getTarget('extension')], [$this->router->route]));
45 45
         } else {
46 46
             ob_start();
47
-            if (isset($this->router->route->getTarget()['data'])) extract($this->router->route->getTarget('data'));
48
-            if (isset($this->router->route->getParams()['data'])) extract($this->router->route->getParams()['data']);
47
+            if (isset($this->router->route->getTarget()['data'])) {
48
+                extract($this->router->route->getTarget('data'));
49
+            }
50
+            if (isset($this->router->route->getParams()['data'])) {
51
+                extract($this->router->route->getParams()['data']);
52
+            }
49 53
             require($this->router->route->getTarget('template'));
50 54
             $this->router->response->setContent(ob_get_clean());
51 55
         }
Please login to merge, or discard this patch.
src/Routing/RouteCollection.php 1 patch
Braces   +47 added lines, -22 removed lines patch added patch discarded remove patch
@@ -33,7 +33,9 @@  discard block
 block discarded – undo
33 33
      */
34 34
     public function __construct($routes = null, $options = [])
35 35
     {
36
-        if (!is_null($routes) || !empty($options)) $this->addRoutes($routes, $options);
36
+        if (!is_null($routes) || !empty($options)) {
37
+            $this->addRoutes($routes, $options);
38
+        }
37 39
     }
38 40
 
39 41
     /**
@@ -43,10 +45,16 @@  discard block
 block discarded – undo
43 45
     public function addRoutes($routes = null, $options = [])
44 46
     {
45 47
         if (!is_null($routes) && !is_array($routes)) {
46
-            if (strpos($routes, '.php') === false) $routes = trim($routes, '/') . '/';
47
-            if (is_file($routes . '/routes.php') && is_array($routesFile = include $routes . '/routes.php')) $routes = $routesFile;
48
-            elseif (is_file($routes) && is_array($routesFile = include $routes)) $routes = $routesFile;
49
-            else throw new \InvalidArgumentException('Argument for "' . get_called_class() . '" constructor is not recognized. Expected argument array or file containing array but "' . $routes . '" given');
48
+            if (strpos($routes, '.php') === false) {
49
+                $routes = trim($routes, '/') . '/';
50
+            }
51
+            if (is_file($routes . '/routes.php') && is_array($routesFile = include $routes . '/routes.php')) {
52
+                $routes = $routesFile;
53
+            } elseif (is_file($routes) && is_array($routesFile = include $routes)) {
54
+                $routes = $routesFile;
55
+            } else {
56
+                throw new \InvalidArgumentException('Argument for "' . get_called_class() . '" constructor is not recognized. Expected argument array or file containing array but "' . $routes . '" given');
57
+            }
50 58
         }
51 59
         $this->routes['routes_' . $this->countRoutes] = is_array($routes) ? $routes : [];
52 60
         $this->setRoutes($options, $this->countRoutes);
@@ -59,8 +67,9 @@  discard block
 block discarded – undo
59 67
      */
60 68
     public function getRoutes($key = null)
61 69
     {
62
-        if (!is_null($key))
63
-            return isset($this->routes[$key]) ? $this->routes[$key] : '';
70
+        if (!is_null($key)) {
71
+                    return isset($this->routes[$key]) ? $this->routes[$key] : '';
72
+        }
64 73
         return $this->routes;
65 74
     }
66 75
 
@@ -71,12 +80,18 @@  discard block
 block discarded – undo
71 80
     {
72 81
         if (is_array($args)) {
73 82
             $nbrArgs = count($args);
74
-            for ($i = 0; $i < $nbrArgs; ++$i)
75
-                $this->routes['prefix_' . $i] = '/' . trim($args[$i], '/');
76
-        } elseif (is_string($args))
77
-            for ($i = 0; $i < $this->countRoutes; ++$i)
78
-                $this->routes['prefix_' . $i] = '/' . trim($args, '/');
79
-        if ($this->countRoutes == 0) $this->countRoutes++;
83
+            for ($i = 0; $i < $nbrArgs; ++$i) {
84
+                            $this->routes['prefix_' . $i] = '/' . trim($args[$i], '/');
85
+            }
86
+        } elseif (is_string($args)) {
87
+                    for ($i = 0;
88
+        }
89
+        $i < $this->countRoutes; ++$i) {
90
+                            $this->routes['prefix_' . $i] = '/' . trim($args, '/');
91
+            }
92
+        if ($this->countRoutes == 0) {
93
+            $this->countRoutes++;
94
+        }
80 95
     }
81 96
 
82 97
     /**
@@ -88,10 +103,14 @@  discard block
 block discarded – undo
88 103
         for ($i = 0; $i < $nbrArgs; ++$i) {
89 104
             if (is_array($args[$i])) {
90 105
                 $this->setRoutes($args[$i], $i);
91
-                if (!isset($this->routes['routes_' . $i])) $this->routes['routes_' . $i] = [];
106
+                if (!isset($this->routes['routes_' . $i])) {
107
+                    $this->routes['routes_' . $i] = [];
108
+                }
92 109
             }
93 110
         }
94
-        if ($this->countRoutes == 0) $this->countRoutes++;
111
+        if ($this->countRoutes == 0) {
112
+            $this->countRoutes++;
113
+        }
95 114
     }
96 115
 
97 116
     /**
@@ -121,7 +140,7 @@  discard block
 block discarded – undo
121 140
         if(!is_null($root)){
122 141
             $protocol = explode('://', $root);
123 142
             $protocol = $protocol[0];
124
-        }else{
143
+        } else{
125 144
             $root = $protocol . '://' . $domain . ((!empty($_SERVER['SERVER_PORT']) && $_SERVER['SERVER_PORT'] != 80) ? ':' . $_SERVER['SERVER_PORT'] : '') . str_replace('/' . $script_file, '', $_SERVER['SCRIPT_NAME']);
126 145
         }
127 146
 
@@ -136,10 +155,11 @@  discard block
 block discarded – undo
136 155
             $subdomain = (isset($this->routes['subdomain_' . $i])) ? $this->routes['subdomain_' . $i] : '';
137 156
             $block_protocol = (isset($this->routes['protocol_' . $i])) ? $this->routes['protocol_' . $i] : 'http';
138 157
             $url = (!empty($subdomain)) ? str_replace($protocol . '://', $block_protocol . '://' . $subdomain . '.', $root) : $root;
139
-            if (isset($this->routes['routes_' . $i]))
140
-                foreach ($this->routes['routes_' . $i] as $route => $dependencies) {
158
+            if (isset($this->routes['routes_' . $i])) {
159
+                            foreach ($this->routes['routes_' . $i] as $route => $dependencies) {
141 160
                     if (is_array($dependencies) && isset($dependencies['use']) && !is_array($dependencies['use'])) {
142
-                        $use = (is_callable($dependencies['use'])) ? 'closure-' . $count : trim($dependencies['use'], '/');
161
+                        $use = (is_callable($dependencies['use'])) ? 'closure-' . $count : trim($dependencies['use'], '/');
162
+            }
143 163
                     } elseif (!is_array($dependencies)) {
144 164
                         $use = (is_callable($dependencies)) ? 'closure-' . $count : trim($dependencies, '/');
145 165
                     } else {
@@ -187,9 +207,14 @@  discard block
 block discarded – undo
187 207
         foreach ($this->routesByName as $key => $route) {
188 208
             $param = explode('#', $key);
189 209
             $route = str_replace('{subdomain}', $subdomain, $route);
190
-            foreach ($params as $key2 => $value) $route = str_replace(':' . $key2, $value, $route);
191
-            if ($param[0] == trim($name, '/')) return $route;
192
-            else if (isset($param[1]) && $param[1] == $name) return $route;
210
+            foreach ($params as $key2 => $value) {
211
+                $route = str_replace(':' . $key2, $value, $route);
212
+            }
213
+            if ($param[0] == trim($name, '/')) {
214
+                return $route;
215
+            } else if (isset($param[1]) && $param[1] == $name) {
216
+                return $route;
217
+            }
193 218
         }
194 219
         return null;
195 220
     }
Please login to merge, or discard this patch.
src/Routing/Router.php 1 patch
Braces   +10 added lines, -5 removed lines patch added patch discarded remove patch
@@ -120,13 +120,15 @@  discard block
 block discarded – undo
120 120
     public function run()
121 121
     {
122 122
         $this->setUrl();
123
-        if ($this->config['generateRoutesPath']) $this->collection->generateRoutesPath();
123
+        if ($this->config['generateRoutesPath']) {
124
+            $this->collection->generateRoutesPath();
125
+        }
124 126
         if ($this->match() === true) {
125 127
             $this->callMiddleware('before');
126 128
             if (!in_array(substr($this->response->getStatusCode(), 0, 1), [3,4,5])) {
127 129
                 $this->callTarget();
128 130
             }
129
-        }else{
131
+        } else{
130 132
             $this->response->setStatusCode(404);
131 133
         }
132 134
         $this->callMiddleware('after');
@@ -155,8 +157,9 @@  discard block
 block discarded – undo
155 157
      */
156 158
     public function setUrl($url = null)
157 159
     {
158
-        if (is_null($url))
159
-            $url = (isset($_GET['url'])) ? $_GET['url'] : substr(str_replace(str_replace('/index.php', '', $_SERVER['SCRIPT_NAME']), '', $_SERVER['REQUEST_URI']), 1);
160
+        if (is_null($url)) {
161
+                    $url = (isset($_GET['url'])) ? $_GET['url'] : substr(str_replace(str_replace('/index.php', '', $_SERVER['SCRIPT_NAME']), '', $_SERVER['REQUEST_URI']), 1);
162
+        }
160 163
         $this->route->setUrl('/' . trim(explode('?', $url)[0], '/'));
161 164
     }
162 165
 
@@ -166,7 +169,9 @@  discard block
 block discarded – undo
166 169
     public function match()
167 170
     {
168 171
         foreach ($this->matcher as $key => $matcher) {
169
-            if (call_user_func([$this->matcher[$key], 'match'])) return true;
172
+            if (call_user_func([$this->matcher[$key], 'match'])) {
173
+                return true;
174
+            }
170 175
         }
171 176
         return false;
172 177
     }
Please login to merge, or discard this patch.
src/Routing/Matcher/ArrayMatcher.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -125,7 +125,9 @@  discard block
 block discarded – undo
125 125
         $url = (isset($_SERVER['REQUEST_SCHEME']) ? $_SERVER['REQUEST_SCHEME'] : 'http') . '://' . ($host = (isset($_SERVER['SERVER_NAME']) ? $_SERVER['SERVER_NAME'] : $_SERVER['HTTP_HOST']));
126 126
         $host = explode(':', $host)[0];
127 127
         $domain = $this->router->collection->getDomain($url);
128
-        if (!empty($this->request['subdomain']) && $route[0] == '/') $route = trim($this->request['subdomain'], '.') . '.' . $domain . $route;
128
+        if (!empty($this->request['subdomain']) && $route[0] == '/') {
129
+            $route = trim($this->request['subdomain'], '.') . '.' . $domain . $route;
130
+        }
129 131
         if ($route[0] == '/') {
130 132
             return ($host != $domain) ? false : true;
131 133
         } elseif ($route[0] != '/' && $host != $domain) {
@@ -333,13 +335,17 @@  discard block
 block discarded – undo
333 335
     {
334 336
         if (is_string($callback) && strpos($callback, '@') !== false) {
335 337
             $routes = explode('@', $callback);
336
-            if (!isset($routes[1])) $routes[1] = 'index';
338
+            if (!isset($routes[1])) {
339
+                $routes[1] = 'index';
340
+            }
337 341
             if ($routes[1] == '{method}') {
338 342
                 $params = explode('/', preg_replace('#' . str_replace('*', '', $this->request['route']) . '#', '', $this->router->route->getUrl()));
339 343
                 $routes[1] = $params[0];
340 344
                 array_shift($params);
341 345
                 array_merge($this->request['parameters'], $params);
342
-                if (preg_match('/[A-Z]/', $routes[1])) return false;
346
+                if (preg_match('/[A-Z]/', $routes[1])) {
347
+                    return false;
348
+                }
343 349
                 $routes[1] = lcfirst(str_replace(' ', '', ucwords(str_replace('-', ' ', $routes[1]))));
344 350
             }
345 351
             $index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
Please login to merge, or discard this patch.