ArrayMatcher - Code Metrics - Inspection of "bugfix" - jetfirephp/routing - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bdb393...1fedf8 )

by Sinnarasa

created 2017-10-09 19:56 UTC

ArrayMatcher D

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	390
Duplicated Lines	5.64 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	94
lcom	1
cbo	4
dl	22
loc	390
rs	4.8717
c	0
b	0
f	0

21 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	setResolver()	0	4	1
A	addResolver()	0	4	1
A	getResolver()	0	4	1
A	setDispatcher()	0	4	1
A	addDispatcher()	0	4	1
B	match()	0	21	7
B	checkSubdomain()	0	20	10
A	subdomainMatch()	0	7	3
A	paramMatch()	0	8	3
A	routeMatch()	0	9	3
A	generateTarget()	0	13	4
A	setTarget()	0	11	2
A	checkRequest()	0	14	3
C	setCallback()	0	24	11
B	validMethod()	0	11	8
B	isClosureAndTemplate()	11	12	5
B	isControllerAndTemplate()	11	12	5
A	isClosure()	0	10	2
C	isController()	0	34	11
C	isTemplate()	0	31	11

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like ArrayMatcher often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use ArrayMatcher, and based on these observations, apply Extract Interface, too.

<?php

namespace JetFire\Routing\Matcher;


use JetFire\Routing\Dispatcher\ClosureDispatcher;
use JetFire\Routing\Dispatcher\ControllerDispatcher;
use JetFire\Routing\Dispatcher\TemplateDispatcher;
use JetFire\Routing\Router;

/**
 * Class RoutesMatch
 * @package JetFire\Routing\Match
 */
class ArrayMatcher implements MatcherInterface
{

    /**
     * @var
     */
    private $router;

    /**
     * @var array
     */
    private $request = [];

    /**
     * @var array
     */
    private $resolver = ['isClosureAndTemplate', 'isControllerAndTemplate', 'isTemplate'];

    /**
     * @var array
     */
    private $dispatcher = [
        'isClosure' => ClosureDispatcher::class,
        'isController' => ControllerDispatcher::class,
        'isTemplate' => TemplateDispatcher::class,
        'isControllerAndTemplate' => [ControllerDispatcher::class, TemplateDispatcher::class],
        'isClosureAndTemplate' => [ClosureDispatcher::class, TemplateDispatcher::class],
    ];

    /**
     * @param Router $router
     */
    public function __construct(Router $router)
    {
        $this->router = $router;
    }

    /**
     * @param array $resolver
     */
    public function setResolver($resolver = [])
    {
        $this->resolver = $resolver;
    }

    /**
     * @param string $resolver
     */
    public function addResolver($resolver)
    {
        $this->resolver[] = $resolver;
    }

    /**
     * @return array
     */
    public function getResolver()
    {
        return $this->resolver;
    }

    /**
     * @param array $dispatcher
     */
    public function setDispatcher($dispatcher = [])
    {
        $this->dispatcher = $dispatcher;
    }

    /**
     * @param $method
     * @param $class
     * @internal param array $dispatcher
     */
    public function addDispatcher($method, $class)
    {
        $this->dispatcher[$method] = $class;
    }

    /**
     * @return bool
     */
    public function match()
    {
        $this->request = [];
        for ($i = 0; $i < $this->router->collection->countRoutes; ++$i) {
            $this->request['prefix'] = ($this->router->collection->getRoutes('prefix_' . $i) != '') ? $this->router->collection->getRoutes('prefix_' . $i) : '';
            $this->request['subdomain'] = ($this->router->collection->getRoutes('subdomain_' . $i) != '') ? $this->router->collection->getRoutes('subdomain_' . $i) : '';
            foreach ($this->router->collection->getRoutes('routes_' . $i) as $route => $params) {
                $this->request['params'] = $params;
                $this->request['collection_index'] = $i;
                if ($this->checkSubdomain($route)) {
                    $route = strstr($route, '/');
                    $this->request['route'] = preg_replace_callback('#:([\w]+)#', [$this, 'paramMatch'], '/' . trim(trim($this->request['prefix'], '/') . '/' . trim($route, '/'), '/'));
                    if ($this->routeMatch('#^' . $this->request['route'] . '$#')) {
                        $this->setCallback();
                        return $this->generateTarget();
                    }
                }
            }
        }
        return false;
    }

    /**
     * @param $route
     * @return bool
     */
    private function checkSubdomain($route)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $url = (isset($_SERVER['REQUEST_SCHEME']) ? $_SERVER['REQUEST_SCHEME'] : 'http') . '://' . ($host = (isset($_SERVER['SERVER_NAME']) ? $_SERVER['SERVER_NAME'] : $_SERVER['HTTP_HOST']));
        $host = explode(':', $host)[0];
        $domain = $this->router->collection->getDomain($url);
        if (!empty($this->request['subdomain']) && $route[0] == '/') $route = trim($this->request['subdomain'], '.') . '.' . $domain . $route;
        if ($route[0] == '/') {
            return ($host != $domain) ? false : true;
        } elseif ($route[0] != '/' && $host != $domain) {
            $route = substr($route, 0, strpos($route, "/"));
            $route = str_replace('{host}', $domain, $route);
            $route = preg_replace_callback('#{subdomain}#', [$this, 'subdomainMatch'], $route);
            if (preg_match('#^' . $route . '$#', $host, $this->request['called_subdomain'])) {
                $this->request['called_subdomain'] = array_shift($this->request['called_subdomain']);
                $this->request['subdomain'] = str_replace('.' . $domain, '', $host);
                return true;
            }
        }
        return false;
    }

    /**
     * @return string
     */
    private function subdomainMatch()
    {
        if (is_array($this->request['params']) && isset($this->request['params']['subdomain'])) {
            return '(' . $this->request['params']['subdomain'] . ')';
        }
        return '([^/]+)';
    }

    /**
     * @param $match
     * @return string
     */
    private function paramMatch($match)
    {
        if (is_array($this->request['params']) && isset($this->request['params']['arguments'][$match[1]])) {
            $this->request['params']['arguments'][$match[1]] = str_replace('(', '(?:', $this->request['params']['arguments'][$match[1]]);
            return '(' . $this->request['params']['arguments'][$match[1]] . ')';
        }
        return '([^/]+)';
    }

    /**
     * @param $regex
     * @return bool
     */
    private function routeMatch($regex)
    {
        $regex = (substr($this->request['route'], -1) == '*') ? '#^' . $this->request['route'] . '#' : $regex;
        if (preg_match($regex, $this->router->route->getUrl(), $this->request['parameters'])) {
            array_shift($this->request['parameters']);
            return true;
        }
        return false;
    }

    /**
     * @return bool
     */
    private function generateTarget()
    {
        if ($this->validMethod()) {
            foreach ($this->resolver as $resolver) {
                if (is_array($target = call_user_func_array([$this, $resolver], [$this->router->route->getCallback()]))) {
                    $this->setTarget($target);
                    return true;
                }
            }
        }
        $this->router->response->setStatusCode(405);
        return false;
    }

    /**
     * @param array $target
     */
    public function setTarget($target = [])
    {
        $index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
        $this->checkRequest('subdomain');
        $this->checkRequest('prefix');
        $this->router->route->setDetail($this->request);
        $this->router->route->setTarget($target);
        $this->router->route->addTarget('block', $this->router->collection->getRoutes('block_' . $index));
        $this->router->route->addTarget('view_dir', $this->router->collection->getRoutes('view_dir_' . $index));
        $this->router->route->addTarget('params', $this->router->collection->getRoutes('params_' . $index));
    }

    /**
     * @param $key
     */
    private function checkRequest($key)
    {
        if (strpos($this->request[$key], ':') !== false && isset($this->request['parameters'][0])) {
            $replacements = $this->request['parameters'];
            $keys = [];
            $this->request['@' . $key] = $this->request[$key];
            $this->request[$key] = preg_replace_callback('#:([\w]+)#', function ($matches) use (&$replacements, &$keys) {
                $keys[$matches[0]] = $replacements[0];
                return array_shift($replacements);
            }, $this->request[$key]);
            $this->request['keys'] = $keys;
            $this->request['parameters'] = $replacements;
        }
    }

    /**
     *
     */
    private function setCallback()
    {
        if (isset($this->request['params'])) {
            if (is_callable($this->request['params'])) {
                $this->router->route->setCallback($this->request['params']);
            } else {
                if (is_array($this->request['params']) && isset($this->request['params']['use'])) {
                    if (is_array($this->request['params']['use']) && isset($this->request['params']['use'][$this->router->route->getMethod()])) {
                        $this->router->route->setCallback($this->request['params']['use'][$this->router->route->getMethod()]);
                    } elseif (!is_array($this->request['params']['use'])) {
                        $this->router->route->setCallback($this->request['params']['use']);
                    }
                } else {
                    $this->router->route->setCallback($this->request['params']);
                }
                if (isset($this->request['params']['name'])) {
                    $this->router->route->setName($this->request['params']['name']);
                }
                if (isset($this->request['params']['method'])) {
                    $this->request['params']['method'] = is_array($this->request['params']['method']) ? $this->request['params']['method'] : [$this->request['params']['method']];
                }
            }
        }
    }

    /**
     * @return bool
     */
    public function validMethod()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (is_callable($this->request['params'])) {
            return true;
        }
        if (!empty($_SERVER['HTTP_X_REQUESTED_WITH']) && strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest') {
            return (isset($this->request['params']['ajax']) && $this->request['params']['ajax'] === true) ? true : false;
        }
        $method = (isset($this->request['params']['method'])) ? $this->request['params']['method'] : ['GET'];
        return (in_array($this->router->route->getMethod(), $method)) ? true : false;
    }

    /**
     * @param $callback
     * @return array|bool
     * @throws \Exception
     */
    public function isClosureAndTemplate($callback)

    {
        if (is_array($cls = $this->isClosure($callback))) {
            if (is_array($this->request['params']) && isset($this->request['params']['template']) && is_array($tpl = $this->isTemplate($this->request['params']['template']))) {
                return array_merge(array_merge($cls, $tpl), [
                    'dispatcher' => $this->dispatcher['isClosureAndTemplate']
                ]);
            }
            return $cls;
        }
        return false;
    }

    /**
     * @param $callback
     * @return array|bool
     * @throws \Exception
     */
    public function isControllerAndTemplate($callback)

    {
        if (is_array($ctrl = $this->isController($callback))) {
            if (is_array($this->request['params']) && isset($this->request['params']['template']) && is_array($tpl = $this->isTemplate($this->request['params']['template']))) {
                return array_merge(array_merge($ctrl, $tpl), [
                    'dispatcher' => $this->dispatcher['isControllerAndTemplate']
                ]);
            }
            return $ctrl;
        }
        return false;
    }


    /**
     * @param $callback
     * @return bool|array
     */
    public function isClosure($callback)
    {
        if (is_callable($callback)) {
            return [
                'dispatcher' => $this->dispatcher['isClosure'],
                'closure' => $callback
            ];
        }
        return false;
    }

    /**
     * @param $callback
     * @throws \Exception
     * @return bool|array
     */
    public function isController($callback)
    {
        if (is_string($callback) && strpos($callback, '@') !== false) {
            $routes = explode('@', $callback);
            if (!isset($routes[1])) $routes[1] = 'index';
            if ($routes[1] == '{method}') {
                $params = explode('/', preg_replace('#' . str_replace('*', '', $this->request['route']) . '#', '', $this->router->route->getUrl()));
                $routes[1] = $params[0];
                array_shift($params);
                array_merge($this->request['parameters'], $params);
                if (preg_match('/[A-Z]/', $routes[1])) return false;
                $routes[1] = lcfirst(str_replace(' ', '', ucwords(str_replace('-', ' ', $routes[1]))));
            }
            $index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
            $class = (class_exists($routes[0]))
                ? $routes[0]
                : $this->router->collection->getRoutes()['ctrl_namespace_' . $index] . $routes[0];
            if (!class_exists($class)) {
                throw new \Exception('Class "' . $class . '." is not found');
            }
            if (method_exists($class, $routes[1])) {
                return [
                    'dispatcher' => $this->dispatcher['isController'],
                    'di' => $this->router->getConfig()['di'],
                    'controller' => $class,
                    'action' => $routes[1]
                ];
            }
            if (!strpos($callback, '{method}') !== false) {
                throw new \Exception('The required method "' . $routes[1] . '" is not found in "' . $class . '"');
            }
        }
        return false;
    }

    /**
     * @param $callback
     * @throws \Exception
     * @return bool|array
     */
    public function isTemplate($callback)
    {
        if (is_string($callback) && strpos($callback, '@') === false) {
            $path = trim($callback, '/');
            $extension = substr(strrchr($path, "."), 1);
            $index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
            $viewDir = $this->router->collection->getRoutes('view_dir_' . $index);
            $target = null;
            if (in_array('.' . $extension, $this->router->getConfig()['templateExtension']) && (is_file($fullPath = $viewDir . $path) || is_file($fullPath = $path))) {
                $target = $fullPath;
            } else {
                foreach ($this->router->getConfig()['templateExtension'] as $ext) {
                    if (is_file($fullPath = $viewDir . $path . $ext) || is_file($fullPath = $path . $ext)) {
                        $target = $fullPath;
                        $extension = substr(strrchr($ext, "."), 1);
                        break;
                    }
                }
            }
            if (is_null($target)) {
                throw new \Exception('Template file "' . $path . '" is not found in "' . $viewDir . '"');
            }
            return [
                'dispatcher' => $this->dispatcher['isTemplate'],
                'template' => $target,
                'extension' => $extension,
                'callback' => $this->router->getConfig()['templateCallback']
            ];
        }
        return false;
    }

}


1		<?php
2
3		namespace JetFire\Routing\Matcher;
4
5
6		use JetFire\Routing\Dispatcher\ClosureDispatcher;
7		use JetFire\Routing\Dispatcher\ControllerDispatcher;
8		use JetFire\Routing\Dispatcher\TemplateDispatcher;
9		use JetFire\Routing\Router;
10
11		/**
12		* Class RoutesMatch
13		* @package JetFire\Routing\Match
14		*/
15		class ArrayMatcher implements MatcherInterface
16		{
17
18		/**
19		* @var
20		*/
21		private $router;
22
23		/**
24		* @var array
25		*/
26		private $request = [];
27
28		/**
29		* @var array
30		*/
31		private $resolver = ['isClosureAndTemplate', 'isControllerAndTemplate', 'isTemplate'];
32
33		/**
34		* @var array
35		*/
36		private $dispatcher = [
37		'isClosure' => ClosureDispatcher::class,
38		'isController' => ControllerDispatcher::class,
39		'isTemplate' => TemplateDispatcher::class,
40		'isControllerAndTemplate' => [ControllerDispatcher::class, TemplateDispatcher::class],
41		'isClosureAndTemplate' => [ClosureDispatcher::class, TemplateDispatcher::class],
42		];
43
44		/**
45		* @param Router $router
46		*/
47		public function __construct(Router $router)
48		{
49		$this->router = $router;
50		}
51
52		/**
53		* @param array $resolver
54		*/
55		public function setResolver($resolver = [])
56		{
57		$this->resolver = $resolver;
58		}
59
60		/**
61		* @param string $resolver
62		*/
63		public function addResolver($resolver)
64		{
65		$this->resolver[] = $resolver;
66		}
67
68		/**
69		* @return array
70		*/
71		public function getResolver()
72		{
73		return $this->resolver;
74		}
75
76		/**
77		* @param array $dispatcher
78		*/
79		public function setDispatcher($dispatcher = [])
80		{
81		$this->dispatcher = $dispatcher;
82		}
83
84		/**
85		* @param $method
86		* @param $class
87		* @internal param array $dispatcher
88		*/
89		public function addDispatcher($method, $class)
90		{
91		$this->dispatcher[$method] = $class;
92		}
93
94		/**
95		* @return bool
96		*/
97		public function match()
98		{
99		$this->request = [];
100		for ($i = 0; $i < $this->router->collection->countRoutes; ++$i) {
101		$this->request['prefix'] = ($this->router->collection->getRoutes('prefix_' . $i) != '') ? $this->router->collection->getRoutes('prefix_' . $i) : '';
102		$this->request['subdomain'] = ($this->router->collection->getRoutes('subdomain_' . $i) != '') ? $this->router->collection->getRoutes('subdomain_' . $i) : '';
103		foreach ($this->router->collection->getRoutes('routes_' . $i) as $route => $params) {
104		$this->request['params'] = $params;
105		$this->request['collection_index'] = $i;
106		if ($this->checkSubdomain($route)) {
107		$route = strstr($route, '/');
108		$this->request['route'] = preg_replace_callback('#:([\w]+)#', [$this, 'paramMatch'], '/' . trim(trim($this->request['prefix'], '/') . '/' . trim($route, '/'), '/'));
109		if ($this->routeMatch('#^' . $this->request['route'] . '$#')) {
110		$this->setCallback();
111		return $this->generateTarget();
112		}
113		}
114		}
115		}
116		return false;
117		}
118
119		/**
120		* @param $route
121		* @return bool
122		*/
123		private function checkSubdomain($route)
		0 ignored issues – show Coding Style introduced 2017-08-09 09:57 UTC by Report Bug Copy Issue Report `checkSubdomain` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
124		{
125		$url = (isset($_SERVER['REQUEST_SCHEME']) ? $_SERVER['REQUEST_SCHEME'] : 'http') . '://' . ($host = (isset($_SERVER['SERVER_NAME']) ? $_SERVER['SERVER_NAME'] : $_SERVER['HTTP_HOST']));
126		$host = explode(':', $host)[0];
127		$domain = $this->router->collection->getDomain($url);
128		if (!empty($this->request['subdomain']) && $route[0] == '/') $route = trim($this->request['subdomain'], '.') . '.' . $domain . $route;
129		if ($route[0] == '/') {
130		return ($host != $domain) ? false : true;
131		} elseif ($route[0] != '/' && $host != $domain) {
132		$route = substr($route, 0, strpos($route, "/"));
133		$route = str_replace('{host}', $domain, $route);
134		$route = preg_replace_callback('#{subdomain}#', [$this, 'subdomainMatch'], $route);
135		if (preg_match('#^' . $route . '$#', $host, $this->request['called_subdomain'])) {
136		$this->request['called_subdomain'] = array_shift($this->request['called_subdomain']);
137		$this->request['subdomain'] = str_replace('.' . $domain, '', $host);
138		return true;
139		}
140		}
141		return false;
142		}
143
144		/**
145		* @return string
146		*/
147		private function subdomainMatch()
148		{
149		if (is_array($this->request['params']) && isset($this->request['params']['subdomain'])) {
150		return '(' . $this->request['params']['subdomain'] . ')';
151		}
152		return '([^/]+)';
153		}
154
155		/**
156		* @param $match
157		* @return string
158		*/
159		private function paramMatch($match)
160		{
161		if (is_array($this->request['params']) && isset($this->request['params']['arguments'][$match[1]])) {
162		$this->request['params']['arguments'][$match[1]] = str_replace('(', '(?:', $this->request['params']['arguments'][$match[1]]);
163		return '(' . $this->request['params']['arguments'][$match[1]] . ')';
164		}
165		return '([^/]+)';
166		}
167
168		/**
169		* @param $regex
170		* @return bool
171		*/
172		private function routeMatch($regex)
173		{
174		$regex = (substr($this->request['route'], -1) == '*') ? '#^' . $this->request['route'] . '#' : $regex;
175		if (preg_match($regex, $this->router->route->getUrl(), $this->request['parameters'])) {
176		array_shift($this->request['parameters']);
177		return true;
178		}
179		return false;
180		}
181
182		/**
183		* @return bool
184		*/
185		private function generateTarget()
186		{
187		if ($this->validMethod()) {
188		foreach ($this->resolver as $resolver) {
189		if (is_array($target = call_user_func_array([$this, $resolver], [$this->router->route->getCallback()]))) {
190		$this->setTarget($target);
191		return true;
192		}
193		}
194		}
195		$this->router->response->setStatusCode(405);
196		return false;
197		}
198
199		/**
200		* @param array $target
201		*/
202		public function setTarget($target = [])
203		{
204		$index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
205		$this->checkRequest('subdomain');
206		$this->checkRequest('prefix');
207		$this->router->route->setDetail($this->request);
208		$this->router->route->setTarget($target);
209		$this->router->route->addTarget('block', $this->router->collection->getRoutes('block_' . $index));
210		$this->router->route->addTarget('view_dir', $this->router->collection->getRoutes('view_dir_' . $index));
211		$this->router->route->addTarget('params', $this->router->collection->getRoutes('params_' . $index));
212		}
213
214		/**
215		* @param $key
216		*/
217		private function checkRequest($key)
218		{
219		if (strpos($this->request[$key], ':') !== false && isset($this->request['parameters'][0])) {
220		$replacements = $this->request['parameters'];
221		$keys = [];
222		$this->request['@' . $key] = $this->request[$key];
223		$this->request[$key] = preg_replace_callback('#:([\w]+)#', function ($matches) use (&$replacements, &$keys) {
224		$keys[$matches[0]] = $replacements[0];
225		return array_shift($replacements);
226		}, $this->request[$key]);
227		$this->request['keys'] = $keys;
228		$this->request['parameters'] = $replacements;
229		}
230		}
231
232		/**
233		*
234		*/
235		private function setCallback()
236		{
237		if (isset($this->request['params'])) {
238		if (is_callable($this->request['params'])) {
239		$this->router->route->setCallback($this->request['params']);
240		} else {
241		if (is_array($this->request['params']) && isset($this->request['params']['use'])) {
242		if (is_array($this->request['params']['use']) && isset($this->request['params']['use'][$this->router->route->getMethod()])) {
243		$this->router->route->setCallback($this->request['params']['use'][$this->router->route->getMethod()]);
244		} elseif (!is_array($this->request['params']['use'])) {
245		$this->router->route->setCallback($this->request['params']['use']);
246		}
247		} else {
248		$this->router->route->setCallback($this->request['params']);
249		}
250		if (isset($this->request['params']['name'])) {
251		$this->router->route->setName($this->request['params']['name']);
252		}
253		if (isset($this->request['params']['method'])) {
254		$this->request['params']['method'] = is_array($this->request['params']['method']) ? $this->request['params']['method'] : [$this->request['params']['method']];
255		}
256		}
257		}
258		}
259
260		/**
261		* @return bool
262		*/
263		public function validMethod()
		0 ignored issues – show Coding Style introduced 2017-08-09 09:57 UTC by Report Bug Copy Issue Report `validMethod` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
264		{
265		if (is_callable($this->request['params'])) {
266		return true;
267		}
268		if (!empty($_SERVER['HTTP_X_REQUESTED_WITH']) && strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest') {
269		return (isset($this->request['params']['ajax']) && $this->request['params']['ajax'] === true) ? true : false;
270		}
271		$method = (isset($this->request['params']['method'])) ? $this->request['params']['method'] : ['GET'];
272		return (in_array($this->router->route->getMethod(), $method)) ? true : false;
273		}
274
275		/**
276		* @param $callback
277		* @return array\|bool
278		* @throws \Exception
279		*/
280	View Code Duplication	public function isClosureAndTemplate($callback)
		0 ignored issues – show Duplication introduced 2017-08-09 09:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
281		{
282		if (is_array($cls = $this->isClosure($callback))) {
283		if (is_array($this->request['params']) && isset($this->request['params']['template']) && is_array($tpl = $this->isTemplate($this->request['params']['template']))) {
284		return array_merge(array_merge($cls, $tpl), [
285		'dispatcher' => $this->dispatcher['isClosureAndTemplate']
286		]);
287		}
288		return $cls;
289		}
290		return false;
291		}
292
293		/**
294		* @param $callback
295		* @return array\|bool
296		* @throws \Exception
297		*/
298	View Code Duplication	public function isControllerAndTemplate($callback)
		0 ignored issues – show Duplication introduced 2017-08-09 09:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
299		{
300		if (is_array($ctrl = $this->isController($callback))) {
301		if (is_array($this->request['params']) && isset($this->request['params']['template']) && is_array($tpl = $this->isTemplate($this->request['params']['template']))) {
302		return array_merge(array_merge($ctrl, $tpl), [
303		'dispatcher' => $this->dispatcher['isControllerAndTemplate']
304		]);
305		}
306		return $ctrl;
307		}
308		return false;
309		}
310
311
312		/**
313		* @param $callback
314		* @return bool\|array
315		*/
316		public function isClosure($callback)
317		{
318		if (is_callable($callback)) {
319		return [
320		'dispatcher' => $this->dispatcher['isClosure'],
321		'closure' => $callback
322		];
323		}
324		return false;
325		}
326
327		/**
328		* @param $callback
329		* @throws \Exception
330		* @return bool\|array
331		*/
332		public function isController($callback)
333		{
334		if (is_string($callback) && strpos($callback, '@') !== false) {
335		$routes = explode('@', $callback);
336		if (!isset($routes[1])) $routes[1] = 'index';
337		if ($routes[1] == '{method}') {
338		$params = explode('/', preg_replace('#' . str_replace('*', '', $this->request['route']) . '#', '', $this->router->route->getUrl()));
339		$routes[1] = $params[0];
340		array_shift($params);
341		array_merge($this->request['parameters'], $params);
342		if (preg_match('/[A-Z]/', $routes[1])) return false;
343		$routes[1] = lcfirst(str_replace(' ', '', ucwords(str_replace('-', ' ', $routes[1]))));
344		}
345		$index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
346		$class = (class_exists($routes[0]))
347		? $routes[0]
348		: $this->router->collection->getRoutes()['ctrl_namespace_' . $index] . $routes[0];
349		if (!class_exists($class)) {
350		throw new \Exception('Class "' . $class . '." is not found');
351		}
352		if (method_exists($class, $routes[1])) {
353		return [
354		'dispatcher' => $this->dispatcher['isController'],
355		'di' => $this->router->getConfig()['di'],
356		'controller' => $class,
357		'action' => $routes[1]
358		];
359		}
360		if (!strpos($callback, '{method}') !== false) {
361		throw new \Exception('The required method "' . $routes[1] . '" is not found in "' . $class . '"');
362		}
363		}
364		return false;
365		}
366
367		/**
368		* @param $callback
369		* @throws \Exception
370		* @return bool\|array
371		*/
372		public function isTemplate($callback)
373		{
374		if (is_string($callback) && strpos($callback, '@') === false) {
375		$path = trim($callback, '/');
376		$extension = substr(strrchr($path, "."), 1);
377		$index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
378		$viewDir = $this->router->collection->getRoutes('view_dir_' . $index);
379		$target = null;
380		if (in_array('.' . $extension, $this->router->getConfig()['templateExtension']) && (is_file($fullPath = $viewDir . $path) \|\| is_file($fullPath = $path))) {
381		$target = $fullPath;
382		} else {
383		foreach ($this->router->getConfig()['templateExtension'] as $ext) {
384		if (is_file($fullPath = $viewDir . $path . $ext) \|\| is_file($fullPath = $path . $ext)) {
385		$target = $fullPath;
386		$extension = substr(strrchr($ext, "."), 1);
387		break;
388		}
389		}
390		}
391		if (is_null($target)) {
392		throw new \Exception('Template file "' . $path . '" is not found in "' . $viewDir . '"');
393		}
394		return [
395		'dispatcher' => $this->dispatcher['isTemplate'],
396		'template' => $target,
397		'extension' => $extension,
398		'callback' => $this->router->getConfig()['templateCallback']
399		];
400		}
401		return false;
402		}
403
404		}
405

jetfirephp / routing