jetfirephp / routing

src/Routing/Response.php

Braces +3 added lines, -2 removed lines

@@ -166,8 +166,9 @@
      */
     public function sendHeaders()
     {
-        foreach($this->headers as $key => $content)
-            header($key.' : '.$content);
+        foreach($this->headers as $key => $content) {

+                    header($key.' : '.$content);

+        }

         http_response_code($this->getStatusCode());
         return $this;
     }

src/Routing/Route.php

Braces +18 added lines, -8 removed lines

@@ -52,10 +52,18 @@ 
      */
     public function set($args = [])
     {
-        if (isset($args['name'])) $this->name = $args['name'];
-        if (isset($args['callback'])) $this->callback = $args['callback'];
-        if (isset($args['target'])) $this->target = $args['target'];
-        if (isset($args['detail'])) $this->detail = $args['detail'];
+        if (isset($args['name'])) {

+            $this->name = $args['name'];

+        }

+        if (isset($args['callback'])) {

+            $this->callback = $args['callback'];

+        }

+        if (isset($args['target'])) {

+            $this->target = $args['target'];

+        }

+        if (isset($args['detail'])) {

+            $this->detail = $args['detail'];

+        }

     }
 
     /**
@@ -145,8 +153,9 @@ 
      */
     public function getTarget($key = null)
     {
-        if (!is_null($key))
-            return isset($this->target[$key]) ? $this->target[$key] : '';
+        if (!is_null($key)) {

+                    return isset($this->target[$key]) ? $this->target[$key] : '';

+        }

         return empty($this->target) ? '' : $this->target;
     }
 
@@ -165,8 +174,9 @@ 
      */
     public function hasTarget($key = null)
     {
-        if (!is_null($key))
-            return isset($this->target[$key]) ? true : false;
+        if (!is_null($key)) {

+                    return isset($this->target[$key]) ? true : false;

+        }

         return empty($this->target) ? false : true;
     }
 

src/Routing/Matcher/UriMatcher.php

Braces +3 added lines, -2 removed lines

@@ -90,8 +90,9 @@
         foreach($this->resolver as $resolver){
             if(is_array($target = call_user_func([$this,$resolver]))) {
                 $this->setTarget($target);
-                if($this->router->middleware->globalMiddleware() === false || $this->router->middleware->blockMiddleware() === false || $this->router->middleware->classMiddleware() === false || $this->router->middleware->routeMiddleware() === false)
-                    return null;
+                if($this->router->middleware->globalMiddleware() === false || $this->router->middleware->blockMiddleware() === false || $this->router->middleware->classMiddleware() === false || $this->router->middleware->routeMiddleware() === false) {

+                                    return null;

+                }

                 $this->router->response->setStatusCode(202);
                 return true;
             }

src/Routing/Middleware.php

Braces +35 added lines, -26 removed lines

@@ -29,9 +29,10 @@ 
      */
     public function globalMiddleware()
     {
-        if (isset($this->router->collection->middleware['global_middleware']))
-            foreach ($this->router->collection->middleware['global_middleware'] as $class)
-                if (class_exists($class)) return $this->callHandler($class);
+        if (isset($this->router->collection->middleware['global_middleware'])) {

+                    foreach ($this->router->collection->middleware['global_middleware'] as $class)
+                if (class_exists($class)) return $this->callHandler($class);

+        }

         return null;
     }
 
@@ -40,16 +41,18 @@ 
      */
     public function blockMiddleware()
     {
-        if (isset($this->router->collection->middleware['block_middleware']))
-            if (isset($this->router->collection->middleware['block_middleware'][$this->router->route->getTarget('block')])) {
-                $blocks = $this->router->collection->middleware['block_middleware'][$this->router->route->getTarget('block')];
+        if (isset($this->router->collection->middleware['block_middleware'])) {

+                    if (isset($this->router->collection->middleware['block_middleware'][$this->router->route->getTarget('block')])) {
+                $blocks = $this->router->collection->middleware['block_middleware'][$this->router->route->getTarget('block')];

+        }

                 if (is_array($blocks)) {
-                    foreach ($blocks as $block)
-                        if (class_exists($block))
-                            if($this->callHandler($block) === false) return false;
-                }
-                elseif (is_string($blocks) && class_exists($blocks))
-                    return $this->callHandler($blocks);
+                    foreach ($blocks as $block) {

+                                            if (class_exists($block))
+                            if($this->callHandler($block) === false) return false;

+                    }

+                } elseif (is_string($blocks) && class_exists($blocks)) {

+                                    return $this->callHandler($blocks);

+                }

             }
         return null;
     }
@@ -64,10 +67,12 @@ 
             if (isset($this->router->collection->middleware['class_middleware'][$ctrl]) && class_exists($this->router->route->getTarget('controller'))) {
                 $classes = $this->router->collection->middleware['class_middleware'][$ctrl];
                 if(is_array($classes)){
-                    foreach ($classes as $class)
-                        if($this->callHandler($class) === false)return false;
-                }elseif(is_string($classes))
-                    return $this->callHandler($classes);
+                    foreach ($classes as $class) {

+                                            if($this->callHandler($class) === false)return false;

+                    }

+                } elseif(is_string($classes)) {

+                                    return $this->callHandler($classes);

+                }

             }
         }
         return null;
@@ -78,14 +83,17 @@ 
      */
     public function routeMiddleware()
     {
-        if (isset($this->router->collection->middleware['route_middleware']))
-            if (isset($this->router->route->getPath()['middleware']) && class_exists($this->router->collection->middleware['route_middleware'][$this->router->route->getPath()['middleware']])) {
-                $classes = $this->router->collection->middleware['route_middleware'][$this->router->route->getPath()['middleware']];
+        if (isset($this->router->collection->middleware['route_middleware'])) {

+                    if (isset($this->router->route->getPath()['middleware']) && class_exists($this->router->collection->middleware['route_middleware'][$this->router->route->getPath()['middleware']])) {
+                $classes = $this->router->collection->middleware['route_middleware'][$this->router->route->getPath()['middleware']];

+        }

                 if(is_array($classes)){
-                    foreach ($classes as $class)
-                        if($this->callHandler($class) === false)return false;
-                }elseif(is_string($classes))
-                    return $this->callHandler($classes);
+                    foreach ($classes as $class) {

+                                            if($this->callHandler($class) === false)return false;

+                    }

+                } elseif(is_string($classes)) {

+                                    return $this->callHandler($classes);

+                }

             }
         return null;
     }
@@ -99,9 +107,10 @@ 
         if (method_exists($instance, 'handle')) {
             $reflectionMethod = new ReflectionMethod($instance, 'handle');
             $dependencies = [];
-            foreach ($reflectionMethod->getParameters() as $arg)
-                if (!is_null($arg->getClass()))
-                    $dependencies[] = $this->getClass($arg->getClass()->name);
+            foreach ($reflectionMethod->getParameters() as $arg) {

+                            if (!is_null($arg->getClass()))
+                    $dependencies[] = $this->getClass($arg->getClass()->name);

+            }

             $dependencies = array_merge($dependencies, [$this->router->route]);
             return $reflectionMethod->invokeArgs($instance, $dependencies);
         }

src/Routing/Router.php

Braces +25 added lines, -12 removed lines

@@ -83,8 +83,9 @@ 
      */
     public function setMatcher($matcher)
     {
-        if (is_object($matcher))
-            $matcher = [$matcher];
+        if (is_object($matcher)) {

+                    $matcher = [$matcher];

+        }

         $this->matcher = $matcher;
     }
 
@@ -102,8 +103,12 @@ 
     public function run()
     {
         $this->setUrl();
-        if ($this->config['generateRoutesPath']) $this->collection->generateRoutesPath();
-        if ($this->match()) $this->callTarget();
+        if ($this->config['generateRoutesPath']) {

+            $this->collection->generateRoutesPath();

+        }

+        if ($this->match()) {

+            $this->callTarget();

+        }

         $this->callResponse();
     }
 
@@ -112,8 +117,9 @@ 
      */
     public function setUrl($url = null)
     {
-        if (is_null($url))
-            $url = (isset($_GET['url'])) ? $_GET['url'] : substr(str_replace(str_replace('/index.php', '', $_SERVER['SCRIPT_NAME']), '', $_SERVER['REQUEST_URI']), 1);
+        if (is_null($url)) {

+                    $url = (isset($_GET['url'])) ? $_GET['url'] : substr(str_replace(str_replace('/index.php', '', $_SERVER['SCRIPT_NAME']), '', $_SERVER['REQUEST_URI']), 1);

+        }

         $this->route->setUrl('/' . trim(explode('?', $url)[0], '/'));
     }
 
@@ -123,7 +129,9 @@ 
     public function match()
     {
         foreach ($this->matcher as $key => $matcher) {
-            if (call_user_func([$this->matcher[$key], 'match'])) return true;
+            if (call_user_func([$this->matcher[$key], 'match'])) {

+                return true;

+            }

         }
         return false;
     }
@@ -158,11 +166,16 @@ 
         if (isset($this->route->getDetail()['response_templates']) && isset($this->route->getDetail()['response_templates'][$code = $this->response->getStatusCode()])) {
             $this->route->setCallback($this->route->getDetail()['response_templates'][$code]);
             $matcher = null;
-            foreach ($this->matcher as $instance) if ($instance instanceof ArrayMatcher) $matcher = $instance;
-            if (is_null($matcher)) $matcher = new ArrayMatcher($this);
-            foreach (call_user_func([$matcher, 'getResolver']) as $match)
-                if (is_array($target = call_user_func_array([$matcher, $match], [$this->route->getCallback()]))) {
-                    call_user_func_array([$matcher, 'setTarget'], [$target]);
+            foreach ($this->matcher as $instance) {

+                if ($instance instanceof ArrayMatcher) $matcher = $instance;

+            }

+            if (is_null($matcher)) {

+                $matcher = new ArrayMatcher($this);

+            }

+            foreach (call_user_func([$matcher, 'getResolver']) as $match) {

+                            if (is_array($target = call_user_func_array([$matcher, $match], [$this->route->getCallback()]))) {
+                    call_user_func_array([$matcher, 'setTarget'], [$target]);

+            }

                     $this->callTarget();
                     break;
                 }

src/Routing/Dispatcher/TemplateDispatcher.php

Braces +12 added lines, -7 removed lines

@@ -47,14 +47,19 @@
      */
     public function call()
     {
-        if ($this->response->getStatusCode() == 202)
-            $this->setContentType($this->route->getTarget('extension'));
-        if (isset($this->route->getTarget('callback')[$this->route->getTarget('extension')]))
-            $this->response->setContent(call_user_func_array($this->route->getTarget('callback')[$this->route->getTarget('extension')], [$this->route]));
-        else {
+        if ($this->response->getStatusCode() == 202) {

+                    $this->setContentType($this->route->getTarget('extension'));

+        }

+        if (isset($this->route->getTarget('callback')[$this->route->getTarget('extension')])) {

+                    $this->response->setContent(call_user_func_array($this->route->getTarget('callback')[$this->route->getTarget('extension')], [$this->route]));

+        } else {
             ob_start();
-            if (isset($this->route->getTarget()['data'])) extract($this->route->getTarget('data'));
-            if (isset($this->route->getParams()['data'])) extract($this->route->getParams()['data']);
+            if (isset($this->route->getTarget()['data'])) {

+                extract($this->route->getTarget('data'));

+            }

+            if (isset($this->route->getParams()['data'])) {

+                extract($this->route->getParams()['data']);

+            }

             require($this->route->getTarget('template'));
             $this->response->setContent(ob_get_clean());
         }

src/Routing/Dispatcher/ClosureDispatcher.php

Braces +5 added lines, -2 removed lines

@@ -43,8 +43,11 @@
             $this->response->setHeaders(['Content-Type' => 'text/html']);
         }
         $params = ($this->route->getParameters() == '') ? [] : $this->route->getParameters();
-        if (is_array($content = call_user_func_array($this->route->getTarget('closure'), $params))) $this->route->addTarget('data', $content);
-        elseif (!is_null($content)) $this->response->setContent($content);
+        if (is_array($content = call_user_func_array($this->route->getTarget('closure'), $params))) {

+            $this->route->addTarget('data', $content);

+        } elseif (!is_null($content)) {

+            $this->response->setContent($content);

+        }

     }
 
 }

src/Routing/Dispatcher/ControllerDispatcher.php

Braces +12 added lines, -7 removed lines

@@ -50,17 +50,21 @@ 
         }
         if ($count == count($this->route->getParameters()) || ($this->route->getParameters() == '' && $count == 0)) {
             $dependencies = array_merge($dependencies, ($this->route->getParameters() == '') ? [] : $this->route->getParameters());
-            if ($this->response->getStatusCode() == 202)
-                $this->response->setStatusCode(200);
+            if ($this->response->getStatusCode() == 202) {

+                            $this->response->setStatusCode(200);

+            }

             if (is_array($content = $reflectionMethod->invokeArgs($this->getController(), $dependencies))) {
                 $this->route->addTarget('data', $content);
                 if (isset($this->route->getParams()['ajax']) && $this->route->getParams()['ajax'] === true) {
                     $this->response->setContent(json_encode($content));
                     $this->response->setHeaders(['Content-Type' => 'application/json']);
                 }
-            } elseif (!is_null($content)) $this->response->setContent($content);
-        } else
-            $this->response->setStatusCode(404);
+            } elseif (!is_null($content)) {

+                $this->response->setContent($content);

+            }

+        } else {

+                    $this->response->setStatusCode(404);

+        }

     }
 
 
@@ -71,8 +75,9 @@ 
     private function getController()
     {
         $reflector = new ReflectionClass($this->route->getTarget('controller'));
-        if (!$reflector->isInstantiable())
-            throw new \Exception('Target [' . $this->route->getTarget('controller') . '] is not instantiable.');
+        if (!$reflector->isInstantiable()) {

+                    throw new \Exception('Target [' . $this->route->getTarget('controller') . '] is not instantiable.');

+        }

         $constructor = $reflector->getConstructor();
         if (is_null($constructor)) {
             $class = $this->route->getTarget('controller');

src/Routing/Matcher/ArrayMatcher.php

Braces +46 added lines, -26 removed lines

@@ -102,7 +102,9 @@ 
                     $this->request['route'] = preg_replace_callback('#:([\w]+)#', [$this, 'paramMatch'], '/' . trim(trim($this->request['prefix'], '/') . '/' . trim($route, '/'), '/'));
                     if ($this->routeMatch('#^' . $this->request['route'] . '$#')) {
                         $this->setCallback();
-                        if(!is_null($response = $this->generateTarget())) return $response;
+                        if(!is_null($response = $this->generateTarget())) {

+                            return $response;

+                        }

                     }
                 }
             }
@@ -118,10 +120,12 @@ 
         $url = (isset($_SERVER['REQUEST_SCHEME']) ? $_SERVER['REQUEST_SCHEME'] : 'http') . '://' . ($host = (isset($_SERVER['SERVER_NAME']) ? $_SERVER['SERVER_NAME'] : $_SERVER['HTTP_HOST']));
         $host = explode(':',$host)[0];
         $domain = $this->router->collection->getDomain($url);
-        if(!empty($this->request['subdomain']) && $route[0] == '/') $route = trim($this->request['subdomain'],'.').'.'.$domain.$route;
+        if(!empty($this->request['subdomain']) && $route[0] == '/') {

+            $route = trim($this->request['subdomain'],'.').'.'.$domain.$route;

+        }

         if($route[0] == '/'){
             return ($host != $domain) ? false : true;
-        }elseif($route[0] != '/' && $host != $domain){
+        } elseif($route[0] != '/' && $host != $domain){
             $route = substr($route, 0, strpos($route, "/"));
             $route = str_replace('{host}', $domain, $route);
             $route = preg_replace_callback('#{subdomain}#', [$this, 'subdomainMatch'], $route);
@@ -166,8 +170,9 @@ 
     {
         if (substr($this->request['route'], -1) == '*') {
             $pos = strpos($this->request['route'], '*');
-            if (substr($this->router->route->getUrl(), 0, $pos) == substr($this->request['route'], 0, $pos) && isset($this->request['params']))
-                return true;
+            if (substr($this->router->route->getUrl(), 0, $pos) == substr($this->request['route'], 0, $pos) && isset($this->request['params'])) {

+                            return true;

+            }

         }
         if (preg_match($regex, $this->router->route->getUrl(), $this->request['parameters'])) {
             array_shift($this->request['parameters']);
@@ -185,8 +190,9 @@ 
             foreach ($this->resolver as $resolver) {
                 if (is_array($target = call_user_func_array([$this, $resolver], [$this->router->route->getCallback()]))) {
                     $this->setTarget($target);
-                    if ($this->router->middleware->globalMiddleware() === false || $this->router->middleware->blockMiddleware() === false || $this->router->middleware->classMiddleware() === false || $this->router->middleware->routeMiddleware() === false)
-                        return null;
+                    if ($this->router->middleware->globalMiddleware() === false || $this->router->middleware->blockMiddleware() === false || $this->router->middleware->classMiddleware() === false || $this->router->middleware->routeMiddleware() === false) {

+                                            return null;

+                    }

                     $this->router->response->setStatusCode(202);
                     return true;
                 }
@@ -213,14 +219,18 @@ 
      */
     private function setCallback(){
         if (isset($this->request['params'])) {
-            if(is_callable($this->request['params']))
-                $this->router->route->setCallback($this->request['params']);
-            else {
+            if(is_callable($this->request['params'])) {

+                            $this->router->route->setCallback($this->request['params']);

+            } else {
                 (is_array($this->request['params']) && isset($this->request['params']['use']))
                     ? $this->router->route->setCallback($this->request['params']['use'])
                     : $this->router->route->setCallback($this->request['params']);
-                if (isset($this->request['params']['name'])) $this->router->route->setName($this->request['params']['name']);
-                if (isset($this->request['params']['method'])) $this->request['params']['method'] = is_array($this->request['params']['method']) ? $this->request['params']['method'] : [$this->request['params']['method']];
+                if (isset($this->request['params']['name'])) {

+                    $this->router->route->setName($this->request['params']['name']);

+                }

+                if (isset($this->request['params']['method'])) {

+                    $this->request['params']['method'] = is_array($this->request['params']['method']) ? $this->request['params']['method'] : [$this->request['params']['method']];

+                }

             }
         }
     }
@@ -230,9 +240,12 @@ 
      */
     public function validMethod()
     {
-        if(is_callable($this->request['params']))return true;
-        if (!empty($_SERVER['HTTP_X_REQUESTED_WITH']) && strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest')
-            return (isset($this->request['params']['ajax']) && $this->request['params']['ajax'] === true) ? true : false;
+        if(is_callable($this->request['params'])) {

+            return true;

+        }

+        if (!empty($_SERVER['HTTP_X_REQUESTED_WITH']) && strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest') {

+                    return (isset($this->request['params']['ajax']) && $this->request['params']['ajax'] === true) ? true : false;

+        }

         $method = (isset($this->request['params']['method'])) ? $this->request['params']['method'] : ['GET'];
         return (in_array($this->router->route->getMethod(), $method)) ? true : false;
     }
@@ -296,20 +309,25 @@ 
     {
         if (is_string($callback) && strpos($callback, '@') !== false) {
             $routes = explode('@', $callback);
-            if (!isset($routes[1])) $routes[1] = 'index';
+            if (!isset($routes[1])) {

+                $routes[1] = 'index';

+            }

             if ($routes[1] == '{method}'){
                 $this->request['parameters'] = explode('/',str_replace(str_replace('*','',$this->request['route']),'',$this->router->route->getUrl()));
                 $routes[1] = $this->request['parameters'][0];
                 array_shift($this->request['parameters']);
-                if(preg_match('/[A-Z]/', $routes[1])) return false;
+                if(preg_match('/[A-Z]/', $routes[1])) {

+                    return false;

+                }

                 $routes[1] = lcfirst(str_replace(' ','',ucwords(str_replace('-',' ',$routes[1]))));
             }
             $index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
             $class = (class_exists($routes[0]))
                 ? $routes[0]
                 : $this->router->collection->getRoutes()['ctrl_namespace_' . $index] . $routes[0];
-            if (!class_exists($class))
-                throw new \Exception('Class "' . $class . '." is not found');
+            if (!class_exists($class)) {

+                            throw new \Exception('Class "' . $class . '." is not found');

+            }

             if (method_exists($class, $routes[1])) {
                 return [
                     'dispatcher' => $this->dispatcher['isController'],
@@ -318,8 +336,9 @@ 
                     'action' => $routes[1]
                 ];
             }
-            if (!strpos($callback, '{method}') !== false)
-                throw new \Exception('The required method "' . $routes[1] . '" is not found in "' . $class . '"');
+            if (!strpos($callback, '{method}') !== false) {

+                            throw new \Exception('The required method "' . $routes[1] . '" is not found in "' . $class . '"');

+            }

         }
         return false;
     }
@@ -337,9 +356,9 @@ 
             $index = isset($this->request['collection_index']) ? $this->request['collection_index'] : 0;
             $viewDir = $this->router->collection->getRoutes('view_dir_' . $index);
             $target = null;
-            if (in_array('.' . $extension, $this->router->getConfig()['templateExtension']) && (is_file($fullPath = $viewDir . $path) || is_file($fullPath = $path)))
-                $target = $fullPath;
-            else {
+            if (in_array('.' . $extension, $this->router->getConfig()['templateExtension']) && (is_file($fullPath = $viewDir . $path) || is_file($fullPath = $path))) {

+                            $target = $fullPath;

+            } else {
                 foreach ($this->router->getConfig()['templateExtension'] as $ext) {
                     if (is_file($fullPath = $viewDir . $path . $ext) || is_file($fullPath = $path . $ext)) {
                         $target = $fullPath;
@@ -348,8 +367,9 @@ 
                     }
                 }
             }
-            if(is_null($target))
-                throw new \Exception('Template file "' . $path . '" is not found in "' . $viewDir . '"');
+            if(is_null($target)) {

+                            throw new \Exception('Template file "' . $path . '" is not found in "' . $viewDir . '"');

+            }

             return [
                 'dispatcher' => $this->dispatcher['isTemplate'],
                 'template'   => $target,