Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | class Middleware implements MiddlewareInterface |
||
13 | { |
||
14 | |||
15 | /** |
||
16 | * @var Router |
||
17 | */ |
||
18 | private $router; |
||
19 | |||
20 | /** |
||
21 | * @var array |
||
22 | */ |
||
23 | protected $callbacks = [ |
||
24 | 'globalMiddleware', |
||
25 | 'blockMiddleware', |
||
26 | 'classMiddleware', |
||
27 | 'routeMiddleware', |
||
28 | ]; |
||
29 | |||
30 | /** |
||
31 | * @var array |
||
32 | */ |
||
33 | private $middleware = []; |
||
34 | |||
35 | /** |
||
36 | * @param Router $router |
||
37 | */ |
||
38 | public function __construct(Router $router) |
||
42 | |||
43 | /** |
||
44 | * @return array |
||
45 | */ |
||
46 | public function getMiddleware() |
||
50 | |||
51 | /** |
||
52 | * @param $middleware |
||
53 | * @return mixed|void |
||
54 | */ |
||
55 | public function setBeforeCallback($middleware) |
||
59 | |||
60 | /** |
||
61 | * @param $middleware |
||
62 | * @return mixed|void |
||
63 | */ |
||
64 | public function setAfterCallback($middleware) |
||
68 | |||
69 | /** |
||
70 | * @param $action |
||
71 | * @param $middleware |
||
72 | */ |
||
73 | private function setMiddleware($action, $middleware) |
||
86 | |||
87 | /** |
||
88 | * @return Router |
||
89 | */ |
||
90 | public function getCallbacks() |
||
94 | |||
95 | /** |
||
96 | * @description global middleware |
||
97 | * @param $action |
||
98 | */ |
||
99 | public function globalMiddleware($action) |
||
105 | |||
106 | /** |
||
107 | * @description block middleware |
||
108 | * @param $action |
||
109 | */ |
||
110 | public function blockMiddleware($action) |
||
119 | |||
120 | /** |
||
121 | * @description controller middleware |
||
122 | * @param $action |
||
123 | */ |
||
124 | public function classMiddleware($action) |
||
134 | |||
135 | /** |
||
136 | * @description route middleware |
||
137 | * @param $action |
||
138 | */ |
||
139 | public function routeMiddleware($action) |
||
148 | |||
149 | /** |
||
150 | * @param $handlers |
||
151 | */ |
||
152 | private function callHandlers($handlers){ |
||
160 | |||
161 | /** |
||
162 | * @param $callback |
||
163 | * @return mixed |
||
164 | */ |
||
165 | private function handle($callback) |
||
189 | |||
190 | /** |
||
191 | * @param $class |
||
192 | * @return Route|RouteCollection|Router|mixed |
||
193 | */ |
||
194 | private function getClass($class) |
||
209 | } |
||
210 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.