ControllerDispatcher::call() - Code Metrics - Inspection of "remove comments + fix middleware" - jetfirephp/routing - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( beba29...2cba6a )

by Sinnarasa

created 2017-07-16 17:53 UTC

ControllerDispatcher::call() D

↳ Parent: ControllerDispatcher

Complexity

Conditions	10
Paths	16

Size

Total Lines	39
Code Lines	28

Duplication

Lines	9
Ratio	23.08 %

Importance

Changes

Metric	Value
dl	9
loc	39
rs	4.8196
c	0
b	0
f	0
cc	10
eloc	28
nc	16
nop	0

How to fix Complexity

<?php

namespace JetFire\Routing\Dispatcher;

use JetFire\Routing\Response;
use JetFire\Routing\ResponseInterface;
use JetFire\Routing\Route;
use JetFire\Routing\RouteCollection;
use JetFire\Routing\Router;
use ReflectionClass;
use ReflectionMethod;

/**
 * Class ControllerDispatcher
 * @package JetFire\Routing\Dispatcher
 */
class ControllerDispatcher implements DispatcherInterface
{

    /**
     * @var Router
     */
    private $router;


    /**
     * @param Router $router
     */
    public function __construct(Router $router)
    {
        $this->router = $router;
    }


    /**
     * @throws \Exception
     */
    public function call()
    {
        $classInstance = [
            Route::class => $this->router->route,
            Response::class => $this->router->response,
            RouteCollection::class => $this->router->collection,
        ];
        
        $reflectionMethod = new ReflectionMethod($this->router->route->getTarget('controller'), $this->router->route->getTarget('action'));
        $dependencies = [];
        $count = 0;

        foreach ($reflectionMethod->getParameters() as $arg) {
            if (!is_null($arg->getClass())) {
                if (isset($classInstance[$arg->getClass()->name]))
                $dependencies[] = $classInstance[$arg->getClass()->name];
            else
                $dependencies[] = call_user_func_array($this->router->route->getTarget('di'), [$arg->getClass()->name]);
            } else {
                $count++;
            }
        }

        if ($count == count($this->router->route->getParameters()) || ($this->router->route->getParameters() == '' && $count == 0)) {
            $dependencies = array_merge($dependencies, ($this->router->route->getParameters() == '') ? [] : $this->router->route->getParameters());
            $content = $reflectionMethod->invokeArgs($this->getController($classInstance), $dependencies);
            if ($content instanceof ResponseInterface) {

                $this->router->response = $content;
            } else {
                if (is_array($content)) {
                    $this->router->route->addTarget('data', $content);
                    $content = json_encode($content);
                }
                $this->router->response->setContent($content);
            }
        } else {
            $this->router->response->setStatusCode(404);
        }
    }


    /**
     * @param array $classInstance
     * @return object
     * @throws \Exception
     */
    private function getController($classInstance = [])
    {
        $reflector = new ReflectionClass($this->router->route->getTarget('controller'));
        if (!$reflector->isInstantiable()) {
            throw new \Exception('Target [' . $this->router->route->getTarget('controller') . '] is not instantiable.');
        }
        $constructor = $reflector->getConstructor();
        if (is_null($constructor)) {
            $class = $this->router->route->getTarget('controller');
            return call_user_func_array($this->router->route->getTarget('di'), [$class]);
        }
        $dependencies = [];
        foreach ($constructor->getParameters() as $dep) {
            $class = $dep->getClass()->name;
            if (isset($classInstance[$class])) {
                $dependencies[] = $classInstance[$class];
            } else {
                $dependencies[] = call_user_func_array($this->router->route->getTarget('di'), [$class]);
            }
        }
        return $reflector->newInstanceArgs($dependencies);
    }

}


1		<?php
2
3		namespace JetFire\Routing\Dispatcher;
4
5		use JetFire\Routing\Response;
6		use JetFire\Routing\ResponseInterface;
7		use JetFire\Routing\Route;
8		use JetFire\Routing\RouteCollection;
9		use JetFire\Routing\Router;
10		use ReflectionClass;
11		use ReflectionMethod;
12
13		/**
14		* Class ControllerDispatcher
15		* @package JetFire\Routing\Dispatcher
16		*/
17		class ControllerDispatcher implements DispatcherInterface
18		{
19
20		/**
21		* @var Router
22		*/
23		private $router;
24
25
26		/**
27		* @param Router $router
28		*/
29		public function __construct(Router $router)
30		{
31		$this->router = $router;
32		}
33
34
35		/**
36		* @throws \Exception
37		*/
38		public function call()
39		{
40		$classInstance = [
41		Route::class => $this->router->route,
42		Response::class => $this->router->response,
43		RouteCollection::class => $this->router->collection,
44		];
45
46		$reflectionMethod = new ReflectionMethod($this->router->route->getTarget('controller'), $this->router->route->getTarget('action'));
47		$dependencies = [];
48		$count = 0;
49
50		foreach ($reflectionMethod->getParameters() as $arg) {
51		if (!is_null($arg->getClass())) {
52		if (isset($classInstance[$arg->getClass()->name]))
53		$dependencies[] = $classInstance[$arg->getClass()->name];
54		else
55		$dependencies[] = call_user_func_array($this->router->route->getTarget('di'), [$arg->getClass()->name]);
56		} else {
57		$count++;
58		}
59		}
60
61		if ($count == count($this->router->route->getParameters()) \|\| ($this->router->route->getParameters() == '' && $count == 0)) {
62		$dependencies = array_merge($dependencies, ($this->router->route->getParameters() == '') ? [] : $this->router->route->getParameters());
63		$content = $reflectionMethod->invokeArgs($this->getController($classInstance), $dependencies);
64	View Code Duplication	if ($content instanceof ResponseInterface) {
		0 ignored issues – show Duplication introduced 2017-07-16 12:46 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		$this->router->response = $content;
66		} else {
67		if (is_array($content)) {
68		$this->router->route->addTarget('data', $content);
69		$content = json_encode($content);
70		}
71		$this->router->response->setContent($content);
72		}
73		} else {
74		$this->router->response->setStatusCode(404);
75		}
76		}
77
78
79		/**
80		* @param array $classInstance
81		* @return object
82		* @throws \Exception
83		*/
84		private function getController($classInstance = [])
85		{
86		$reflector = new ReflectionClass($this->router->route->getTarget('controller'));
87		if (!$reflector->isInstantiable()) {
88		throw new \Exception('Target [' . $this->router->route->getTarget('controller') . '] is not instantiable.');
89		}
90		$constructor = $reflector->getConstructor();
91		if (is_null($constructor)) {
92		$class = $this->router->route->getTarget('controller');
93		return call_user_func_array($this->router->route->getTarget('di'), [$class]);
94		}
95		$dependencies = [];
96		foreach ($constructor->getParameters() as $dep) {
97		$class = $dep->getClass()->name;
98		if (isset($classInstance[$class])) {
99		$dependencies[] = $classInstance[$class];
100		} else {
101		$dependencies[] = call_user_func_array($this->router->route->getTarget('di'), [$class]);
102		}
103		}
104		return $reflector->newInstanceArgs($dependencies);
105		}
106
107		}
108

jetfirephp / routing

Push — master ( beba29...2cba6a )

ControllerDispatcher::call() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like