ClassReflectorRouteLoader::getRoutes() - Code Metrics - Inspection of "Replace `ClassNameLoader` with `jerowork/file-clas..." - jerowork/route-attribute-provider - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( c1a481...89a1c8 )

by Jeroen

created 2021-08-29 12:03 UTC

ClassReflectorRouteLoader::getRoutes() A

↳ Parent: ClassReflectorRouteLoader

Complexity

Conditions	4
Paths	4

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	6
c	1
b	0
f	0
nc	4
nop	0
dl	0
loc	11
ccs	7
cts	7
cp	1
crap	4
rs	10

<?php

declare(strict_types=1);

namespace Jerowork\RouteAttributeProvider\RouteLoader\ClassReflector;

use Generator;
use Jerowork\FileClassReflector\ClassReflectorFactory;
use Jerowork\RouteAttributeProvider\Api\Route;
use Jerowork\RouteAttributeProvider\RouteLoader\LoadedRoute;
use Jerowork\RouteAttributeProvider\RouteLoader\RouteLoaderInterface;

final class ClassReflectorRouteLoader implements RouteLoaderInterface
{
    /**
     * @var string[]
     */
    private array $directories = [];

    public function __construct(private ClassReflectorFactory $reflectorFactory)
    {
    }

    public function getDirectories(): array
    {
        return $this->directories;
    }

    public function addDirectory(string ...$directories): RouteLoaderInterface
    {
        /** @psalm-suppress DuplicateArrayKey */
        $this->directories = [...$this->directories, ...$directories];


        return $this;
    }

    public function getRoutes(): Generator
    {
        $reflector = $this->reflectorFactory->create()->addDirectory(...$this->directories);

        foreach ($reflector->reflect()->getClasses() as $class) {
            foreach ($class->getMethods() as $method) {
                foreach ($method->getAttributes(Route::class) as $attribute) {
                    /** @var Route $route */
                    $route = $attribute->newInstance();

                    yield new LoadedRoute($class->getName(), $method->getName(), $route);
                }
            }
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Jerowork\RouteAttributeProvider\RouteLoader\ClassReflector;
6
7		use Generator;
8		use Jerowork\FileClassReflector\ClassReflectorFactory;
9		use Jerowork\RouteAttributeProvider\Api\Route;
10		use Jerowork\RouteAttributeProvider\RouteLoader\LoadedRoute;
11		use Jerowork\RouteAttributeProvider\RouteLoader\RouteLoaderInterface;
12
13		final class ClassReflectorRouteLoader implements RouteLoaderInterface
14		{
15		/**
16		* @var string[]
17		*/
18		private array $directories = [];
19
20	4	public function __construct(private ClassReflectorFactory $reflectorFactory)
21		{
22	4	}
23
24		public function getDirectories(): array
25		{
26		return $this->directories;
27		}
28
29	2	public function addDirectory(string ...$directories): RouteLoaderInterface
30		{
31		/** @psalm-suppress DuplicateArrayKey */
32	2	$this->directories = [...$this->directories, ...$directories];
		0 ignored issues – show Documentation Bug introduced 2021-08-29 12:04 UTC by Report Bug Copy Issue Report It seems like `array($this->directories, $directories)` of type `array<integer,array\|array<integer,string>>` is incompatible with the declared type `string[]` of property `$directories`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
33
34	2	return $this;
35		}
36
37	2	public function getRoutes(): Generator
38		{
39	2	$reflector = $this->reflectorFactory->create()->addDirectory(...$this->directories);
40
41	2	foreach ($reflector->reflect()->getClasses() as $class) {
42	2	foreach ($class->getMethods() as $method) {
43	2	foreach ($method->getAttributes(Route::class) as $attribute) {
44		/** @var Route $route */
45	2	$route = $attribute->newInstance();
46
47	2	yield new LoadedRoute($class->getName(), $method->getName(), $route);
48		}
49		}
50		}
51	2	}
52		}
53

jerowork / route-attribute-provider

Push — main ( c1a481...89a1c8 )

ClassReflectorRouteLoader::getRoutes() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like