Select2::__construct() - Code Metrics - Inspection of "Entire components reorganization (#880)" - jeroennoten/Laravel-AdminLTE - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5cded9...9f728c )

by Diego

created 2021-04-29 20:18 UTC

Select2::__construct() A

↳ Parent: Select2

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	10
dl	0
loc	12
ccs	5
cts	5
cp	1
crap	2
rs	10
c	0
b	0
f	0

How to fix Many Parameters

<?php

namespace JeroenNoten\LaravelAdminLte\Components\Form;

class Select2 extends InputGroupComponent
{
    /**
     * The select2 plugin configuration parameters. Array with key => value
     * pairs, where the key should be an existing configuration property of
     * the select2 plugin.
     *
     * @var array
     */
    public $config;

    /**
     * Create a new component instance.
     * Note this component requires the 'select2' plugin and the 'bootstrap4'
     * css theme.
     *
     * @return void
     */
    public function __construct(
        $name, $id = null, $label = null, $igroupSize = null, $labelClass = null,
        $fgroupClass = null, $igroupClass = null, $disableFeedback = null,
        $errorKey = null, $config = []
    ) {
        parent::__construct(
            $name, $id, $label, $igroupSize, $labelClass, $fgroupClass,
            $igroupClass, $disableFeedback, $errorKey
        );

        $this->config = is_array($config) ? $config : [];
        $this->config['theme'] = 'bootstrap4';
    }

    /**
     * Get the view / contents that represent the component.
     *
     * @return \Illuminate\View\View|string
     */
    public function render()
    {
        return view('adminlte::components.form.select2');
    }
}


1		<?php
2
3		namespace JeroenNoten\LaravelAdminLte\Components\Form;
4
5		class Select2 extends InputGroupComponent
6		{
7		/**
8		* The select2 plugin configuration parameters. Array with key => value
9		* pairs, where the key should be an existing configuration property of
10		* the select2 plugin.
11		*
12		* @var array
13		*/
14		public $config;
15
16		/**
17		* Create a new component instance.
18		* Note this component requires the 'select2' plugin and the 'bootstrap4'
19		* css theme.
20		*
21		* @return void
22		*/
23	2	public function __construct(
24		$name, $id = null, $label = null, $igroupSize = null, $labelClass = null,
25		$fgroupClass = null, $igroupClass = null, $disableFeedback = null,
26		$errorKey = null, $config = []
27		) {
28	2	parent::__construct(
29	2	$name, $id, $label, $igroupSize, $labelClass, $fgroupClass,
30		$igroupClass, $disableFeedback, $errorKey
31		);
32
33	2	$this->config = is_array($config) ? $config : [];
34	2	$this->config['theme'] = 'bootstrap4';
35	2	}
36
37		/**
38		* Get the view / contents that represent the component.
39		*
40		* @return \Illuminate\View\View\|string
41		*/
42	1	public function render()
43		{
44	1	return view('adminlte::components.form.select2');
45		}
46		}
47

jeroennoten / Laravel-AdminLTE

Push — master ( 5cded9...9f728c )

Select2::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like