Alert::icon() - Code Metrics - Inspection of "Add Blade-x components" - jeroennoten/Laravel-AdminLTE - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#721)

by Florian

created 2020-10-23 15:16 UTC

Alert::icon() A

↳ Parent: Alert

Complexity

Conditions	5
Paths	5

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	5

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
cc	5
eloc	6
c	2
b	1
f	0
nc	5
nop	0
dl	0
loc	8
ccs	7
cts	7
cp	1
crap	5
rs	9.6111

<?php

namespace JeroenNoten\LaravelAdminLte\Components;

use Illuminate\View\Component;

class Alert extends Component
{
    public $type;
    public $title;
    public $dismissable;

    public function __construct($type = 'info', $dismissable = false, $title = 'Alert')
    {
        $this->type = $type;
        $this->title = $title;
        $this->dismissable = $dismissable;
    }

    public function icon()
    {
        switch ($this->type) {
            case 'info': return 'info'; break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'warning': return 'exclamation-triangle'; break;
            case 'success': return 'check'; break;
            case 'danger': return 'ban'; break;
            default: return 'exclamation'; break;
        }
    }

    public function render()
    {
        return view('adminlte::components.alert');
    }
}


1		<?php
2
3		namespace JeroenNoten\LaravelAdminLte\Components;
4
5		use Illuminate\View\Component;
6
7		class Alert extends Component
8		{
9		public $type;
10		public $title;
11		public $dismissable;
12
13	2	public function __construct($type = 'info', $dismissable = false, $title = 'Alert')
14		{
15	2	$this->type = $type;
16	2	$this->title = $title;
17	2	$this->dismissable = $dismissable;
18	2	}
19
20	1	public function icon()
21		{
22	1	switch ($this->type) {
23	1	case 'info': return 'info'; break;
		0 ignored issues – show Unused Code introduced 2020-09-27 16:45 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
24	1	case 'warning': return 'exclamation-triangle'; break;
25	1	case 'success': return 'check'; break;
26	1	case 'danger': return 'ban'; break;
27	1	default: return 'exclamation'; break;
28		}
29		}
30
31	1	public function render()
32		{
33	1	return view('adminlte::components.alert');
34		}
35		}
36

jeroennoten / Laravel-AdminLTE

Pull Request — master (#721)

Alert::icon() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like