Passed
Pull Request — master (#721)
by Florian
09:26
created

Input::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 22
Code Lines 14

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 1
eloc 14
c 1
b 0
f 0
nc 1
nop 14
dl 0
loc 22
rs 9.7998

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
namespace JeroenNoten\LaravelAdminLte\Components;
4
5
use Illuminate\View\Component;
6
7
class Input extends Component
8
{
9
    public $type, $id, $name, $label, $placeholder;
10
    public $topclass, $inputclass;
11
    public $value, $disabled, $required;
12
    public $step, $max, $maxlength, $pattern;
13
14
    public function __construct(
15
            $type = 'text', $id = null, $name = null,
16
            $label = 'Input Label', $placeholder = null,
17
            $topclass = null, $inputclass = null,
18
            $value = null, $disabled = false, $required = false,
19
            $step = null, $max = null, $maxlength = null, $pattern = null
20
        )
21
    {
22
        $this->type = $type;
23
        $this->id = $id;
24
        $this->name = $name;
25
        $this->label = $label;
26
        $this->placeholder = $placeholder;
27
        $this->topclass = $topclass;
28
        $this->inputclass = $inputclass;
29
        $this->value = $value;
30
        $this->required = $required;
31
        $this->disabled = $disabled;
32
        $this->step = $step;
33
        $this->max = $max;
34
        $this->maxlength = $maxlength;
35
        $this->pattern = $pattern;
36
    }
37
38
    public function render()
39
    {
40
        return view('adminlte::input');
41
    }
42
}