InputColor::__construct() - Code Metrics - Inspection of "Merge next into master" - jeroennoten/Laravel-AdminLTE - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#856)

by Florian

created 2021-04-09 14:59 UTC

InputColor::__construct() A

↳ Parent: InputColor

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	4
nc	2
nop	8
dl	0
loc	11
ccs	4
cts	4
cp	1
crap	2
rs	10
c	1
b	0
f	0

How to fix Many Parameters

<?php

namespace JeroenNoten\LaravelAdminLte\Components;

class InputColor extends InputGroupComponent
{
    /**
     * The Bootstrap Colorpicker plugin configuration parameters. Array with
     * key => value pairs, where the key should be an existing configuration
     * property of the plugin.
     *
     * @var array
     */
    public $config;

    /**
     * Create a new component instance.
     * Note this component requires the 'Bootstrap Colorpicker' plugin.
     *
     * @return void
     */
    public function __construct(
        $name, $label = null, $size = null, $labelClass = null,
        $topClass = null, $inputGroupClass = null, $disableFeedback = null,
        $config = []
    ) {
        parent::__construct(
            $name, $label, $size, $labelClass, $topClass,
            $inputGroupClass, $disableFeedback
        );

        $this->config = is_array($config) ? $config : [];
    }

    /**
     * Get the view / contents that represent the component.
     *
     * @return \Illuminate\View\View|string
     */
    public function render()
    {
        return view('adminlte::components.input-color');
    }
}


1		<?php
2
3		namespace JeroenNoten\LaravelAdminLte\Components;
4
5		class InputColor extends InputGroupComponent
6		{
7		/**
8		* The Bootstrap Colorpicker plugin configuration parameters. Array with
9		* key => value pairs, where the key should be an existing configuration
10		* property of the plugin.
11		*
12		* @var array
13		*/
14		public $config;
15
16		/**
17		* Create a new component instance.
18		* Note this component requires the 'Bootstrap Colorpicker' plugin.
19		*
20		* @return void
21		*/
22	1	public function __construct(
23		$name, $label = null, $size = null, $labelClass = null,
24		$topClass = null, $inputGroupClass = null, $disableFeedback = null,
25		$config = []
26		) {
27	1	parent::__construct(
28	1	$name, $label, $size, $labelClass, $topClass,
29		$inputGroupClass, $disableFeedback
30		);
31
32	1	$this->config = is_array($config) ? $config : [];
33	1	}
34
35		/**
36		* Get the view / contents that represent the component.
37		*
38		* @return \Illuminate\View\View\|string
39		*/
40	1	public function render()
41		{
42	1	return view('adminlte::components.input-color');
43		}
44		}
45

jeroennoten / Laravel-AdminLTE

Pull Request — master (#856)

InputColor::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like