ActiveChecker::checkExactOrSub() - Code Metrics - Inspection of "Fix active highlighting on route set menu items, f..." - jeroennoten/Laravel-AdminLTE - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#131)

unknown

created 2017-09-25 16:07 UTC

ActiveChecker::checkExactOrSub() A

↳ Parent: ActiveChecker::checkPattern()

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	2
eloc	2
nc	2
nop	1
crap	2

<?php

namespace JeroenNoten\LaravelAdminLte\Menu;

use Illuminate\Support\Str;
use Illuminate\Http\Request;
use Illuminate\Contracts\Routing\UrlGenerator;

class ActiveChecker
{
    private $request;

    private $url;

    public function __construct(Request $request, UrlGenerator $url)

    {
        $this->request = $request;
        $this->url = $url;
    }

    public function isActive($item)
    {
        if (isset($item['active'])) {
            return $this->isExplicitActive($item['active']);
        }

        if (isset($item['submenu'])) {
            return $this->containsActive($item['submenu']);
        }

        if (isset($item['href'])) {
            return $this->checkPattern($item['href']);
        }

        // Support URL for backwards compatibility
        if (isset($item['url'])) {
            return $this->checkPattern($item['url']);
        }

        return false;
    }

    protected function checkPattern($pattern)
    {
        $fullUrlPattern = $this->url->to($pattern);

        $fullUrl = $this->request->fullUrl();

        return Str::is($fullUrlPattern, $fullUrl);
    }

    protected function containsActive($items)
    {
        foreach ($items as $item) {
            if ($this->isActive($item)) {
                return true;
            }
        }

        return false;
    }

    private function isExplicitActive($active)
    {
        foreach ($active as $url) {
            if ($this->checkExact($url)) {

                return true;
            }
        }

        return false;
    }
}


1		<?php
2
3		namespace JeroenNoten\LaravelAdminLte\Menu;
4
5		use Illuminate\Support\Str;
6		use Illuminate\Http\Request;
7		use Illuminate\Contracts\Routing\UrlGenerator;
8
9		class ActiveChecker
10		{
11		private $request;
12
13		private $url;
14
15	32	public function __construct(Request $request, UrlGenerator $url)
		0 ignored issues – show Bug introduced 2017-08-02 21:10 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
16		{
17	32	$this->request = $request;
18	32	$this->url = $url;
19	32	}
20
21	30	public function isActive($item)
22		{
23	30	if (isset($item['active'])) {
24	3	return $this->isExplicitActive($item['active']);
25		}
26
27	27	if (isset($item['submenu'])) {
28	8	return $this->containsActive($item['submenu']);
29		}
30
31	24	if (isset($item['href'])) {
32	14	return $this->checkPattern($item['href']);
33		}
34
35		// Support URL for backwards compatibility
36	13	if (isset($item['url'])) {
37	12	return $this->checkPattern($item['url']);
38		}
39
40	1	return false;
41		}
42
43	23	protected function checkPattern($pattern)
44		{
45	23	$fullUrlPattern = $this->url->to($pattern);
46
47		$fullUrl = $this->request->fullUrl();
48	26
49		return Str::is($fullUrlPattern, $fullUrl);
50	26	}
51
52		protected function containsActive($items)
53	11	{
54		foreach ($items as $item) {
55	11	if ($this->isActive($item)) {
56		return true;
57		}
58	26	}
59
60	26	return false;
61		}
62	26
63		private function isExplicitActive($active)
64	26	{
65		foreach ($active as $url) {
66		if ($this->checkExact($url)) {
		0 ignored issues – show Bug introduced 2017-09-25 16:10 UTC by Report Bug Copy Issue Report The method `checkExact()` does not seem to exist on `object<JeroenNoten\Larav...Lte\Menu\ActiveChecker>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
67	8	return true;
68		}
69	8	}
70	5
71	3	return false;
72		}
73		}
74

jeroennoten / Laravel-AdminLTE

Pull Request — master (#131)

ActiveChecker::checkExactOrSub() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like