InputFile::__construct() - Code Metrics - Inspection of "Add Blade-x components" - jeroennoten/Laravel-AdminLTE - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#721)

by Florian

created 2020-10-20 04:34 UTC

InputFile::__construct() A

↳ Parent: InputFile

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	4
c	1
b	0
f	0
nc	1
nop	8
dl	0
loc	10
ccs	5
cts	5
cp	1
crap	1
rs	10

How to fix Many Parameters

<?php

namespace JeroenNoten\LaravelAdminLte\Components;

class InputFile extends InputGroupComponent
{
    /**
     * The placeholder for the input file box.
     *
     * @var string
     */
    public $placeholder;

    /**
     * A legend for replace the default 'Browse' text.
     *
     * @var string
     */
    public $legend;

    /**
     * Create a new component instance.
     * Note this component requires the 'bs-custom-input-file' plugin.
     *
     * @return void
     */
    public function __construct(
        $name, $label = null, $size = null, $labelClass = null, $topClass = null,
        $disableFeedback = null, $placeholder = '', $legend = null
    ) {
        parent::__construct(
            $name, $label, $size, $labelClass, $topClass, $disableFeedback
        );

        $this->legend = $legend;
        $this->placeholder = $placeholder;
    }

    /**
     * Make the class attribute for the input group item.
     *
     * @param string $invalid
     * @return string
     */
    public function makeItemClass($invalid)
    {
        $classes = ['custom-file-input'];

        if (! empty($invalid) && ! isset($this->disableFeedback)) {
            $classes[] = 'is-invalid';
        }

        return implode(' ', $classes);
    }

    /**
     * Get the view / contents that represent the component.
     *
     * @return \Illuminate\View\View|string
     */
    public function render()
    {
        return view('adminlte::components.input-file');
    }
}


1		<?php
2
3		namespace JeroenNoten\LaravelAdminLte\Components;
4
5		class InputFile extends InputGroupComponent
6		{
7		/**
8		* The placeholder for the input file box.
9		*
10		* @var string
11		*/
12		public $placeholder;
13
14		/**
15		* A legend for replace the default 'Browse' text.
16		*
17		* @var string
18		*/
19		public $legend;
20
21		/**
22		* Create a new component instance.
23		* Note this component requires the 'bs-custom-input-file' plugin.
24		*
25		* @return void
26		*/
27	2	public function __construct(
28		$name, $label = null, $size = null, $labelClass = null, $topClass = null,
29		$disableFeedback = null, $placeholder = '', $legend = null
30		) {
31	2	parent::__construct(
32	2	$name, $label, $size, $labelClass, $topClass, $disableFeedback
33		);
34
35	2	$this->legend = $legend;
36	2	$this->placeholder = $placeholder;
37	2	}
38
39		/**
40		* Make the class attribute for the input group item.
41		*
42		* @param string $invalid
43		* @return string
44		*/
45	1	public function makeItemClass($invalid)
46		{
47	1	$classes = ['custom-file-input'];
48
49	1	if (! empty($invalid) && ! isset($this->disableFeedback)) {
50	1	$classes[] = 'is-invalid';
51		}
52
53	1	return implode(' ', $classes);
54		}
55
56		/**
57		* Get the view / contents that represent the component.
58		*
59		* @return \Illuminate\View\View\|string
60		*/
61	1	public function render()
62		{
63	1	return view('adminlte::components.input-file');
64		}
65		}
66

jeroennoten / Laravel-AdminLTE

Pull Request — master (#721)

InputFile::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like