Builder::remove() - Code Metrics - Inspection of "Some enhancements" - jeroennoten/Laravel-AdminLTE - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#477)

unknown

created 2020-02-05 13:27 UTC

Builder::remove() A

↳ Parent: Builder

Complexity

Conditions	4
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	1
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	1
cts	1
cp	1
rs	9.7333
c	0
b	0
f	0
cc	4
nc	2
nop	1
crap	4

<?php

namespace JeroenNoten\LaravelAdminLte\Menu;

use Illuminate\Support\Arr;

class Builder
{
    public $menu = [];

    /**
     * @var array
     */
    private $filters;

    public function __construct(array $filters = [])
    {
        $this->filters = $filters;
    }

    public function add()
    {
        $items = $this->transformItems(func_get_args());

        foreach ($items as $item) {
            array_push($this->menu, $item);
        }
    }

    public function addAfter($itemKey, ...$newItems)
    {
        $this->addItem($itemKey, 'after', ...$newItems);
    }

    public function addBefore($itemKey, ...$newItems)
    {
        $this->addItem($itemKey, 'before', ...$newItems);
    }

    public function addIn($itemKey, ...$newItems)
    {
        $this->addItem($itemKey, 'in', ...$newItems);
    }

    public function remove($itemKey)
    {
        $completeArrayPath = '';
        $itemPath = $this->findItem($itemKey, $this->menu);
        if (is_array($itemPath)) {
            foreach ($itemPath as $key => $value) {
                if ($completeArrayPath === '') {
                    $completeArrayPath .= "$value";
                } else {
                    $completeArrayPath .= ".submenu.$value";
                }
            }
            $itemPath = $completeArrayPath;
        }
        Arr::forget($this->menu, $itemPath);
    }

    public function itemKeyExists($itemKey)
    {
        if ($this->findItem($itemKey, $this->menu)) {
            return true;
        }

        return false;
    }

    public function transformItems($items)
    {
        return array_filter(array_map([$this, 'applyFilters'], $items));
    }

    protected function addItem($itemKey, $direction, ...$newItems)
    {
        $items = $this->transformItems($newItems);
        $position = $this->findItem($itemKey, $this->menu);

        if ($position !== null) {
            $completeArrayPath = $lastKey = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            if (is_array($position)) {
                $completeArrayPath = implode('.submenu.', $position);
                $lastKey = end($position);
            } else {
                $completeArrayPath = $lastKey = $position;
            }

            if ($direction == 'in' || ! is_array($position)) {
                $arrayPath = $completeArrayPath;
            } elseif (is_array($position)) {
                $arrayPath = substr($completeArrayPath, 0, -(strlen(".$lastKey")));
            }

            if ($position == $lastKey && $direction != 'in') {
                array_splice($this->menu, $position + ($direction == 'after' ? 1 : 0), 0, $items);
            } else {
                $menuItems = Arr::get($this->menu, $arrayPath);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

                if ($direction == 'in') {
                    if (! isset($menuItems['submenu'])) {
                        $menuItems['submenu'] = [];
                        $menuItems = $this->transformItems([$menuItems]);
                        $menuItems = $menuItems[0];
                        $menuItems['submenu'] = [];
                        $menuItems['submenu'] = array_merge($menuItems['submenu'], $items);
                    } else {
                        $menuItems['submenu'] = array_merge($menuItems['submenu'], $items);
                    }
                } else {
                    array_splice($menuItems, $lastKey + ($direction == 'after' ? 1 : 0), 0, $items);
                }

                Arr::set($this->menu, $arrayPath, $menuItems);
            }
        }
    }

    protected function findItem($itemKey, $items, $childPositionOld = null)
    {
        if (is_array($childPositionOld)) {
            $childPositions = $childPositionOld;
        } else {
            $childPositions = [];
            if ($childPositionOld) {
                $childPositions[] = $childPositionOld;
            }
        }
        foreach ($items as $key => $item) {
            if (isset($item['key']) && $item['key'] == $itemKey) {
                if ($childPositionOld) {
                    $childPositions[] = $key;

                    return $childPositions;
                }

                return $key;
            } elseif (isset($item['submenu'])) {
                if ($childPositionOld) {
                    $childPositions[] = $key;
                    $childPosition = $this->findItem($itemKey, $item['submenu'], $childPositions);
                    $childPositions[] = $childPosition;

                    if (is_array($childPosition)) {
                        $childPositions = $childPosition;
                    }

                    return $childPositions;
                } else {
                    $newKey = $this->findItem($itemKey, $item['submenu']);

                    $childPositions[] = $key;
                    if (! is_array($newKey)) {
                        $childPositions[] = $newKey;
                    } else {
                        $childPositions = array_merge($childPositions, $newKey);
                    }

                    return $childPositions;

                }
            }
        }
    }

    protected function applyFilters($item)
    {
        if (is_string($item)) {
            return $item;
        }

        foreach ($this->filters as $filter) {
            $item = $filter->transform($item, $this);
        }

        return $item;
    }
}


1		<?php
2
3		namespace JeroenNoten\LaravelAdminLte\Menu;
4
5		use Illuminate\Support\Arr;
6
7		class Builder
8		{
9		public $menu = [];
10
11		/**
12		* @var array
13		*/
14	21	private $filters;
15
16	21	public function __construct(array $filters = [])
17	21	{
18		$this->filters = $filters;
19	21	}
20
21	21	public function add()
22		{
23	21	$items = $this->transformItems(func_get_args());
24	21
25		foreach ($items as $item) {
26	21	array_push($this->menu, $item);
27		}
28	21	}
29
30	21	public function addAfter($itemKey, ...$newItems)
31		{
32		$this->addItem($itemKey, 'after', ...$newItems);
33	21	}
34
35	21	public function addBefore($itemKey, ...$newItems)
36	1	{
37		$this->addItem($itemKey, 'before', ...$newItems);
38		}
39	20
40	19	public function addIn($itemKey, ...$newItems)
41		{
42		$this->addItem($itemKey, 'in', ...$newItems);
43	20	}
44	2
45		public function remove($itemKey)
46		{
47	20	$completeArrayPath = '';
48		$itemPath = $this->findItem($itemKey, $this->menu);
49		if (is_array($itemPath)) {
50		foreach ($itemPath as $key => $value) {
51		if ($completeArrayPath === '') {
52		$completeArrayPath .= "$value";
53		} else {
54		$completeArrayPath .= ".submenu.$value";
55		}
56		}
57		$itemPath = $completeArrayPath;
58		}
59		Arr::forget($this->menu, $itemPath);
60		}
61
62		public function itemKeyExists($itemKey)
63		{
64		if ($this->findItem($itemKey, $this->menu)) {
65		return true;
66		}
67
68		return false;
69		}
70
71		public function transformItems($items)
72		{
73		return array_filter(array_map([$this, 'applyFilters'], $items));
74		}
75
76		protected function addItem($itemKey, $direction, ...$newItems)
77		{
78		$items = $this->transformItems($newItems);
79		$position = $this->findItem($itemKey, $this->menu);
80
81		if ($position !== null) {
82		$completeArrayPath = $lastKey = '';
		0 ignored issues – show Unused Code introduced 2020-02-04 14:57 UTC by Report Bug Copy Issue Report `$lastKey` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Unused Code introduced 2020-02-04 14:57 UTC by Report Bug Copy Issue Report `$completeArrayPath` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
83
84		if (is_array($position)) {
85		$completeArrayPath = implode('.submenu.', $position);
86		$lastKey = end($position);
87		} else {
88		$completeArrayPath = $lastKey = $position;
89		}
90
91		if ($direction == 'in' \|\| ! is_array($position)) {
92		$arrayPath = $completeArrayPath;
93		} elseif (is_array($position)) {
94		$arrayPath = substr($completeArrayPath, 0, -(strlen(".$lastKey")));
95		}
96
97		if ($position == $lastKey && $direction != 'in') {
98		array_splice($this->menu, $position + ($direction == 'after' ? 1 : 0), 0, $items);
99		} else {
100		$menuItems = Arr::get($this->menu, $arrayPath);
		0 ignored issues – show Bug introduced 2020-02-04 14:57 UTC by Report Bug Copy Issue Report The variable `$arrayPath` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
101
102		if ($direction == 'in') {
103		if (! isset($menuItems['submenu'])) {
104		$menuItems['submenu'] = [];
105		$menuItems = $this->transformItems([$menuItems]);
106		$menuItems = $menuItems[0];
107		$menuItems['submenu'] = [];
108		$menuItems['submenu'] = array_merge($menuItems['submenu'], $items);
109		} else {
110		$menuItems['submenu'] = array_merge($menuItems['submenu'], $items);
111		}
112		} else {
113		array_splice($menuItems, $lastKey + ($direction == 'after' ? 1 : 0), 0, $items);
114		}
115
116		Arr::set($this->menu, $arrayPath, $menuItems);
117		}
118		}
119		}
120
121		protected function findItem($itemKey, $items, $childPositionOld = null)
122		{
123		if (is_array($childPositionOld)) {
124		$childPositions = $childPositionOld;
125		} else {
126		$childPositions = [];
127		if ($childPositionOld) {
128		$childPositions[] = $childPositionOld;
129		}
130		}
131		foreach ($items as $key => $item) {
132		if (isset($item['key']) && $item['key'] == $itemKey) {
133		if ($childPositionOld) {
134		$childPositions[] = $key;
135
136		return $childPositions;
137		}
138
139		return $key;
140		} elseif (isset($item['submenu'])) {
141		if ($childPositionOld) {
142		$childPositions[] = $key;
143		$childPosition = $this->findItem($itemKey, $item['submenu'], $childPositions);
144		$childPositions[] = $childPosition;
145
146		if (is_array($childPosition)) {
147		$childPositions = $childPosition;
148		}
149
150		return $childPositions;
151		} else {
152		$newKey = $this->findItem($itemKey, $item['submenu']);
153
154		$childPositions[] = $key;
155		if (! is_array($newKey)) {
156		$childPositions[] = $newKey;
157		} else {
158		$childPositions = array_merge($childPositions, $newKey);
159		}
160
161		return $childPositions;
162
163		}
164		}
165		}
166		}
167
168		protected function applyFilters($item)
169		{
170		if (is_string($item)) {
171		return $item;
172		}
173
174		foreach ($this->filters as $filter) {
175		$item = $filter->transform($item, $this);
176		}
177
178		return $item;
179		}
180		}
181

jeroennoten / Laravel-AdminLTE

Pull Request — master (#477)

Builder::remove() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like