Followable - Code Metrics - jeroenherczeg/dog - Measure and Improve Code Quality continuously with Scrutinizer

Followable A
last analyzed 2016-08-29 13:02 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	8
c	1
b	0
f	0
lcom	2
cbo	0
dl	0
loc	76
ccs	22
cts	22
cp	1
rs	10

6 Methods

Rating	Name	Size	Complexity
A	follow()	8	2
A	unfollow()	8	2
A	isFollowing()	4	1
A	isFollowedBy()	4	1
A	followers()	6	1
A	followings()	6	1

<?php

namespace Jeroenherczeg\Dog;

use Illuminate\Database\Eloquent\ModelNotFoundException;

trait Followable
{
    /**
     * Follow a user.
     *
     * @param int|array $user
     */
    public function follow($user)
    {
        if (!is_array($user)) {
            $user = compact('user');
        }

        $this->followings()->sync($user, false);
    }

    /**
     * Unfollow a user.
     *
     * @param $user
     */
    public function unfollow($user)
    {
        if (!is_array($user)) {
            $user = compact('user');
        }

        $this->followings()->detach($user);
    }
    
    /**
     * Check if user is following given user.
     *
     * @param $user
     * @return mixed
     */
    public function isFollowing($user)
    {
        return $this->followings->contains($user);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Check if user is followed by given user.
     *
     * @param $user
     * @return mixed
     */
    public function isFollowedBy($user)
    {
        return $this->followers->contains($user);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Followers relationship.
     *
     * @return mixed
     */
    public function followers()
    {
        $model = get_class($this);

        return $this->belongsToMany($model, 'followers', 'follow_id', 'user_id');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Followings relationship.
     *
     * @return mixed
     */
    public function followings()
    {
        $model = get_class($this);

        return $this->belongsToMany($model, 'followers', 'user_id', 'follow_id');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace Jeroenherczeg\Dog;
4
5		use Illuminate\Database\Eloquent\ModelNotFoundException;
6
7		trait Followable
8		{
9		/**
10		* Follow a user.
11		*
12		* @param int\|array $user
13		*/
14	18	public function follow($user)
15		{
16	18	if (!is_array($user)) {
17	15	$user = compact('user');
18	10	}
19
20	18	$this->followings()->sync($user, false);
21	18	}
22
23		/**
24		* Unfollow a user.
25		*
26		* @param $user
27		*/
28	3	public function unfollow($user)
29		{
30	3	if (!is_array($user)) {
31	3	$user = compact('user');
32	2	}
33
34	3	$this->followings()->detach($user);
35	3	}
36
37		/**
38		* Check if user is following given user.
39		*
40		* @param $user
41		* @return mixed
42		*/
43	3	public function isFollowing($user)
44		{
45	3	return $this->followings->contains($user);
		0 ignored issues – show Bug introduced 2016-08-15 18:25 UTC by Report Bug Copy Issue Report The property `followings` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
46		}
47
48		/**
49		* Check if user is followed by given user.
50		*
51		* @param $user
52		* @return mixed
53		*/
54	3	public function isFollowedBy($user)
55		{
56	3	return $this->followers->contains($user);
		0 ignored issues – show Bug introduced 2016-08-15 18:25 UTC by Report Bug Copy Issue Report The property `followers` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
57		}
58
59		/**
60		* Followers relationship.
61		*
62		* @return mixed
63		*/
64	12	public function followers()
65		{
66	12	$model = get_class($this);
67
68	12	return $this->belongsToMany($model, 'followers', 'follow_id', 'user_id');
		0 ignored issues – show Bug introduced 2016-08-15 18:25 UTC by Report Bug Copy Issue Report It seems like `belongsToMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
69		}
70
71		/**
72		* Followings relationship.
73		*
74		* @return mixed
75		*/
76	18	public function followings()
77		{
78	18	$model = get_class($this);
79
80	18	return $this->belongsToMany($model, 'followers', 'user_id', 'follow_id');
		0 ignored issues – show Bug introduced 2016-08-15 18:25 UTC by Report Bug Copy Issue Report It seems like `belongsToMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
81		}
82		}
83

jeroenherczeg / dog

Followable A last analyzed 2016-08-29 13:02 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like

Followable A
last analyzed 2016-08-29 13:02 UTC