Issues in example.php (master) - Issues in master - jeroendesloovere/vcard - Measure and Improve Code Quality continuously with Scrutinizer

Issues (28)

examples/example.php (5 issues)

Labels

Severity

Minor 5

<?php

/**
 * VCard generator test - can save to file or output as a download
 */

require_once __DIR__ . '/../vendor/autoload.php';
require_once __DIR__ . '/../src/VCard.php';

use JeroenDesloovere\VCard\VCard;

// define vcard
$vcard = new VCard();

// define variables
$firstname = 'Jeroen';
$lastname = 'Desloovere';
$additional = '';
$prefix = '';
$suffix = '';

// add personal data
$vcard->addName($lastname, $firstname, $additional, $prefix, $suffix);

// add work data
$vcard->addCompany('Siesqo');
$vcard->addJobtitle('Web Developer');
$vcard->addEmail('[email protected]');
$vcard->addPhoneNumber(1234121212, 'PREF;WORK');
$vcard->addPhoneNumber(123456789, 'WORK');
$vcard->addAddress(null, null, 'street', 'worktown', null, 'workpostcode', 'Belgium');
$vcard->addURL('http://www.jeroendesloovere.be');

$vcard->addPhoto(__DIR__ . '/assets/landscape.jpeg');
//$vcard->addPhoto('https://raw.githubusercontent.com/jeroendesloovere/vcard/master/tests/image.jpg');


// return vcard as a string

//return $vcard->getOutput();

// return vcard as a download
return $vcard->download();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

// echo message
echo 'A personal vCard is saved in this folder: ' . __DIR__;

// or


// save the card in file in the current folder
// return $vcard->save();

// echo message

// echo 'A personal vCard is saved in this folder: ' . __DIR__;


1			<?php
2
3			/**
4			* VCard generator test - can save to file or output as a download
5			*/
6
7			require_once __DIR__ . '/../vendor/autoload.php';
8			require_once __DIR__ . '/../src/VCard.php';
9
10			use JeroenDesloovere\VCard\VCard;
11
12			// define vcard
13			$vcard = new VCard();
14
15			// define variables
16			$firstname = 'Jeroen';
17			$lastname = 'Desloovere';
18			$additional = '';
19			$prefix = '';
20			$suffix = '';
21
22			// add personal data
23			$vcard->addName($lastname, $firstname, $additional, $prefix, $suffix);
24
25			// add work data
26			$vcard->addCompany('Siesqo');
27			$vcard->addJobtitle('Web Developer');
28			$vcard->addEmail('[email protected]');
29			$vcard->addPhoneNumber(1234121212, 'PREF;WORK');
30			$vcard->addPhoneNumber(123456789, 'WORK');
31			$vcard->addAddress(null, null, 'street', 'worktown', null, 'workpostcode', 'Belgium');
32			$vcard->addURL('http://www.jeroendesloovere.be');
33
34			$vcard->addPhoto(__DIR__ . '/assets/landscape.jpeg');
35			//$vcard->addPhoto('https://raw.githubusercontent.com/jeroendesloovere/vcard/master/tests/image.jpg');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-30 12:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this `86%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
36
37			// return vcard as a string
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-02 16:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
38			//return $vcard->getOutput();
39
40			// return vcard as a download
41			return $vcard->download();
			0 ignored issues – show Bug introduced 2017-12-18 10:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$vcard->download()` targeting `JeroenDesloovere\VCard\VCard::download()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
42
43			// echo message
44			echo 'A personal vCard is saved in this folder: ' . __DIR__;
45
46			// or
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-12-18 21:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
47
48			// save the card in file in the current folder
49			// return $vcard->save();
50
51			// echo message
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-10-19 04:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this `36%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
52			// echo 'A personal vCard is saved in this folder: ' . __DIR__;
53

jeroendesloovere / vcard

Issues (28)

examples/example.php (5 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like