Complex classes like VCard often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use VCard, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
19 | class VCard |
||
20 | { |
||
21 | /** |
||
22 | * definedElements |
||
23 | * |
||
24 | * @var array |
||
25 | */ |
||
26 | private $definedElements; |
||
27 | |||
28 | /** |
||
29 | * Filename |
||
30 | * |
||
31 | * @var string |
||
32 | */ |
||
33 | private $filename; |
||
34 | |||
35 | /** |
||
36 | * Multiple properties for element allowed |
||
37 | * |
||
38 | * @var array |
||
39 | */ |
||
40 | private $multiplePropertiesForElementAllowed = array( |
||
41 | 'email', |
||
42 | 'address', |
||
43 | 'phoneNumber', |
||
44 | 'url' |
||
45 | ); |
||
46 | |||
47 | /** |
||
48 | * Properties |
||
49 | * |
||
50 | * @var array |
||
51 | */ |
||
52 | private $properties; |
||
53 | |||
54 | /** |
||
55 | * Default Charset |
||
56 | * |
||
57 | * @var string |
||
58 | */ |
||
59 | public $charset = 'utf-8'; |
||
60 | |||
61 | /** |
||
62 | * Add address |
||
63 | * |
||
64 | * @param string [optional] $name |
||
65 | * @param string [optional] $extended |
||
66 | * @param string [optional] $street |
||
67 | * @param string [optional] $city |
||
68 | * @param string [optional] $region |
||
69 | * @param string [optional] $zip |
||
70 | * @param string [optional] $country |
||
71 | * @param string [optional] $type |
||
72 | * $type may be DOM | INTL | POSTAL | PARCEL | HOME | WORK |
||
73 | * or any combination of these: e.g. "WORK;PARCEL;POSTAL" |
||
74 | * @return $this |
||
75 | */ |
||
76 | public function addAddress( |
||
98 | |||
99 | /** |
||
100 | * Add birthday |
||
101 | * |
||
102 | * @param string $date Format is YYYY-MM-DD |
||
103 | * @return $this |
||
104 | */ |
||
105 | public function addBirthday($date) |
||
115 | |||
116 | /** |
||
117 | * Add company |
||
118 | * |
||
119 | * @param string $company |
||
120 | * @return $this |
||
121 | */ |
||
122 | public function addCompany($company) |
||
123 | { |
||
124 | $this->setProperty( |
||
125 | 'company', |
||
126 | 'ORG' . $this->getCharsetString(), |
||
127 | $company |
||
128 | ); |
||
129 | |||
130 | // if filename is empty, add to filename |
||
131 | if ($this->getFilename() === null) { |
||
132 | $this->setFilename($company); |
||
133 | } |
||
134 | |||
135 | return $this; |
||
136 | } |
||
137 | |||
138 | /** |
||
139 | * Add email |
||
140 | * |
||
141 | * @param string $address The e-mail address |
||
142 | * @param string [optional] $type The type of the email address |
||
143 | * $type may be PREF | WORK | HOME |
||
144 | * or any combination of these: e.g. "PREF;WORK" |
||
145 | * @return $this |
||
146 | */ |
||
147 | public function addEmail($address, $type = '') |
||
157 | |||
158 | /** |
||
159 | * Add jobtitle |
||
160 | * |
||
161 | * @param string $jobtitle The jobtitle for the person. |
||
162 | * @return $this |
||
163 | */ |
||
164 | public function addJobtitle($jobtitle) |
||
165 | { |
||
166 | $this->setProperty( |
||
167 | 'jobtitle', |
||
168 | 'TITLE' . $this->getCharsetString(), |
||
169 | $jobtitle |
||
170 | ); |
||
171 | |||
172 | return $this; |
||
173 | } |
||
174 | |||
175 | /** |
||
176 | * Add a photo or logo (depending on property name) |
||
177 | * |
||
178 | * @param string $property LOGO|PHOTO |
||
179 | * @param string $url image url or filename |
||
180 | * @param bool $include Do we include the image in our vcard or not? |
||
181 | * @throws VCardMediaException if file is empty or not an image file |
||
182 | */ |
||
183 | private function addMedia($property, $url, $include = true, $element) |
||
215 | |||
216 | /** |
||
217 | * Add name |
||
218 | * |
||
219 | * @param string [optional] $lastName |
||
220 | * @param string [optional] $firstName |
||
221 | * @param string [optional] $additional |
||
222 | * @param string [optional] $prefix |
||
223 | * @param string [optional] $suffix |
||
224 | * @return $this |
||
225 | */ |
||
226 | public function addName( |
||
227 | $lastName = '', |
||
228 | $firstName = '', |
||
229 | $additional = '', |
||
230 | $prefix = '', |
||
231 | $suffix = '' |
||
232 | ) { |
||
233 | // define values with non-empty values |
||
234 | $values = array_filter(array( |
||
235 | $prefix, |
||
236 | $firstName, |
||
237 | $additional, |
||
238 | $lastName, |
||
239 | $suffix, |
||
240 | )); |
||
241 | |||
242 | // define filename |
||
243 | $this->setFilename($values); |
||
244 | |||
245 | // set property |
||
246 | $property = $lastName . ';' . $firstName . ';' . $additional . ';' . $prefix . ';' . $suffix; |
||
247 | $this->setProperty( |
||
248 | 'name', |
||
249 | 'N' . $this->getCharsetString(), |
||
250 | $property |
||
251 | ); |
||
252 | |||
253 | // is property FN set? |
||
254 | if (!$this->hasProperty('FN')) { |
||
255 | // set property |
||
256 | $this->setProperty( |
||
257 | 'fullname', |
||
258 | 'FN' . $this->getCharsetString(), |
||
259 | trim(implode(' ', $values)) |
||
260 | ); |
||
261 | } |
||
262 | |||
263 | return $this; |
||
264 | } |
||
265 | |||
266 | /** |
||
267 | * Add note |
||
268 | * |
||
269 | * @param string $note |
||
270 | * @return $this |
||
271 | */ |
||
272 | public function addNote($note) |
||
273 | { |
||
274 | $this->setProperty( |
||
275 | 'note', |
||
276 | 'NOTE' . $this->getCharsetString(), |
||
277 | $note |
||
278 | ); |
||
279 | |||
280 | return $this; |
||
281 | } |
||
282 | |||
283 | /** |
||
284 | * Add phone number |
||
285 | * |
||
286 | * @param string $number |
||
287 | * @param string [optional] $type |
||
288 | * Type may be PREF | WORK | HOME | VOICE | FAX | MSG | |
||
289 | * CELL | PAGER | BBS | CAR | MODEM | ISDN | VIDEO |
||
290 | * or any senseful combination, e.g. "PREF;WORK;VOICE" |
||
291 | * @return $this |
||
292 | */ |
||
293 | public function addPhoneNumber($number, $type = '') |
||
303 | |||
304 | /** |
||
305 | * Add Logo |
||
306 | * |
||
307 | * @param string $url image url or filename |
||
308 | * @param bool $include Include the image in our vcard? |
||
309 | * @return $this |
||
310 | */ |
||
311 | public function addLogo($url, $include = true) |
||
322 | |||
323 | /** |
||
324 | * Add Photo |
||
325 | * |
||
326 | * @param string $url image url or filename |
||
327 | * @param bool $include Include the image in our vcard? |
||
328 | * @return $this |
||
329 | */ |
||
330 | public function addPhoto($url, $include = true) |
||
341 | |||
342 | /** |
||
343 | * Add URL |
||
344 | * |
||
345 | * @param string $url |
||
346 | * @param string [optional] $type Type may be WORK | HOME |
||
347 | * @return $this |
||
348 | */ |
||
349 | public function addURL($url, $type = '') |
||
359 | |||
360 | /** |
||
361 | * Build VCard (.vcf) |
||
362 | * |
||
363 | * @return string |
||
364 | */ |
||
365 | public function buildVCard() |
||
385 | |||
386 | /** |
||
387 | * Build VCalender (.ics) - Safari (< iOS 8) can not open .vcf files, so we have build a workaround. |
||
388 | * |
||
389 | * @return string |
||
390 | */ |
||
391 | public function buildVCalendar() |
||
426 | |||
427 | /** |
||
428 | * Returns the browser user agent string. |
||
429 | * |
||
430 | * @return string |
||
431 | */ |
||
432 | protected function getUserAgent() |
||
442 | |||
443 | /** |
||
444 | * Decode |
||
445 | * |
||
446 | * @param string $value The value to decode |
||
447 | * @return string decoded |
||
448 | */ |
||
449 | private function decode($value) |
||
454 | |||
455 | /** |
||
456 | * Download a vcard or vcal file to the browser. |
||
457 | */ |
||
458 | public function download() |
||
470 | |||
471 | /** |
||
472 | * Fold a line according to RFC2425 section 5.8.1. |
||
473 | * |
||
474 | * @link http://tools.ietf.org/html/rfc2425#section-5.8.1 |
||
475 | * @param string $text |
||
476 | * @return mixed |
||
477 | */ |
||
478 | protected function fold($text) |
||
487 | |||
488 | /** |
||
489 | * Get output as string |
||
490 | * @deprecated in the future |
||
491 | * |
||
492 | * @return string |
||
493 | */ |
||
494 | public function get() |
||
498 | |||
499 | /** |
||
500 | * Get charset |
||
501 | * |
||
502 | * @return string |
||
503 | */ |
||
504 | public function getCharset() |
||
508 | |||
509 | /** |
||
510 | * Get charset string |
||
511 | * |
||
512 | * @return string |
||
513 | */ |
||
514 | public function getCharsetString() |
||
522 | |||
523 | /** |
||
524 | * Get content type |
||
525 | * |
||
526 | * @return string |
||
527 | */ |
||
528 | public function getContentType() |
||
533 | |||
534 | /** |
||
535 | * Get filename |
||
536 | * |
||
537 | * @return string |
||
538 | */ |
||
539 | public function getFilename() |
||
543 | |||
544 | /** |
||
545 | * Get file extension |
||
546 | * |
||
547 | * @return string |
||
548 | */ |
||
549 | public function getFileExtension() |
||
554 | |||
555 | /** |
||
556 | * Get headers |
||
557 | * |
||
558 | * @param bool $asAssociative |
||
559 | * @return array |
||
560 | */ |
||
561 | public function getHeaders($asAssociative) |
||
584 | |||
585 | /** |
||
586 | * Get output as string |
||
587 | * iOS devices (and safari < iOS 8 in particular) can not read .vcf (= vcard) files. |
||
588 | * So I build a workaround to build a .ics (= vcalender) file. |
||
589 | * |
||
590 | * @return string |
||
591 | */ |
||
592 | public function getOutput() |
||
599 | |||
600 | /** |
||
601 | * Get properties |
||
602 | * |
||
603 | * @return array |
||
604 | */ |
||
605 | public function getProperties() |
||
609 | |||
610 | /** |
||
611 | * Has property |
||
612 | * |
||
613 | * @param string $key |
||
614 | * @return bool |
||
615 | */ |
||
616 | public function hasProperty($key) |
||
628 | |||
629 | /** |
||
630 | * Is iOS - Check if the user is using an iOS-device |
||
631 | * |
||
632 | * @return bool |
||
633 | */ |
||
634 | public function isIOS() |
||
641 | |||
642 | /** |
||
643 | * Is iOS less than 7 (should cal wrapper be returned) |
||
644 | * |
||
645 | * @return bool |
||
646 | */ |
||
647 | public function isIOS7() |
||
651 | |||
652 | /** |
||
653 | * Save to a file |
||
654 | * |
||
655 | * @return void |
||
656 | */ |
||
657 | public function save() |
||
666 | |||
667 | /** |
||
668 | * Set charset |
||
669 | * |
||
670 | * @param mixed $charset |
||
671 | * @return void |
||
672 | */ |
||
673 | public function setCharset($charset) |
||
677 | |||
678 | /** |
||
679 | * Set filename |
||
680 | * |
||
681 | * @param mixed $value |
||
682 | * @param bool $overwrite [optional] Default overwrite is true |
||
683 | * @param string $separator [optional] Default separator is an underscore '_' |
||
684 | * @return void |
||
685 | */ |
||
686 | public function setFilename($value, $overwrite = true, $separator = '_') |
||
714 | |||
715 | /** |
||
716 | * Set property |
||
717 | * |
||
718 | * @param string $element The element name you want to set, f.e.: name, email, phoneNumber, ... |
||
719 | * @param string $key |
||
720 | * @param string $value |
||
721 | * @return void |
||
722 | */ |
||
723 | private function setProperty($element, $key, $value) |
||
740 | |||
741 | /** |
||
742 | * Checks if we should return vcard in cal wrapper |
||
743 | * |
||
744 | * @return bool |
||
745 | */ |
||
746 | protected function shouldAttachmentBeCal() |
||
756 | } |
||
757 |
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: