Complex classes like VCard often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use VCard, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
19 | class VCard |
||
20 | { |
||
21 | /** |
||
22 | * definedElements |
||
23 | * |
||
24 | * @var array |
||
25 | */ |
||
26 | private $definedElements; |
||
27 | |||
28 | /** |
||
29 | * Filename |
||
30 | * |
||
31 | * @var string |
||
32 | */ |
||
33 | private $filename; |
||
34 | |||
35 | /** |
||
36 | * Multiple properties for element allowed |
||
37 | * |
||
38 | * @var array |
||
39 | */ |
||
40 | private $multiplePropertiesForElementAllowed = array( |
||
41 | 'email', |
||
42 | 'address', |
||
43 | 'phoneNumber', |
||
44 | 'url' |
||
45 | ); |
||
46 | |||
47 | /** |
||
48 | * Properties |
||
49 | * |
||
50 | * @var array |
||
51 | */ |
||
52 | private $properties; |
||
53 | |||
54 | /** |
||
55 | * Default Charset |
||
56 | * |
||
57 | * @var string |
||
58 | */ |
||
59 | public $charset = 'utf-8'; |
||
60 | |||
61 | /** |
||
62 | * Add address |
||
63 | * |
||
64 | * @param string [optional] $name |
||
65 | * @param string [optional] $extended |
||
66 | * @param string [optional] $street |
||
67 | * @param string [optional] $city |
||
68 | * @param string [optional] $region |
||
69 | * @param string [optional] $zip |
||
70 | * @param string [optional] $country |
||
71 | * @param string [optional] $type |
||
72 | * $type may be DOM | INTL | POSTAL | PARCEL | HOME | WORK |
||
73 | * or any combination of these: e.g. "WORK;PARCEL;POSTAL" |
||
74 | * @return $this |
||
75 | */ |
||
76 | public function addAddress( |
||
98 | |||
99 | /** |
||
100 | * Add birthday |
||
101 | * |
||
102 | * @param string $date Format is YYYY-MM-DD |
||
103 | * @return $this |
||
104 | */ |
||
105 | public function addBirthday($date) |
||
115 | |||
116 | /** |
||
117 | * Add company |
||
118 | * |
||
119 | * @param string $company |
||
120 | * @return $this |
||
121 | */ |
||
122 | public function addCompany($company) |
||
123 | { |
||
124 | $this->setProperty( |
||
125 | 'company', |
||
126 | 'ORG' . $this->getCharsetString(), |
||
127 | $company |
||
128 | ); |
||
129 | |||
130 | // if filename is empty, add to filename |
||
131 | if ($this->getFilename() === null) { |
||
132 | $this->setFilename($company); |
||
133 | } |
||
134 | |||
135 | return $this; |
||
136 | } |
||
137 | |||
138 | /** |
||
139 | * Add email |
||
140 | * |
||
141 | * @param string $address The e-mail address |
||
142 | * @param string [optional] $type The type of the email address |
||
143 | * $type may be PREF | WORK | HOME |
||
144 | * or any combination of these: e.g. "PREF;WORK" |
||
145 | * @return $this |
||
146 | */ |
||
147 | public function addEmail($address, $type = '') |
||
157 | |||
158 | /** |
||
159 | * Add jobtitle |
||
160 | * |
||
161 | * @param string $jobtitle The jobtitle for the person. |
||
162 | * @return $this |
||
163 | */ |
||
164 | public function addJobtitle($jobtitle) |
||
174 | |||
175 | /** |
||
176 | * Add a photo or logo (depending on property name) |
||
177 | * |
||
178 | * @param string $property LOGO|PHOTO |
||
179 | * @param string $url image url or filename |
||
180 | * @param bool $include Do we include the image in our vcard or not? |
||
181 | * @throws VCardMediaException if file is empty or not an image file |
||
182 | */ |
||
183 | private function addMedia($property, $url, $include = true, $element) |
||
240 | |||
241 | /** |
||
242 | * Add name |
||
243 | * |
||
244 | * @param string [optional] $lastName |
||
245 | * @param string [optional] $firstName |
||
246 | * @param string [optional] $additional |
||
247 | * @param string [optional] $prefix |
||
248 | * @param string [optional] $suffix |
||
249 | * @return $this |
||
250 | */ |
||
251 | public function addName( |
||
290 | |||
291 | /** |
||
292 | * Add note |
||
293 | * |
||
294 | * @param string $note |
||
295 | * @return $this |
||
296 | */ |
||
297 | public function addNote($note) |
||
307 | |||
308 | /** |
||
309 | * Add phone number |
||
310 | * |
||
311 | * @param string $number |
||
312 | * @param string [optional] $type |
||
313 | * Type may be PREF | WORK | HOME | VOICE | FAX | MSG | |
||
314 | * CELL | PAGER | BBS | CAR | MODEM | ISDN | VIDEO |
||
315 | * or any senseful combination, e.g. "PREF;WORK;VOICE" |
||
316 | * @return $this |
||
317 | */ |
||
318 | public function addPhoneNumber($number, $type = '') |
||
328 | |||
329 | /** |
||
330 | * Add Photo |
||
331 | * |
||
332 | * @param string $url image url or filename |
||
333 | * @param bool $include Include the image in our vcard? |
||
334 | * @return $this |
||
335 | */ |
||
336 | public function addPhoto($url, $include = true) |
||
347 | |||
348 | /** |
||
349 | * Add URL |
||
350 | * |
||
351 | * @param string $url |
||
352 | * @param string [optional] $type Type may be WORK | HOME |
||
353 | * @return $this |
||
354 | */ |
||
355 | public function addURL($url, $type = '') |
||
365 | |||
366 | /** |
||
367 | * Build VCard (.vcf) |
||
368 | * |
||
369 | * @return string |
||
370 | */ |
||
371 | public function buildVCard() |
||
391 | |||
392 | /** |
||
393 | * Build VCalender (.ics) - Safari (< iOS 8) can not open .vcf files, so we have build a workaround. |
||
394 | * |
||
395 | * @return string |
||
396 | */ |
||
397 | public function buildVCalendar() |
||
432 | |||
433 | /** |
||
434 | * Returns the browser user agent string. |
||
435 | * |
||
436 | * @return string |
||
437 | */ |
||
438 | protected function getUserAgent() |
||
448 | |||
449 | /** |
||
450 | * Decode |
||
451 | * |
||
452 | * @param string $value The value to decode |
||
453 | * @return string decoded |
||
454 | */ |
||
455 | private function decode($value) |
||
460 | |||
461 | /** |
||
462 | * Download a vcard or vcal file to the browser. |
||
463 | */ |
||
464 | public function download() |
||
476 | |||
477 | /** |
||
478 | * Fold a line according to RFC2425 section 5.8.1. |
||
479 | * |
||
480 | * @link http://tools.ietf.org/html/rfc2425#section-5.8.1 |
||
481 | * @param string $text |
||
482 | * @return mixed |
||
483 | */ |
||
484 | protected function fold($text) |
||
493 | |||
494 | /** |
||
495 | * Escape newline characters according to RFC2425 section 5.8.4. |
||
496 | * |
||
497 | * @link http://tools.ietf.org/html/rfc2425#section-5.8.4 |
||
498 | * @param string $text |
||
499 | * @return string |
||
500 | */ |
||
501 | protected function escape($text) |
||
508 | |||
509 | /** |
||
510 | * Get output as string |
||
511 | * @deprecated in the future |
||
512 | * |
||
513 | * @return string |
||
514 | */ |
||
515 | public function get() |
||
519 | |||
520 | /** |
||
521 | * Get charset |
||
522 | * |
||
523 | * @return string |
||
524 | */ |
||
525 | public function getCharset() |
||
529 | |||
530 | /** |
||
531 | * Get charset string |
||
532 | * |
||
533 | * @return string |
||
534 | */ |
||
535 | public function getCharsetString() |
||
543 | |||
544 | /** |
||
545 | * Get content type |
||
546 | * |
||
547 | * @return string |
||
548 | */ |
||
549 | public function getContentType() |
||
554 | |||
555 | /** |
||
556 | * Get filename |
||
557 | * |
||
558 | * @return string |
||
559 | */ |
||
560 | public function getFilename() |
||
564 | |||
565 | /** |
||
566 | * Get file extension |
||
567 | * |
||
568 | * @return string |
||
569 | */ |
||
570 | public function getFileExtension() |
||
575 | |||
576 | /** |
||
577 | * Get headers |
||
578 | * |
||
579 | * @param bool $asAssociative |
||
580 | * @return array |
||
581 | */ |
||
582 | public function getHeaders($asAssociative) |
||
605 | |||
606 | /** |
||
607 | * Get output as string |
||
608 | * iOS devices (and safari < iOS 8 in particular) can not read .vcf (= vcard) files. |
||
609 | * So I build a workaround to build a .ics (= vcalender) file. |
||
610 | * |
||
611 | * @return string |
||
612 | */ |
||
613 | public function getOutput() |
||
620 | |||
621 | /** |
||
622 | * Get properties |
||
623 | * |
||
624 | * @return array |
||
625 | */ |
||
626 | public function getProperties() |
||
630 | |||
631 | /** |
||
632 | * Has property |
||
633 | * |
||
634 | * @param string $key |
||
635 | * @return bool |
||
636 | */ |
||
637 | public function hasProperty($key) |
||
649 | |||
650 | /** |
||
651 | * Is iOS - Check if the user is using an iOS-device |
||
652 | * |
||
653 | * @return bool |
||
654 | */ |
||
655 | public function isIOS() |
||
662 | |||
663 | /** |
||
664 | * Is iOS less than 7 (should cal wrapper be returned) |
||
665 | * |
||
666 | * @return bool |
||
667 | */ |
||
668 | public function isIOS7() |
||
672 | |||
673 | /** |
||
674 | * Save to a file |
||
675 | * |
||
676 | * @return void |
||
677 | */ |
||
678 | public function save() |
||
687 | |||
688 | /** |
||
689 | * Set charset |
||
690 | * |
||
691 | * @param mixed $charset |
||
692 | * @return void |
||
693 | */ |
||
694 | public function setCharset($charset) |
||
698 | |||
699 | /** |
||
700 | * Set filename |
||
701 | * |
||
702 | * @param mixed $value |
||
703 | * @param bool $overwrite [optional] Default overwrite is true |
||
704 | * @param string $separator [optional] Default separator is an underscore '_' |
||
705 | * @return void |
||
706 | */ |
||
707 | public function setFilename($value, $overwrite = true, $separator = '_') |
||
735 | |||
736 | /** |
||
737 | * Set property |
||
738 | * |
||
739 | * @param string $element The element name you want to set, f.e.: name, email, phoneNumber, ... |
||
740 | * @param string $key |
||
741 | * @param string $value |
||
742 | * @return void |
||
743 | */ |
||
744 | private function setProperty($element, $key, $value) |
||
761 | |||
762 | /** |
||
763 | * Checks if we should return vcard in cal wrapper |
||
764 | * |
||
765 | * @return bool |
||
766 | */ |
||
767 | protected function shouldAttachmentBeCal() |
||
777 | } |
||
778 |
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: