Complex classes like VCard often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use VCard, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 19 | class VCard |
||
| 20 | { |
||
| 21 | /** |
||
| 22 | * definedElements |
||
| 23 | * |
||
| 24 | * @var array |
||
| 25 | */ |
||
| 26 | private $definedElements; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * Filename |
||
| 30 | * |
||
| 31 | * @var string |
||
| 32 | */ |
||
| 33 | private $filename; |
||
| 34 | |||
| 35 | /** |
||
| 36 | * Multiple properties for element allowed |
||
| 37 | * |
||
| 38 | * @var array |
||
| 39 | */ |
||
| 40 | private $multiplePropertiesForElementAllowed = array( |
||
| 41 | 'email', |
||
| 42 | 'address', |
||
| 43 | 'phoneNumber', |
||
| 44 | 'url' |
||
| 45 | ); |
||
| 46 | |||
| 47 | /** |
||
| 48 | * Properties |
||
| 49 | * |
||
| 50 | * @var array |
||
| 51 | */ |
||
| 52 | private $properties; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * Default Charset |
||
| 56 | * |
||
| 57 | * @var string |
||
| 58 | */ |
||
| 59 | public $charset = 'utf-8'; |
||
| 60 | |||
| 61 | /** |
||
| 62 | * Add address |
||
| 63 | * |
||
| 64 | * @param string [optional] $name |
||
| 65 | * @param string [optional] $extended |
||
| 66 | * @param string [optional] $street |
||
| 67 | * @param string [optional] $city |
||
| 68 | * @param string [optional] $region |
||
| 69 | * @param string [optional] $zip |
||
| 70 | * @param string [optional] $country |
||
| 71 | * @param string [optional] $type |
||
| 72 | * $type may be DOM | INTL | POSTAL | PARCEL | HOME | WORK |
||
| 73 | * or any combination of these: e.g. "WORK;PARCEL;POSTAL" |
||
| 74 | * @return $this |
||
| 75 | */ |
||
| 76 | public function addAddress( |
||
| 98 | |||
| 99 | /** |
||
| 100 | * Add birthday |
||
| 101 | * |
||
| 102 | * @param string $date Format is YYYY-MM-DD |
||
| 103 | * @return $this |
||
| 104 | */ |
||
| 105 | public function addBirthday($date) |
||
| 115 | |||
| 116 | /** |
||
| 117 | * Add company |
||
| 118 | * |
||
| 119 | * @param string $company |
||
| 120 | * @return $this |
||
| 121 | */ |
||
| 122 | public function addCompany($company) |
||
| 137 | |||
| 138 | /** |
||
| 139 | * Add email |
||
| 140 | * |
||
| 141 | * @param string $address The e-mail address |
||
| 142 | * @param string [optional] $type The type of the email address |
||
| 143 | * $type may be PREF | WORK | HOME |
||
| 144 | * or any combination of these: e.g. "PREF;WORK" |
||
| 145 | * @return $this |
||
| 146 | */ |
||
| 147 | public function addEmail($address, $type = '') |
||
| 157 | |||
| 158 | /** |
||
| 159 | * Add jobtitle |
||
| 160 | * |
||
| 161 | * @param string $jobtitle The jobtitle for the person. |
||
| 162 | * @return $this |
||
| 163 | */ |
||
| 164 | public function addJobtitle($jobtitle) |
||
| 174 | |||
| 175 | /** |
||
| 176 | * Add a photo or logo (depending on property name) |
||
| 177 | * |
||
| 178 | * @param string $property LOGO|PHOTO |
||
| 179 | * @param string $url image url or filename |
||
| 180 | * @param bool $include Do we include the image in our vcard or not? |
||
| 181 | * @throws VCardMediaException if file is empty or not an image file |
||
| 182 | */ |
||
| 183 | private function addMedia($property, $url, $include = true, $element) |
||
| 215 | |||
| 216 | /** |
||
| 217 | * Add name |
||
| 218 | * |
||
| 219 | * @param string [optional] $lastName |
||
| 220 | * @param string [optional] $firstName |
||
| 221 | * @param string [optional] $additional |
||
| 222 | * @param string [optional] $prefix |
||
| 223 | * @param string [optional] $suffix |
||
| 224 | * @return $this |
||
| 225 | */ |
||
| 226 | public function addName( |
||
| 265 | |||
| 266 | /** |
||
| 267 | * Add note |
||
| 268 | * |
||
| 269 | * @param string $note |
||
| 270 | * @return $this |
||
| 271 | */ |
||
| 272 | public function addNote($note) |
||
| 282 | |||
| 283 | /** |
||
| 284 | * Add phone number |
||
| 285 | * |
||
| 286 | * @param string $number |
||
| 287 | * @param string [optional] $type |
||
| 288 | * Type may be PREF | WORK | HOME | VOICE | FAX | MSG | |
||
| 289 | * CELL | PAGER | BBS | CAR | MODEM | ISDN | VIDEO |
||
| 290 | * or any senseful combination, e.g. "PREF;WORK;VOICE" |
||
| 291 | * @return $this |
||
| 292 | */ |
||
| 293 | public function addPhoneNumber($number, $type = '') |
||
| 303 | |||
| 304 | /** |
||
| 305 | * Add Logo |
||
| 306 | * |
||
| 307 | * @param string $url image url or filename |
||
| 308 | * @param bool $include Include the image in our vcard? |
||
| 309 | * @return $this |
||
| 310 | */ |
||
| 311 | public function addLogo($url, $include = true) |
||
| 322 | |||
| 323 | /** |
||
| 324 | * Add Photo |
||
| 325 | * |
||
| 326 | * @param string $url image url or filename |
||
| 327 | * @param bool $include Include the image in our vcard? |
||
| 328 | * @return $this |
||
| 329 | */ |
||
| 330 | public function addPhoto($url, $include = true) |
||
| 341 | |||
| 342 | /** |
||
| 343 | * Add URL |
||
| 344 | * |
||
| 345 | * @param string $url |
||
| 346 | * @param string [optional] $type Type may be WORK | HOME |
||
| 347 | * @return $this |
||
| 348 | */ |
||
| 349 | public function addURL($url, $type = '') |
||
| 359 | |||
| 360 | /** |
||
| 361 | * Build VCard (.vcf) |
||
| 362 | * |
||
| 363 | * @return string |
||
| 364 | */ |
||
| 365 | public function buildVCard() |
||
| 385 | |||
| 386 | /** |
||
| 387 | * Build VCalender (.ics) - Safari (< iOS 8) can not open .vcf files, so we have build a workaround. |
||
| 388 | * |
||
| 389 | * @return string |
||
| 390 | */ |
||
| 391 | public function buildVCalendar() |
||
| 426 | |||
| 427 | /** |
||
| 428 | * Returns the browser user agent string. |
||
| 429 | * |
||
| 430 | * @return string |
||
| 431 | */ |
||
| 432 | protected function getUserAgent() |
||
| 442 | |||
| 443 | /** |
||
| 444 | * Decode |
||
| 445 | * |
||
| 446 | * @param string $value The value to decode |
||
| 447 | * @return string decoded |
||
| 448 | */ |
||
| 449 | private function decode($value) |
||
| 454 | |||
| 455 | /** |
||
| 456 | * Download a vcard or vcal file to the browser. |
||
| 457 | */ |
||
| 458 | public function download() |
||
| 470 | |||
| 471 | /** |
||
| 472 | * Fold a line according to RFC2425 section 5.8.1. |
||
| 473 | * |
||
| 474 | * @link http://tools.ietf.org/html/rfc2425#section-5.8.1 |
||
| 475 | * @param string $text |
||
| 476 | * @return mixed |
||
| 477 | */ |
||
| 478 | protected function fold($text) |
||
| 487 | |||
| 488 | /** |
||
| 489 | * Get output as string |
||
| 490 | * @deprecated in the future |
||
| 491 | * |
||
| 492 | * @return string |
||
| 493 | */ |
||
| 494 | public function get() |
||
| 498 | |||
| 499 | /** |
||
| 500 | * Get charset |
||
| 501 | * |
||
| 502 | * @return string |
||
| 503 | */ |
||
| 504 | public function getCharset() |
||
| 508 | |||
| 509 | /** |
||
| 510 | * Get content type |
||
| 511 | * |
||
| 512 | * @return string |
||
| 513 | */ |
||
| 514 | public function getContentType() |
||
| 519 | |||
| 520 | /** |
||
| 521 | * Get filename |
||
| 522 | * |
||
| 523 | * @return string |
||
| 524 | */ |
||
| 525 | public function getFilename() |
||
| 529 | |||
| 530 | /** |
||
| 531 | * Get file extension |
||
| 532 | * |
||
| 533 | * @return string |
||
| 534 | */ |
||
| 535 | public function getFileExtension() |
||
| 540 | |||
| 541 | /** |
||
| 542 | * Get headers |
||
| 543 | * |
||
| 544 | * @param bool $asAssociative |
||
| 545 | * @return array |
||
| 546 | */ |
||
| 547 | public function getHeaders($asAssociative) |
||
| 570 | |||
| 571 | /** |
||
| 572 | * Get output as string |
||
| 573 | * iOS devices (and safari < iOS 8 in particular) can not read .vcf (= vcard) files. |
||
| 574 | * So I build a workaround to build a .ics (= vcalender) file. |
||
| 575 | * |
||
| 576 | * @return string |
||
| 577 | */ |
||
| 578 | public function getOutput() |
||
| 590 | |||
| 591 | /** |
||
| 592 | * Get properties |
||
| 593 | * |
||
| 594 | * @return array |
||
| 595 | */ |
||
| 596 | public function getProperties() |
||
| 600 | |||
| 601 | /** |
||
| 602 | * Has property |
||
| 603 | * |
||
| 604 | * @param string $key |
||
| 605 | * @return bool |
||
| 606 | */ |
||
| 607 | public function hasProperty($key) |
||
| 619 | |||
| 620 | /** |
||
| 621 | * Is iOS - Check if the user is using an iOS-device |
||
| 622 | * |
||
| 623 | * @return bool |
||
| 624 | */ |
||
| 625 | public function isIOS() |
||
| 632 | |||
| 633 | /** |
||
| 634 | * Is iOS less than 7 (should cal wrapper be returned) |
||
| 635 | * |
||
| 636 | * @return bool |
||
| 637 | */ |
||
| 638 | public function isIOS7() |
||
| 642 | |||
| 643 | /** |
||
| 644 | * Save to a file |
||
| 645 | * |
||
| 646 | * @return void |
||
| 647 | */ |
||
| 648 | public function save() |
||
| 657 | |||
| 658 | /** |
||
| 659 | * Set charset |
||
| 660 | * |
||
| 661 | * @param mixed $charset |
||
| 662 | * @return void |
||
| 663 | */ |
||
| 664 | public function setCharset($charset) |
||
| 668 | |||
| 669 | /** |
||
| 670 | * Set filename |
||
| 671 | * |
||
| 672 | * @param mixed $value |
||
| 673 | * @param bool $overwrite [optional] Default overwrite is true |
||
| 674 | * @param string $separator [optional] Default separator is an underscore '_' |
||
| 675 | * @return void |
||
| 676 | */ |
||
| 677 | public function setFilename($value, $overwrite = true, $separator = '_') |
||
| 705 | |||
| 706 | /** |
||
| 707 | * Set property |
||
| 708 | * |
||
| 709 | * @param string $element The element name you want to set, f.e.: name, email, phoneNumber, ... |
||
| 710 | * @param string $key |
||
| 711 | * @param string $value |
||
| 712 | * @return void |
||
| 713 | */ |
||
| 714 | private function setProperty($element, $key, $value) |
||
| 731 | |||
| 732 | /** |
||
| 733 | * Checks if we should return vcard in cal wrapper |
||
| 734 | * |
||
| 735 | * @return bool |
||
| 736 | */ |
||
| 737 | protected function shouldAttachmentBeCal() |
||
| 747 | } |
||
| 748 |
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: